Bug 1408695 - Work around a VS2017 constexpr pointer math bug in HTMLTrackElement.cpp. r=gerald, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
authorDavid Major <dmajor@mozilla.com>
Sat, 14 Oct 2017 21:09:05 -0400
branchSEAMONKEY_2_49_ESR_RELBRANCH
changeset 357476 1b9aa9753d8ddee709edf8f00a728d7ce9ca4cef
parent 357475 c44482b0a53be1def0676a02783f4d6a10a07016
child 357477 3704932e1d30253bbd2ccb0e2c8519b87aaee715
push id7834
push userfrgrahl@gmx.net
push dateSun, 13 Jan 2019 12:17:02 +0000
treeherdermozilla-esr52@6e4ad8a8f2e8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald, IanN
bugs1408695
milestone52.9.1
Bug 1408695 - Work around a VS2017 constexpr pointer math bug in HTMLTrackElement.cpp. r=gerald, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
dom/html/HTMLTrackElement.cpp
--- a/dom/html/HTMLTrackElement.cpp
+++ b/dom/html/HTMLTrackElement.cpp
@@ -63,17 +63,17 @@ static constexpr nsAttrValue::EnumTable 
   { "descriptions", static_cast<int16_t>(TextTrackKind::Descriptions) },
   { "chapters", static_cast<int16_t>(TextTrackKind::Chapters) },
   { "metadata", static_cast<int16_t>(TextTrackKind::Metadata) },
   { nullptr, 0 }
 };
 
 // Invalid values are treated as "metadata" in ParseAttribute, but if no value
 // at all is specified, it's treated as "subtitles" in GetKind
-static constexpr const nsAttrValue::EnumTable* kKindTableInvalidValueDefault = &kKindTable[4];
+static const nsAttrValue::EnumTable* const kKindTableInvalidValueDefault = &kKindTable[4];
 
 class WindowDestroyObserver final : public nsIObserver
 {
   NS_DECL_ISUPPORTS
 
 public:
   explicit WindowDestroyObserver(HTMLTrackElement* aElement, uint64_t aWinID)
     : mTrackElement(aElement)