Bug 1173764 - Enable LAllocation/LUse serialization in optimized builds. r=bhackett
☠☠ backed out by 4c42035bc7f8 ☠ ☠
authorNicolas B. Pierron <nicolas.b.pierron@mozilla.com>
Fri, 19 Jun 2015 15:17:24 +0200
changeset 267863 13a9a4428a6867e97dd8fb6c9f551ef142e58755
parent 267862 5a2ecacde67d54a78d012cae732613684163098e
child 267864 0aa70076583fdd84eaf77245dc3c3108e65ba5e0
push id4932
push userjlund@mozilla.com
push dateMon, 10 Aug 2015 18:23:06 +0000
treeherdermozilla-esr52@6dd5a4f5f745 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbhackett
bugs1173764
milestone41.0a1
Bug 1173764 - Enable LAllocation/LUse serialization in optimized builds. r=bhackett
js/src/jit/LIR.cpp
js/src/jit/LIR.h
--- a/js/src/jit/LIR.cpp
+++ b/js/src/jit/LIR.cpp
@@ -335,17 +335,16 @@ LNode::printName(GenericPrinter& out)
 bool
 LAllocation::aliases(const LAllocation& other) const
 {
     if (isFloatReg() && other.isFloatReg())
         return toFloatReg()->reg().aliases(other.toFloatReg()->reg());
     return *this == other;
 }
 
-#ifdef DEBUG
 static const char * const TypeChars[] =
 {
     "g",            // GENERAL
     "i",            // INT32
     "o",            // OBJECT
     "s",            // SLOTS
     "f",            // FLOAT32
     "d",            // DOUBLE
@@ -439,17 +438,16 @@ LAllocation::toString() const
         return buf;
       case LAllocation::USE:
         PrintUse(buf, sizeof(buf), toUse());
         return buf;
       default:
         MOZ_CRASH("what?");
     }
 }
-#endif // DEBUG
 
 void
 LAllocation::dump() const
 {
     fprintf(stderr, "%s\n", toString());
 }
 
 void
--- a/js/src/jit/LIR.h
+++ b/js/src/jit/LIR.h
@@ -178,21 +178,17 @@ class LAllocation : public TempObject
     bool operator !=(const LAllocation& other) const {
         return bits_ != other.bits_;
     }
 
     HashNumber hash() const {
         return bits_;
     }
 
-#ifdef DEBUG
     const char* toString() const;
-#else
-    const char* toString() const { return "???"; }
-#endif
     bool aliases(const LAllocation& other) const;
     void dump() const;
 
 };
 
 class LUse : public LAllocation
 {
     static const uint32_t POLICY_BITS = 3;
@@ -575,21 +571,17 @@ class LDefinition
             return LDefinition::INT32X4;
           case MIRType_Float32x4:
             return LDefinition::FLOAT32X4;
           default:
             MOZ_CRASH("unexpected type");
         }
     }
 
-#ifdef DEBUG
     const char* toString() const;
-#else
-    const char* toString() const { return "???"; }
-#endif
 
     void dump() const;
 };
 
 // Forward declarations of LIR types.
 #define LIROP(op) class L##op;
     LIR_OPCODE_LIST(LIROP)
 #undef LIROP