Bug 1321799 - Use decimal format placeholder for filesize. r=sebastian, a=test-only
authorAndrzej Hunt <ahunt@mozilla.com>
Fri, 02 Dec 2016 21:57:33 -0800
changeset 353015 12a5aceb1187f5f9ddf64298383ec47d62c8b728
parent 353014 cf05a9412d74507d07f3c6893141ba43ddb8bbaf
child 353016 4e2f3b47bac35f994f3e3daffd93aced4f479c45
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-esr52@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian, test-only
bugs1321799
milestone52.0a2
Bug 1321799 - Use decimal format placeholder for filesize. r=sebastian, a=test-only %l seems to be for hour in 12hr clock (i.e. 1-12), but we're applying it to a filesize. %d seems more appropriate in order to display the actual raw filesize. MozReview-Commit-ID: AKTpYndm81o
mobile/android/base/java/org/mozilla/gecko/telemetry/stores/TelemetryJSONFilePingStore.java
--- a/mobile/android/base/java/org/mozilla/gecko/telemetry/stores/TelemetryJSONFilePingStore.java
+++ b/mobile/android/base/java/org/mozilla/gecko/telemetry/stores/TelemetryJSONFilePingStore.java
@@ -191,17 +191,17 @@ public class TelemetryJSONFilePingStore 
             return null;
         }
 
         final FileInputStream inputStream;
         try {
             inputStream = new FileInputStream(file);
         } catch (final FileNotFoundException e) {
             // permission problem might also cause same exception. To get more debug information.
-            String fileInfo = String.format("existence: %b, can write: %b, size: %l.",
+            String fileInfo = String.format("existence: %b, can write: %b, size: %d.",
                     file.exists(), file.canWrite(), file.length());
             String msg = String.format(
                     "Expected file to exist but got exception in thread: %s. File info - %s",
                     Thread.currentThread().getName(), fileInfo);
             throw new IllegalStateException(msg);
         }
 
         final JSONObject obj;