searching for reviewer(mats)
3a4afe7ecac570decfb1d388eee2682d5d15dbc8: Bug 958714 part 3: Remove obsolete assertion & comment. r=mats a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH tip
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 30 Jan 2018 22:24:58 -0500 - rev 357576
Push 7836 by frgrahl@gmx.net at Mon, 15 Jul 2019 16:17:02 +0000
Bug 958714 part 3: Remove obsolete assertion & comment. r=mats a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. MozReview-Commit-ID: jL2Xi4Okhb
c90c92c68b2120d7c8382d6d5d60cfc0892e7107: Bug 958714 part 2: Simplify percent-margin/padding resolution code to pass around a single length as the percent basis. r=mats a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 30 Jan 2018 22:24:55 -0500 - rev 357575
Push 7836 by frgrahl@gmx.net at Mon, 15 Jul 2019 16:17:02 +0000
Bug 958714 part 2: Simplify percent-margin/padding resolution code to pass around a single length as the percent basis. r=mats a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. MozReview-Commit-ID: J1EPYMQ5lP4
831b454b9038a9fc8b1cdb235cdde640e398f774: Bug 958714 part 1: Remove special case for flex & grid items' percent block-axis margin/padding resolution, to align with other browsers. r=mats a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 30 Jan 2018 22:24:51 -0500 - rev 357574
Push 7836 by frgrahl@gmx.net at Mon, 15 Jul 2019 16:17:02 +0000
Bug 958714 part 1: Remove special case for flex & grid items' percent block-axis margin/padding resolution, to align with other browsers. r=mats a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. Now, flex and grid items will resolve percent margin and padding against their container's *inline-size*, even if the percent margin/padding is in the block axis. This matches the CSS2 behavior that's always existed in block containers. MozReview-Commit-ID: K3YXHpdqRHa
dc52d89bf6d8ff2cc8fa9a1c38b4088eafbda6a3: Bug 1434380: Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust. r=mats a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 30 Jan 2018 22:17:13 -0500 - rev 357573
Push 7836 by frgrahl@gmx.net at Mon, 15 Jul 2019 16:17:02 +0000
Bug 1434380: Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust. r=mats a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. In particular: - I'm specifying exact content-box sizes on some containers in the reference case, to match the actual (automatic / grid-area-determined) content-box sizes in the testcase. - I'm removing the element "w" and its selectors, since it was only used in one spot and it wasn't clear what it was being used for (and it doesn't exist in the testcase). - I'm specifying explicit margin and padding values for the ".v.r" and ".h.r" rules, based on observed values from the testcase, and I'm including comments to explain mathematically why they are correct. MozReview-Commit-ID: JKfxeTp1ZU9
ac743923f81ddf020e8a236cfc625824fc69b2fa: Bug 1324042 - Fix trimmedOffsets arithmetic in GetRenderedText(). r=mats, a=RyanVM
Daniel Holbert <dholbert@cs.stanford.edu> - Sat, 10 Feb 2018 08:46:49 -0800 - rev 356862
Push 7552 by ryanvm@gmail.com at Tue, 20 Feb 2018 21:20:17 +0000
Bug 1324042 - Fix trimmedOffsets arithmetic in GetRenderedText(). r=mats, a=RyanVM MozReview-Commit-ID: H4ngU8Juyln
de336078d36b0f6f88b0fc566a1e4132f54a78e1: Bug 1400763 - Remove display: contents pseudo frames. r=mats, a=lizzard
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 06 Nov 2017 10:59:27 -0500 - rev 356548
Push 7409 by ryanvm@gmail.com at Mon, 06 Nov 2017 15:59:42 +0000
Bug 1400763 - Remove display: contents pseudo frames. r=mats, a=lizzard The content insertion frame may be tagged instead of the primary frame. MozReview-Commit-ID: 9x5apL0sv1y
f45ba43512ad8c6d85e3f55b3fec9285128c4c13: Bug 1355168 - Ensure mTarget in CanvasRendering2D::DrawWindow. r=mats, a=ritu
Kevin Chen <kechen@mozilla.com> - Sun, 21 May 2017 23:23:00 -0400 - rev 356084
Push 7202 by ryanvm@gmail.com at Mon, 10 Jul 2017 20:12:33 +0000
Bug 1355168 - Ensure mTarget in CanvasRendering2D::DrawWindow. r=mats, a=ritu
dea90d232813befee3c736800ad140e3b5cdaf9e: Bug 779426 - Crashtest. r=mats, a=test-only
Jesse Ruderman <jruderman@gmail.com> - Thu, 13 Apr 2017 17:14:00 -0400 - rev 355829
Push 7095 by ryanvm@gmail.com at Tue, 16 May 2017 02:15:05 +0000
Bug 779426 - Crashtest. r=mats, a=test-only MozReview-Commit-ID: H7FMSmfgTfS
b08ef5a82f89190b9daaacd05b07bf63adbbdb31: Bug 1345873 - Part 1: Make flex-item sorting code treat placeholders as having the default value of 'order' / 'box-ordinal-group'. r=mats, a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 06 Apr 2017 15:14:00 -0400 - rev 355616
Push 7016 by dholbert@mozilla.com at Mon, 10 Apr 2017 16:15:19 +0000
Bug 1345873 - Part 1: Make flex-item sorting code treat placeholders as having the default value of 'order' / 'box-ordinal-group'. r=mats, a=jcristau This should allow their flex-item siblings to reorder themselves as-needed for honoring their own 'order' values, without unnecessarily reordering the placeholders. MozReview-Commit-ID: aCBQER5r2G
4f752b0e592085b49b9c46aabec8820f2cd36932: Bug 1343552 - Part 2: Record attempted misuse of gfxSkipCharsIterator via a gfxCriticalError. r=mats, a=ritu
Jonathan Kew <jkew@mozilla.com> - Mon, 06 Mar 2017 17:31:01 +0000 - rev 355317
Push 6936 by ryanvm@gmail.com at Fri, 10 Mar 2017 23:06:26 +0000
Bug 1343552 - Part 2: Record attempted misuse of gfxSkipCharsIterator via a gfxCriticalError. r=mats, a=ritu MozReview-Commit-ID: CayLp1dGSnq
8f3186a4a57b681904e64bb7568c479c5b8d599f: Bug 1340309 - Part 2: Adjust some abspos align-self/justify-self tests to better exercise "auto" value. r=mats, a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 Feb 2017 08:38:38 -0800 - rev 355224
Push 6911 by ryanvm@gmail.com at Wed, 01 Mar 2017 03:33:34 +0000
Bug 1340309 - Part 2: Adjust some abspos align-self/justify-self tests to better exercise "auto" value. r=mats, a=jcristau MozReview-Commit-ID: Glrv2aYmgbX
ec59d717d479031b8e49a88e09fc2de7b6070773: Bug 1340309 - Part 1: Resolve "align-self:auto"/"justify-self:auto" to flex/grid parent's *-items value, when resolving static pos of abspos children. r=mats, a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 Feb 2017 08:38:31 -0800 - rev 355223
Push 6911 by ryanvm@gmail.com at Wed, 01 Mar 2017 03:33:34 +0000
Bug 1340309 - Part 1: Resolve "align-self:auto"/"justify-self:auto" to flex/grid parent's *-items value, when resolving static pos of abspos children. r=mats, a=jcristau MozReview-Commit-ID: 6fSmo1WGqow
12564185b77d0a0abca9da343e94dbedf2243aff: Bug 1164766 - Clean up error checking in CanvasRenderingContext2D. r=mats, a=sledru
Markus Stange <mstange@themasta.com> - Tue, 14 Jul 2015 16:59:12 -0400 - rev 354603
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1164766 - Clean up error checking in CanvasRenderingContext2D. r=mats, a=sledru
8369d14b575e054dd85f33d6983c6833d6c58944: Bug 795418 - Test. r=mats, a=jcristau
Jorg K <jorgk@jorgk.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 354187
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 795418 - Test. r=mats, a=jcristau
8b37cad9ed3b0fa8967a2a611f727a8815adf0b7: Bug 795418 - Test. r=mats, a=jcristau
Jorg K <jorgk@jorgk.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 354126
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 795418 - Test. r=mats, a=jcristau
04c3a6ba0e1cad58fa35fc52a2ff1ee666f48472: Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau
Kearwood Gilbert <kgilbert@mozilla.com> - Wed, 25 Jan 2017 14:45:23 -0800 - rev 354003
Push 6857 by cbook@mozilla.com at Wed, 01 Feb 2017 15:29:20 +0000
Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau During the refactoring of nsSliderFrame::SetCurrentPositionInternal in Bug 957445, one of the two calls to nsSliderFrame::UpdateAttribute was missed. This resulted in the position, identified with nsGkAtoms::curpos, not being updated immediately after the call to nsSliderFrame::SetCurrentThumbPosition MozReview-Commit-ID: 6gedouG4OFX
6c44d7b72386be8362d0c536a95a92a3b0fc1a4f: Bug 1319668 - Check for null context before trying to draw canvas text. r=mats, a=jcristau
Jonathan Kew <jkew@mozilla.com> - Sat, 03 Dec 2016 14:49:46 +0000 - rev 353801
Push 6812 by ryanvm@gmail.com at Tue, 24 Jan 2017 19:16:57 +0000
Bug 1319668 - Check for null context before trying to draw canvas text. r=mats, a=jcristau
1f3bb12e7ea66181f264cb8f5f4ab125f6b56fbf: Bug 1320484 part 3: Add reftest for simple positioning of abspos child inside of a -webkit-box container. r=mats a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 09 Jan 2017 10:52:26 -0800 - rev 353446
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1320484 part 3: Add reftest for simple positioning of abspos child inside of a -webkit-box container. r=mats a=jcristau MozReview-Commit-ID: 4SIys1zdkvy
1912201626c16373c3b5ce8206cd24b93f6fdc22: Bug 1320484 part 2: Wrap abspos placeholders in anonymous flex items, in flex containers that are really emulating legacy -webkit-box containers. r=mats a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 09 Jan 2017 10:52:26 -0800 - rev 353445
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1320484 part 2: Wrap abspos placeholders in anonymous flex items, in flex containers that are really emulating legacy -webkit-box containers. r=mats a=jcristau This changeset is intended to revert the logic from "Bug 1269045 part 3" [1], *specifically* for legacy "-webkit-box"/"-webkit-inline-box" flex containers. [1] https://hg.mozilla.org/mozilla-central/rev/707b2ab5879d MozReview-Commit-ID: vc4TuAoLai
d51decb665c07ee712aee1c4044471b1607ef84e: Bug 1320484 part 1: Improve documentation for debug-only function FrameWantsToBeInAnonymousItem(), & change its arg from nsIAtom* to nsIFrame*. r=mats a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 09 Jan 2017 10:52:26 -0800 - rev 353444
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1320484 part 1: Improve documentation for debug-only function FrameWantsToBeInAnonymousItem(), & change its arg from nsIAtom* to nsIFrame*. r=mats a=jcristau This patch doesn't affect behavior at all -- it just refactors the sanity-checking function "FrameWantsToBeInAnonymousItem()", so that the next patch in this series can give it a new special case that checks a state bit on the container frame. This patch renames "parent" to "container" in this function's variable-names, for clarity, because when this function returns true, the flex/grid container is actually NOT expected to be the parent of aFrame. Rather, it's expected to be the grandparent, and the anonymous flex/grid item would be the parent. So, "aContainerFrame"/"containerType" is a bit more accurate (representing the flex/grid container for aFrame). Also worth mentioning: this patch makes FrameWantsToBeInAnonymousItem() perform its own local GetType() call, instead of accepting an already-queried GetType() result from the caller (as it previously did). Technically this could cause a slight perf hit, but it doesn't really matter since this is in "#ifdef DEBUG" sanity-checking code anyway. We could keep the nsIAtom* as an additional arg to avoid this new call, but it seems better to fall on the side of simplicity & just look up GetType() independently, rather than complicating the function signature with an extra arg. MozReview-Commit-ID: 4oJFkQMuH9c
ae40c9ff8660cbe0239161cff7ec3db1faa4c468: Bug 1321698 part 3: Fold nsFlexContainerFrame's old IsLegacyBox() function into its only remaining caller, nsFlexContainerFrame::Init(). r=mats a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 10:44:07 -0800 - rev 353441
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1321698 part 3: Fold nsFlexContainerFrame's old IsLegacyBox() function into its only remaining caller, nsFlexContainerFrame::Init(). r=mats a=jcristau This patch is to prevent any new callers of this API, since we can now rely on the new frame state bit (NS_STATE_FLEX_IS_LEGACY_WEBKIT_BOX) to test for this. MozReview-Commit-ID: BONaqPC30Cn
bd10e45827131158e9dd3948396d8859b1674fad: Bug 1321698 part 2: Use the new frame state bit to check for -webkit-box containers. r=mats a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 10:32:31 -0800 - rev 353440
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1321698 part 2: Use the new frame state bit to check for -webkit-box containers. r=mats a=jcristau Note that at the callsites in nsCSSFrameConstructor.cpp, we have to also check the frame type (since the frame state bit is in a range of bits whose meaning differs depending on frame type). The first change in this patch is the addition of a convenience fucntion that checks both the frame type as well as the frame state bit. MozReview-Commit-ID: DEOThTX5NAO
181a7b3a8c42e00c34f875a5def13cab8f9faccc: Bug 1321698 part 1: Set a frame state bit on nsFlexContainerFrame if it's emulating -webkit-box. r=mats a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 01:02:00 -0800 - rev 353439
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1321698 part 1: Set a frame state bit on nsFlexContainerFrame if it's emulating -webkit-box. r=mats a=jcristau MozReview-Commit-ID: 5eL55atUBnT
11829d96d9016ce42522fb9f4452faccd6a201b8: Bug 1269017 part 5 - [css-grid] Tag grid placeholder children as needing CSS Box Alignment, & consolidate their placement code. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 351835
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269017 part 5 - [css-grid] Tag grid placeholder children as needing CSS Box Alignment, & consolidate their placement code. r=mats MozReview-Commit-ID: 5105oez3IO3
9f2bdebbdb89d5be01e11a148812f01211dcae64: Bug 1269017 part 4 - [css-grid] When doing CSS Box Alignment, opt out of a CalculateHypotheticalPosition() clause that disregards placeholder's inline position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 351834
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269017 part 4 - [css-grid] When doing CSS Box Alignment, opt out of a CalculateHypotheticalPosition() clause that disregards placeholder's inline position. r=mats (We don't want to disregard this position -- it's what we use to encode the start of the alignment container for this child, when we're doing CSS Box Alignment. So we need it to be reflected in the hypothetical position, not disregarded.) MozReview-Commit-ID: 28IgPn8z1Hr
ab70dc086596dc45abba729112247a7b6c684b57: Bug 1269017 part 3 - [css-grid] Reduce scope of a mStaticPosIsCBOrigin check to *just* cover hypothetical-position calculation, and update comments. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 351833
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269017 part 3 - [css-grid] Reduce scope of a mStaticPosIsCBOrigin check to *just* cover hypothetical-position calculation, and update comments. r=mats Previously, I'd thought the "mStaticPosIsCBOrigin" flag was going to become obsolete -- but now I've realized it's quite useful to avert mixup between the coordinate space of the grid vs. the coordinate space of grid-areas-acting-as-abspos-containing-blocks. So, this patch clarifies/removes some stale comments about this flag, and also pulls out some code that was unnecessarily in an "else" clause, so that it happens regardless of whether this flag is set. (Note: the InitAbsoluteConstraints changes are basically just code-reordering & deindentation.) MozReview-Commit-ID: 9TFrOuldVBe
5e6f0bf39062d35752108049fb4b70cc5732f2bd: Bug 1269017 part 2 - [css-grid] Give grid an implementation of CSSAlignmentForAbsPosChild(). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 351832
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269017 part 2 - [css-grid] Give grid an implementation of CSSAlignmentForAbsPosChild(). r=mats This grid implementation is similar to the one on nsFlexContainerFrame, with a few simplifications: - We can simply use the LogicalAxis to decide between align-* vs justify-* prpoerties (whereas flexbox has extra abstraction from the flex axes). - We don't have to bother with "align-content" or "justify-content", since those apply to grid areas rather than to children. (And any grid area that's involved will be sized/positioned separately.) - Grid can unconditionally treat "flex-start" & "flex-end" as "start" & "end". MozReview-Commit-ID: 9l1Wq9Cq5T0
5795b76480b60724e3fc5e703d8f0848a88dad13: Bug 1269017 part 1 - [css-grid] Adjust OffsetToAlignedStaticPos() to use correct alignment container for abpsos children of grid containers. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 351831
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269017 part 1 - [css-grid] Adjust OffsetToAlignedStaticPos() to use correct alignment container for abpsos children of grid containers. r=mats MozReview-Commit-ID: LItIGLH5GJP
5c85b7c93c5e86011e180451c86bae49dcc49f4e: Bug 1269046 part 10: Skip the normal margin-adding codepath for abspos frames that undergo CSS Box Alignment (which takes care of margins). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 350377
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 10: Skip the normal margin-adding codepath for abspos frames that undergo CSS Box Alignment (which takes care of margins). r=mats MozReview-Commit-ID: Ha0o1rwFzE9
c8965356a17237420621f7089af5146275e5efff: Bug 1269046 part 9: Add a flag to control whether CSSAlignUtils::AlignJustifySelf() expands "auto" margins. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 350376
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 9: Add a flag to control whether CSSAlignUtils::AlignJustifySelf() expands "auto" margins. r=mats MozReview-Commit-ID: I0UdEIfiOqX
7085eed57189b0b50cc466683c153af6325ee4d4: Bug 1269046 part 8: Rewrite CSSAlignUtils::AlignJustifySelf to use a single "flags" arg instead of boolean args. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 350375
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 8: Rewrite CSSAlignUtils::AlignJustifySelf to use a single "flags" arg instead of boolean args. r=mats MozReview-Commit-ID: 5loE21U7FF6
b44098de249789c5aa196575d15e14c9b31457fb: Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 350374
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats MozReview-Commit-ID: LFQfKPlR9Gv
7978dd8d68cedf2050f9dbaae817aa59eddcbc1c: Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350373
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats Right now, there's only one flag in this new class (with no usages until a later patch). This flag suppresses a hack, which otherwise makes us transparently reverse the child list & flex axes in some circumstances, to prevent bottom-to-top child ordering. (We don't want that hack when we're dealing with individual abspos children, since it only makes things more complicated.) MozReview-Commit-ID: HYUf0vjlfiJ
6deb2d4c2f6bcfb1bbf2ed0e9ef3acf35b8c4051: Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350372
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats Right now, this method has only one stub impl, in nsContainerFrame; a later patch will add a more interesting (overriding) impl in nsFlexContainerFrame. MozReview-Commit-ID: 3U3vTTX4vdm
6d5ca25a653be1fde5d672858b8f433427dbb9fd: Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350371
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats (We'll react to the ReflowInput flags and do the actual CSS Box Alignment in a later patch in this series.) MozReview-Commit-ID: EZd7npWSzQI
85fa1048315a87dee973c70773a4fb776eedc5d3: Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350370
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats MozReview-Commit-ID: GZ35iZ2E1Iz
777060004f3ffc63cb95c1d015f548dc7743df63: Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350369
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats MozReview-Commit-ID: 5tvCIEhAsPH
707a38d83b3b735f92c6bc03269d4e834d451067: Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350368
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats MozReview-Commit-ID: 1Eh2CreOLTC
78495666fd8ce3814d8b90c9f3a890b805048f38: Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 350367
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats MozReview-Commit-ID: 5rGemcMMOhl
707b2ab5879d69e2966c97aefa5b237c5146f557: Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:17 -0700 - rev 350366
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats This patch also: * Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore. * Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly). MozReview-Commit-ID: 8canWfXk6Kf
d1135160f859f64f5a5b0ca02bf70f220e8167ce: Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:17 -0700 - rev 350365
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats MozReview-Commit-ID: 5lXUsusLryC
86fbc1fb2818ec68c7c917557639c6c0a049c75b: Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:17 -0700 - rev 350364
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats This patch makes the following specific changes: (1) Adds an early-return to both versions of the IsOrderLEQ function, to treat placeholder children as LEQ everything (including each other). This will tend to sort them to the beginning of the child list, which is unimportant but fine. More importantly, though: this means our "order"-sorting code won't reorder placeholders *with respect to each other* (since our sort algorithm is stable). So their painting order won't be affected by the "order" property, which is required by the spec. (2) Drops some nsPlaceholderFrame::GetRealFrameFor() calls -- they're unnecessary, since any placeholder frames will have prompted us to return earlier. One caveat to (2): this patch does leave a few "nsPlaceholderFrame::GetRealFrameFor()" calls in place, *for the moment*. These remaining calls are for handling placeholders that are wrapped, i.e. inside of anonymous flex items. These calls are still needed to avoid assertion-failures (i.e. to get a consistent ordering) at this point, but they'll be removed in a later patch in this same bug, when we stop wrapping placeholders in anonymous flex items. MozReview-Commit-ID: 1R6NW30Kxgv
a0008dd33cf4ef5a733c431c163dbd3793234a2f: Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349940
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats MozReview-Commit-ID: LFQfKPlR9Gv
75b58c4e61e6e51ca6d738b3a3d599476e4e9b89: Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349939
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats Right now, there's only one flag in this new class (with no usages until a later patch). This flag suppresses a hack, which otherwise makes us transparently reverse the child list & flex axes in some circumstances, to prevent bottom-to-top child ordering. (We don't want that hack when we're dealing with individual abspos children, since it only makes things more complicated.) MozReview-Commit-ID: HYUf0vjlfiJ
fb7655f3e1cf3bf9635da9e434eb7da6cf6800f9: Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349938
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats Right now, this method has only one stub impl, in nsContainerFrame; a later patch will add a more interesting (overriding) impl in nsFlexContainerFrame. MozReview-Commit-ID: 3U3vTTX4vdm
8088e5a9e6e322731d4a3008642b54a1fc0774b1: Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349937
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats (We'll react to the ReflowInput flags and do the actual CSS Box Alignment in a later patch in this series.) MozReview-Commit-ID: EZd7npWSzQI
eea6479452f0be2d7ee98f6d537106f6fe8a0d50: Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349936
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats MozReview-Commit-ID: GZ35iZ2E1Iz
eb4b52bf06ec8c1f5b33cfba7255a0d4bb64c168: Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349935
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats MozReview-Commit-ID: 5tvCIEhAsPH
539db74e4a889a6dc0605f91ff40ab7e748b996d: Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349934
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats MozReview-Commit-ID: 1Eh2CreOLTC
f57f9ac1435edc2d581c4645fa818ffd665d68f7: Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 349933
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats MozReview-Commit-ID: 5rGemcMMOhl