searching for reviewer(masayuki)
9a01f768f67ede0c0e87f7d109ed7d493db9f013: Bug 1456294 - Hook ImmAssociateContextEx. r=masayuki, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 17 May 2018 14:47:55 +0900 - rev 357525
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1456294 - Hook ImmAssociateContextEx. r=masayuki, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
014877bf17eaeb7b693989f6baa67574b2e89495: Bug 1437087 - Call Disconnect on Unlink of cycle collector. r=masayuki, a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 22 Feb 2018 12:11:53 -0500 - rev 356871
Push 7554 by ryanvm@gmail.com at Thu, 22 Feb 2018 17:12:10 +0000
Bug 1437087 - Call Disconnect on Unlink of cycle collector. r=masayuki, a=RyanVM
198ad052621e9f0fe676140a7fd60b156384d54c: Bug 1434580 - Ensure proper mouseover handling. r=masayuki, a=RyanVM
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 02 Feb 2018 13:25:26 +0200 - rev 356822
Push 7536 by ryanvm@gmail.com at Wed, 07 Feb 2018 19:11:25 +0000
Bug 1434580 - Ensure proper mouseover handling. r=masayuki, a=RyanVM
1a02f11c6efecd6b5550ffcffdb4e38e6fe170cf: Bug 1380292 - Don't turn on object resizer, inline table editor and etc when element isn't into editor. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sat, 09 Sep 2017 10:49:56 -0400 - rev 356323
Push 7299 by ryanvm@gmail.com at Mon, 11 Sep 2017 16:46:57 +0000
Bug 1380292 - Don't turn on object resizer, inline table editor and etc when element isn't into editor. r=masayuki, a=jcristau
ae110cf7759680bc379aab728199e0e0a174e1b9: Bug 1371657 - Ensure we use the right root element in editor. r=masayuki, a=jcristau
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 31 Aug 2017 12:58:12 -0400 - rev 356279
Push 7282 by ryanvm@gmail.com at Thu, 31 Aug 2017 16:58:52 +0000
Bug 1371657 - Ensure we use the right root element in editor. r=masayuki, a=jcristau
fbddb5cdd3c705d1d70afa96530a9fb0522cd7ea: Bug 1380824 - Call RepaintSelection out of script blocker. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 28 Aug 2017 10:00:34 -0400 - rev 356263
Push 7278 by ryanvm@gmail.com at Mon, 28 Aug 2017 14:01:40 +0000
Bug 1380824 - Call RepaintSelection out of script blocker. r=masayuki, a=gchang
20a1a6ad46d5a4ec83d9800614fc288bf79e14a8: Bug 1371657 - Ensure editing UI is hidden when disabling editing. r=masayuki, a=ritu FIREFOX_52_3_0esr_BUILD2 FIREFOX_52_3_0esr_RELEASE
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 02 Aug 2017 14:04:05 -0400 - rev 356194
Push 7245 by ryanvm@gmail.com at Wed, 02 Aug 2017 18:14:51 +0000
Bug 1371657 - Ensure editing UI is hidden when disabling editing. r=masayuki, a=ritu
37ccdc5fff2ba3c579b529c5029f32cbeb4d839b: Bug 1342417 - ClearStyle should check that SplitStyleAbovePoint returns node. r=masayuki, a=ritu
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 25 May 2017 17:15:54 +0900 - rev 356054
Push 7195 by ryanvm@gmail.com at Thu, 06 Jul 2017 21:29:56 +0000
Bug 1342417 - ClearStyle should check that SplitStyleAbovePoint returns node. r=masayuki, a=ritu SplitStyleAbovePoint can return null for split node, but we don't check it. Also, this crash occurs on paste operation, so I think that there is 100% reproduce test. But I cannot find it. MozReview-Commit-ID: 69OlPTc0I9h
6b174b41fa44963901d4f09597bd97f60e8e9076: Bug 1355340 - Don't attempt to accumulate line scrolls for line scroll events. r=masayuki, a=ritu
Markus Stange <mstange@themasta.com> - Thu, 20 Apr 2017 15:21:48 -0400 - rev 355830
Push 7095 by ryanvm@gmail.com at Tue, 16 May 2017 02:15:05 +0000
Bug 1355340 - Don't attempt to accumulate line scrolls for line scroll events. r=masayuki, a=ritu MozReview-Commit-ID: 6xvqJBVupYo
f076a30f6c291b7dfcda20a230ed910f373a3515: Bug 1056322 - Don't run DictionaryFetcher when spllchecker isn't initialized. r=masayuki, a=ritu
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 12 Apr 2017 17:43:51 +0900 - rev 355798
Push 7086 by ryanvm@gmail.com at Thu, 11 May 2017 20:15:10 +0000
Bug 1056322 - Don't run DictionaryFetcher when spllchecker isn't initialized. r=masayuki, a=ritu When CanSpellCheck isn't called yet, mSpellChecker won't be initialized. So we should check it before running DictionaryFetcher. I think that UpdateCurrentDictionary is called by OnFocus as long as nsEditorSpellCheck::InitSpellChecker isn't called. But I cannot find test case to reproduce this... MozReview-Commit-ID: 5H1pJ0AnX5X
a362e1205ba45ca4c96dca55d5e79914e168c7ea: Bug 1350683 - Ensure the transaction processing. r=masayuki, a=jcristau
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 29 Mar 2017 13:23:31 -0400 - rev 355520
Push 6990 by ryanvm@gmail.com at Thu, 30 Mar 2017 01:58:18 +0000
Bug 1350683 - Ensure the transaction processing. r=masayuki, a=jcristau
4ed20a0426ec15b0faad310be36573bdb8d8dd49: Bug 1314442 - Limit editor's editability to the right subtree. r=masayuki, a=ritu
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 29 Nov 2016 17:07:27 -0500 - rev 355087
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1314442 - Limit editor's editability to the right subtree. r=masayuki, a=ritu
4f4eabf6bdd03d548d73e1a4e5457c2f40ec86f0: Bug 1300140 - Return error when IME attribute array doesn't have valid. r=masayuki, a=ritu
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 14 Sep 2016 11:09:00 +0900 - rev 355058
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1300140 - Return error when IME attribute array doesn't have valid. r=masayuki, a=ritu MozReview-Commit-ID: 2paKhQNSR11
837febfe80a0c5b155fe8791ca01bad5c1cb467f: Bug 1300143 - Set length before accessing array even if array capacity has enougth size. r=masayuki, a=ritu
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 14 Sep 2016 11:07:19 +0900 - rev 355057
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1300143 - Set length before accessing array even if array capacity has enougth size. r=masayuki, a=ritu MozReview-Commit-ID: F5IoXBOnouc
6b931df9c6e1a003d9159d571cf8bd2ac4a668af: Bug 1194055 - GetSysFontInfo should return MS Shell Dlg 2 for eFont_Field and eFont_List on Windows. r=masayuki, a=sledru
Jonathan Kew <jkew@mozilla.com> - Fri, 21 Aug 2015 14:23:41 -0700 - rev 354605
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1194055 - GetSysFontInfo should return MS Shell Dlg 2 for eFont_Field and eFont_List on Windows. r=masayuki, a=sledru
db5e61ac282d94631be31bd6f5d2e85d75d289b5: Bug 1270235 - Part 2: Add test. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Feb 2017 15:46:15 +0900 - rev 354347
Push 6897 by ryanvm@gmail.com at Tue, 21 Feb 2017 21:41:19 +0000
Bug 1270235 - Part 2: Add test. r=masayuki, a=jcristau MozReview-Commit-ID: BV7Dc6YiNM6
e197e817582e5d9ad02ff8c4a51ae137ca4f8855: Bug 1270235 - Part 1: Check parent node is null in RemoveEmptyNodes. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Feb 2017 15:46:09 +0900 - rev 354346
Push 6897 by ryanvm@gmail.com at Tue, 21 Feb 2017 21:41:19 +0000
Bug 1270235 - Part 1: Check parent node is null in RemoveEmptyNodes. r=masayuki, a=jcristau RemoveEmptyNodes doesn't check whether parent node is null. So we shouldn't add null to skip list. Also, although this crash depends on clang, if debug build, it will hit the assertion on all compiler. MozReview-Commit-ID: GgiczVExlIn
4bd450fe3834f70552fa2f6988a0d239348d7192: Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki, a=jcristau
Mats Palmgren <mats@mozilla.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 354186
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki, a=jcristau
86dede1ab4b39caec45c6d64cba9b20e443c16fe: Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki, a=jcristau
Mats Palmgren <mats@mozilla.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 354125
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki, a=jcristau
47cff7384496e6c3cddee310676fa2baf1c8316b: Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:27:26 +0900 - rev 354002
Push 6857 by cbook@mozilla.com at Wed, 01 Feb 2017 15:29:20 +0000
Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau MozReview-Commit-ID: 6ZuluRWrYxb
6698c9784e3f42d6031d36c538aa5656f1ada99e: Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:25:43 +0900 - rev 354001
Push 6857 by cbook@mozilla.com at Wed, 01 Feb 2017 15:29:20 +0000
Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau Part 3 fix of bug 1310912 is incorrect for not composition transaction. PlaceholderTransation is for saving and restoring current selection for undo. So we shouldn't use range updater to normal transaction. Composition transaction can modify multiple nodes and it merges text node for ime into single text node. So if current selection is into IME text node, it might be failed to restore selection by UndoTransaction. So we need update selection by range updater to work UndoTransaction. Also, CompositionTransaction::UndoTransaction will set selection after committed text. So at finally, selection will set correct position that composition transaction wants. MozReview-Commit-ID: 1NcH32YoKPQ
f3b2cabb6ced8147ff9eb5b16b9be45356c959d3: Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau
Jim Chen <nchen@mozilla.com> - Mon, 23 Jan 2017 14:35:04 -0500 - rev 353998
Push 6857 by cbook@mozilla.com at Wed, 01 Feb 2017 15:29:20 +0000
Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau Bug 1319660 - 1. Don't take shortcut if old replacement ranges don't match; r=esawin The block at [1] is a shortcut we take when we reconcile Java text changes with Gecko text changes. However, we only checked that the new ranges are the same, i.e. that the new Gecko text is the same as the new Java text. We should also be checking that the old ranges are the same, i.e. that the replaced Gecko text is the same as the replaced Java text. [1] https://dxr.mozilla.org/mozilla-central/rev/bbbd2f7539f224a482cc6d2dd10e6a5f31c8baf3/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java#1233 Bug 1319660 - 2. Use previous node instead of sibling when adjusting last node; r=masayuki r=smaug nsContentIterator in pre mode adjusts its last node if the node is a childless node like <br>. However, right now it's using GetPrevSibling, which can lead to error in some edge cases such as: <p></p><div><br></div> In this case, if the last node is <br> with offset 0, GetPrevSibling will return <p> because <p> is <br>'s parent's previous sibling, and the last node will be set to <p>. However, the correct last node in this case is <div>, because <br> with offset 0 refers to the position to the left of <br>, which is <div> with offset 0. In this case, PrevNode returns the correct <div> value, so we should set the last node to the result of PrevNode. For the first node, for a childless node in pre mode, GetNextSibling and NextNode are the same, so there is no bug in this case. Nevertheless, this patch changes the call to NextNode to be consistent with calling PrevNode for the last node. Bug 1319660 - 3. Add test for correctly adjusting last node in content iterator; r=masayuki Add a test for the previous patch that makes sure querying selected text in an edge case works correctly. Bug 1319660 - 4. Add test for start node regression; r=me Add a new test case for the NextNode() regression. r=me for trivial test-only patch. Bug 1319660 - 5. Restore GetNextSibling call for first node of pre-content-iterator; r=smaug The last patch changed the `GetNextSibling()` call to `NextNode()` because I assumed they're equivalent in this case. That turned out to not be the case because we can reach this line even if the node has children -- the index just has to be after the last child. So this patch restores the `GetNextSibling` call to restore the correct behavior. I also added some comment to clarify that we can reach this line due to one of two conditions: 1) the node has no children; 2) the node has children but the index is after the last child. This patch also replaces the `HasChildren()` check when setting `cChild`. If the index is after the last child (i.e. index == childCount), `GetChildAt()` fails and we erroneously log an assertion warning, even though the input was valid. The new check handles all cases whether start node has children or not.
c0345ca8cb3bf10c4f69021d6c38c9b95a925625: Bug 1332876 - Bail out of HTMLEditRules::BeforeEdit if we have no Selection. r=masayuki a=jcristau
Mats Palmgren <mats@mozilla.com> - Mon, 30 Jan 2017 04:54:37 +0100 - rev 353963
Push 6846 by cbook@mozilla.com at Tue, 31 Jan 2017 15:39:52 +0000
Bug 1332876 - Bail out of HTMLEditRules::BeforeEdit if we have no Selection. r=masayuki a=jcristau
5aee8dff330f19c9a27b0114371d2c09b2a65d93: Bug 1317704 - Part 2. Add test. r=masayuki a=test-only
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 15 Dec 2016 15:02:10 +0900 - rev 353927
Push 6839 by cbook@mozilla.com at Mon, 30 Jan 2017 14:41:09 +0000
Bug 1317704 - Part 2. Add test. r=masayuki a=test-only MozReview-Commit-ID: AVOvEZ1sMVq
2332cedca400d8ed64580d90222c74f0d482d90e: Bug 1317704 - Part 1. Hold current ranges into RemoveInlineProperty. r=masayuki a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 15 Dec 2016 15:01:53 +0900 - rev 353926
Push 6839 by cbook@mozilla.com at Mon, 30 Jan 2017 14:41:09 +0000
Bug 1317704 - Part 1. Hold current ranges into RemoveInlineProperty. r=masayuki a=jcristau Since current selection ranges might be modified by SplitStyleAboveRange, this crash occurs into RemoveInlinePropertyImpl. So we need hold current selection range for loop. MozReview-Commit-ID: JuXn9XlwCp6
fd66a1e49411faca500b26ba9ca7dd5a311ff6e5: Bug 1330796 - Follow-up: Add key code to KEY_Enter. r=masayuki, a=test-only
Jorg K <jorgk@jorgk.com> - Tue, 17 Jan 2017 10:40:00 -0500 - rev 353648
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1330796 - Follow-up: Add key code to KEY_Enter. r=masayuki, a=test-only
dcb1213212c1c75c0530b70162553619c45b7800: Bug 1330796 - Add invisible break to span of display:block in HTMLEditRules::SplitMailCites. r=masayuki, a=jcristau
Jorg K <jorgk@jorgk.com> - Mon, 16 Jan 2017 01:40:00 -0500 - rev 353647
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1330796 - Add invisible break to span of display:block in HTMLEditRules::SplitMailCites. r=masayuki, a=jcristau
55b4f54b20c6ca9cbe5fbdb5189ff2381b5486f6: Bug 1328093 - HTMLEditor::InsertTextWithQuotations() should include the first line break into the <span> it creates. r=masayuki a=jcristau
Jorg K <jorgk@jorgk.com> - Tue, 10 Jan 2017 01:50:00 -0500 - rev 353538
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1328093 - HTMLEditor::InsertTextWithQuotations() should include the first line break into the <span> it creates. r=masayuki a=jcristau
6f0be357dd95d0180e500fffa87ac88230f556ae: Bug 1322666 - Change MAXWORDLEN to 100, matching the previous default from Hunspell 1.3. r=masayuki a=jcristau a=gchang
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 14 Dec 2016 17:45:00 +0100 - rev 353052
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1322666 - Change MAXWORDLEN to 100, matching the previous default from Hunspell 1.3. r=masayuki a=jcristau a=gchang
3143352cb282da14f176d6895671ff177a1e978e: Bug 1288911 - Use CSS trick to avoid unwanted line wraps in quotes. r=masayuki a=jcristau
Jorg K <jorgk@jorgk.com> - Wed, 14 Dec 2016 13:37:00 +0100 - rev 353042
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1288911 - Use CSS trick to avoid unwanted line wraps in quotes. r=masayuki a=jcristau
ee5a46acf5cec8b56d348c3b4605f309e7846f79: Bug 1273091 - Mouse cursor does not disappear in html5 fullscreen video on Windows. r=masayuki a=jcristau a=gchang
David Parks <dparks@mozilla.com> - Mon, 28 Nov 2016 10:46:15 -0800 - rev 352942
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1273091 - Mouse cursor does not disappear in html5 fullscreen video on Windows. r=masayuki a=jcristau a=gchang When we jump to fullscreen, the OS sends a WM_MOUSELEAVE, which we turn into a eMouseExitFromWidget. The eMouseEnterIntoWidget was previously only sent when the mouse moved into the widget, which required the mouse to move. When entering fullscreen, we want the eMouseEnterIntoWidget to happen right away.
6ae1e6a5259fd2159192811e65ec9157a0247474: Bug 1314442 - Limit editor's editability to the right subtree. r=masayuki, a=ritu
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 29 Nov 2016 17:07:27 -0500 - rev 352782
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1314442 - Limit editor's editability to the right subtree. r=masayuki, a=ritu
12a7e9d627b5ef91b8c1a9061012cd48ae1a6df0: Bug 1314790 - Part 3. Ignore nsIEditor::eNone case. r=masayuki a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sun, 20 Nov 2016 10:35:17 +0900 - rev 352648
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1314790 - Part 3. Ignore nsIEditor::eNone case. r=masayuki a=gchang MozReview-Commit-ID: 6KHFQ84J7dU
7b4599e0220c20eb60f3431916b89cb874d65990: Bug 1314790 - Part 2. Add test. r=masayuki, a=test-only
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sat, 12 Nov 2016 21:59:49 +0900 - rev 352647
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1314790 - Part 2. Add test. r=masayuki, a=test-only MozReview-Commit-ID: HcauemPpe4r
86def315a57917729644cd22f6c78e900145e49a: Bug 1314790 - Part 1. GetGoodSelPointForNode doesn't work with ePrevousWord action. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sat, 12 Nov 2016 21:59:04 +0900 - rev 352646
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1314790 - Part 1. GetGoodSelPointForNode doesn't work with ePrevousWord action. r=masayuki, a=gchang Although GetGoodSelPointForNode only supports ePrevious or eNext as action, we use other action. So we should add aseetion for it. MozReview-Commit-ID: 3gLFFTAdNxU
bac6adefd6a2e423ced72b735471cb6bae7ee741: Bug 1310912 - Part 6. Add redo test. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 10 Nov 2016 21:17:34 +0900 - rev 352372
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1310912 - Part 6. Add redo test. r=masayuki MozReview-Commit-ID: 5TgGAq3tM01
856c6ccb09a1295222fbd62b67d03a85c76a5f98: Bug 1310912 - Part 5. InsertTextIntoTextNodeImpl should use IMETextNode for listener. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sat, 12 Nov 2016 15:46:33 +0900 - rev 352371
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1310912 - Part 5. InsertTextIntoTextNodeImpl should use IMETextNode for listener. r=masayuki When using CompositionTransaction, text node will be inserted into IMETextNode, not aTextNode of parameter. So we should use it for listener. MozReview-Commit-ID: 72a3ZjF1wsz
62a4cc7525bce189c40d69b630c79f1e3dce92a3: Bug 1310912 - Part 4. RangeUpdater should be called on DoTransaction. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sat, 12 Nov 2016 14:56:33 +0900 - rev 352370
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1310912 - Part 4. RangeUpdater should be called on DoTransaction. r=masayuki Although PlaceholderTransaction will use the selection on Merge, it is too late to use UpdateRange. Because RangeUpdater will be used after DoTransaction is finished. So we should update selection on DoTransaction. Also, part 1 fix doesn't update selection correctly via RangeUpdater when IME composition is multiple node. MozReview-Commit-ID: 9so9tR8uQ6t
6e763c7787816780d2be2100310ca6eea5e4fdbf: Bug 1310912 - Part 3. The selection into PlaceholderTransaction should be updated via RangeUpdater. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 10 Nov 2016 21:10:50 +0900 - rev 352369
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1310912 - Part 3. The selection into PlaceholderTransaction should be updated via RangeUpdater. r=masayuki Since the selection into PlaceholderTransaction isn't updated via RangeUpdater, UndoTransaction may return error when selection/caret position is changed. Then, redo is failed. So we should add selection into PlaceholderTrancation to RangeUpdater. MozReview-Commit-ID: LcUIiUExNhx
94211fba111d93dcab69527cc729f9932c7ee162: Bug 1310912 - Part 2. Add test. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 04 Nov 2016 19:04:43 +0900 - rev 352368
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1310912 - Part 2. Add test. r=masayuki We need skip this test on Android. Although mochitest doesn't use native IME data, Android's GeckoEditable.java wants to access native IME composition. See bug 1315898. MozReview-Commit-ID: BNCKmDEmwKw
f0e042371dfe823300562e92254fb473fae518cf: Bug 1310912 - Part 1. CompositionTransaction should support multiple text nodes. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 08 Nov 2016 16:14:57 +0900 - rev 352367
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1310912 - Part 1. CompositionTransaction should support multiple text nodes. r=masayuki Google Keep uses range.insertNode on input event. So, text node will be inserted into current caret position. Microsoft IME's caret is after composition string, but ATOK's caret is before it. So when using ATOK, this issue occurs. By range.insertNode, text nodes that have IME attribute becomes multiple text nodes. But CompositionTransanction doesn't consider that IME range isn't single text node. Although it replaces current composition string with new string on first text node, it doesn't delete composition string on other text node. MozReview-Commit-ID: 9uRx0A9mppx
c17531742f635bcb7bac22ba9e80c23afd7d49b5: Bug 1315986 - Update line-break class mapping in nsJISx4051LineBreaker to handle new classes in ICU58/Unicode 9, and add assertions to detect any future additions that will require further updates. r=masayuki
Jonathan Kew <jkew@mozilla.com> - Wed, 09 Nov 2016 15:07:54 +0000 - rev 351950
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1315986 - Update line-break class mapping in nsJISx4051LineBreaker to handle new classes in ICU58/Unicode 9, and add assertions to detect any future additions that will require further updates. r=masayuki
53516fd74efbc2ed9e124eb4bd6345b878d77eca: Bug 1271125 part 2 - Port editor mochitests that depend on ChromeUtils.js to mochitest-plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Mon, 31 Oct 2016 18:38:04 +0200 - rev 350644
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271125 part 2 - Port editor mochitests that depend on ChromeUtils.js to mochitest-plain; r=masayuki The change from ok() to is() in tests is so that the failure message is more informative -- it now tells you the returned exception. This commit omits test_contenteditable_text_input_handling.html because of test failures that I haven't figured out. MozReview-Commit-ID: 37cYlQlJZm7
6357eaf453b016145325e59c4d1737d17b5d04e5: Bug 1271120 - Port test_bug1219928.html from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Thu, 01 Sep 2016 17:15:28 +0300 - rev 350642
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271120 - Port test_bug1219928.html from chrome to plain; r=masayuki This test still doesn't work in e10s, though. mrbkap says further debugging is needed (bug 1269209 comment 3). MozReview-Commit-ID: 3iHNkQVYQMn
bed54475d25b89e07960ae6373bd198ca3474b9e: Bug 1271120 - Port test_bug1209414.html from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Tue, 23 Aug 2016 15:56:23 +0300 - rev 350641
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271120 - Port test_bug1209414.html from chrome to plain; r=masayuki MozReview-Commit-ID: ExX9ZNsVaXq
c8ff4e1962fbdcb265f36458cd7a82e886971012: Bug 1271120 - Port test_bug636465.xul from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Thu, 01 Sep 2016 17:30:57 +0300 - rev 350640
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271120 - Port test_bug636465.xul from chrome to plain; r=masayuki MozReview-Commit-ID: B0oaEGGEEvd
fe1a0812871c3e44645180330534a4292a56ebae: Bug 1271120 - Port test_bug569988.html from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Tue, 23 Aug 2016 15:56:48 +0300 - rev 350639
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271120 - Port test_bug569988.html from chrome to plain; r=masayuki MozReview-Commit-ID: EwpjCJf5MFX
1334f6bb2ea03f9449dbc2319e1add4a9f972cd5: Bug 1271120 - Port test_composition_event_created_in_chrome.html from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Tue, 23 Aug 2016 16:01:28 +0300 - rev 350638
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271120 - Port test_composition_event_created_in_chrome.html from chrome to plain; r=masayuki MozReview-Commit-ID: 5K2qv7JXAT4
e688081176ae94c102b4213516a7f43cbd9455bf: Bug 1271119 - Port test_bug1248185.html from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Mon, 31 Oct 2016 18:27:10 +0200 - rev 350637
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271119 - Port test_bug1248185.html from chrome to plain; r=masayuki MozReview-Commit-ID: Jn8Ga8dw4WD
8f480c1204e88df4803250112ed4736c65c734ee: Bug 1271119 - Port test_bug1248128.html from chrome to plain; r=masayuki
Aryeh Gregor <ayg@aryeh.name> - Mon, 31 Oct 2016 18:26:31 +0200 - rev 350636
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1271119 - Port test_bug1248128.html from chrome to plain; r=masayuki I added an extra check to ensure that the test wasn't passing because doCommand() was throwing some unrelated exception, in case porting from chrome to plain changed behavior of doCommand(). MozReview-Commit-ID: LOo8yN8jkZo