searching for reviewer(liuche)
2d23fe5dc5e2c6f72c005403d36738e0ff4895b4: Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases on a CLOSED TREE. r=billm,chutten,liuche, a=lizzard
Mike Conley <mconley@mozilla.com> - Wed, 07 Sep 2016 13:22:12 -0400 - rev 354962
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases on a CLOSED TREE. r=billm,chutten,liuche, a=lizzard MozReview-Commit-ID: 2XzfXDqoB
cb81505286e1351e2665a8ccaa08c222bc38423b: Bug 1264869 - Request STORAGE permission before downloading images on a CLOSED TREE. r=liuche, a=lizzard
Sebastian Kaspari <s.kaspari@gmail.com> - Fri, 15 Apr 2016 10:22:22 +0200 - rev 354839
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1264869 - Request STORAGE permission before downloading images on a CLOSED TREE. r=liuche, a=lizzard MozReview-Commit-ID: KJGugrRw5iI
71ddd5bf19ecea894ab97d175b12add5cf00c68d: Bug 1313686 - Add opt-out Telemetry probe to see how long it takes for TabChild::RecvSetDocShellIsActive to paint a tab. data-review=liuche, r=billm,liuche
Mike Conley <mconley@mozilla.com> - Fri, 28 Oct 2016 11:48:24 -0400 - rev 350788
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313686 - Add opt-out Telemetry probe to see how long it takes for TabChild::RecvSetDocShellIsActive to paint a tab. data-review=liuche, r=billm,liuche MozReview-Commit-ID: 5B588cs3cJ8
f7a6d2efbf88d12a09b615139b6318e2a9789a0e: Bug 1308946 - Part 1 - Ensure that empty views not matching the current panel level are hidden. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 11 Oct 2016 21:00:36 +0200 - rev 347821
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1308946 - Part 1 - Ensure that empty views not matching the current panel level are hidden. r=liuche Setting an empty view's visibility only for the view corresponding to the current PanelLevel was intended to make sure the empty view doesn't get hidden because of an unrelated status update - e.g. to prevent the history empty view hiding itself because the recent tabs count changes. This approach however doesn't work for switching between panel levels (the user moving into and out of the sync/recent tabs folders) - in that case we always need to turn off the empty view of the previous panel level, which is not possible with the above approach. So instead, we revert to always updating the visibility of the empty views, but at the same time initialise the desired state of current PanelLevel's empty view with its current visibility instead of simply defaulting to false. MozReview-Commit-ID: 6Xsnuo29srk
2d84870484441cd38ae1decf651fd709ed32f5b6: Bug 1308946 - Part 0 - Import PanelLevel enum. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 11 Oct 2016 20:41:47 +0200 - rev 347820
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1308946 - Part 0 - Import PanelLevel enum. r=liuche MozReview-Commit-ID: 32Qvym2Neh1
12e5c5d18fb31201b359a5772b4c7617727f7736: Bug 1313686 - Add opt-out Telemetry probe to see how long it takes for TabChild::RecvSetDocShellIsActive to paint a tab. data-review=liuche, r=billm,liuche a=ritu
Mike Conley <mconley@mozilla.com> - Fri, 28 Oct 2016 11:48:24 -0400 - rev 343660
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1313686 - Add opt-out Telemetry probe to see how long it takes for TabChild::RecvSetDocShellIsActive to paint a tab. data-review=liuche, r=billm,liuche a=ritu MozReview-Commit-ID: 5B588cs3cJ8
31471e296123b59d27df63649984b801d9e4b2fd: Bug 1277978 - Part 5 - Once we can access the panelStateChangeListener, use it to retrieve the cached tabs count when initialising the HistoryAdapter. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 29 Aug 2016 20:51:21 +0200 - rev 341967
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 5 - Once we can access the panelStateChangeListener, use it to retrieve the cached tabs count when initialising the HistoryAdapter. r=liuche While passing the cached tabs count to the HistoryAdapter in its constructor greatly simplifies getting the cached count into the adapter before the RecyclerView initialises, this relies on the History panel having the panelStateChangeListener available before the HistoryAdapter is created in onCreate(). MozReview-Commit-ID: 64IbAe6SaEq
11658ac8e339ee16684a8742f5240d97a8240efe: Bug 1277978 - Part 4 - Actually cache the recent tabs count when it updates. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 10 Sep 2016 13:51:35 +0200 - rev 341966
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 4 - Actually cache the recent tabs count when it updates. r=liuche MozReview-Commit-ID: JUsM3qdxhIr
434dfdb24918e4c2784b7308a3d0e0526d072b76: Bug 1277978 - Part 3 - Allow the RecentTabsAdapter to indicate whether the tab count is reliable. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 20 Aug 2016 17:49:34 +0200 - rev 341965
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 3 - Allow the RecentTabsAdapter to indicate whether the tab count is reliable. r=liuche After we've set the cached tabs count to display within the history adapter, we don't want to revise that number downwards as long as the RecentTabsAdapter hasn't yet checked all of its data sources. MozReview-Commit-ID: BMpiaEb3kGQ
1ab243749c5ee87ab0683523c01de1728dfd7019: Bug 1277978 - Part 2 - Allow saving a cached recent tabs count in BrowserApp. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 29 Aug 2016 20:03:12 +0200 - rev 341964
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 2 - Allow saving a cached recent tabs count in BrowserApp. r=liuche Getting the total number of recently closed tabs involves waiting for Gecko to actually send the closed tabs to the Java UI. This means that (unless there are some "Tabs from last time" present) when showing the history panel we always start out with the Recently closed folder hidden and then unhide (and animate) it once we've finally received the closed tabs. Because this is visually distracting, we should cache the closed tabs count somewhere, so we can decide on the smart folder visibility as soon as the CombinedHistoryAdapter initialises. MozReview-Commit-ID: 8uYCbM7eiSt
a93820dea9baa82506443c2a649022128e9ddc34: Bug 1277978 - Part 1 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche,rnewman
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 04 Sep 2016 15:16:20 +0200 - rev 341963
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 1 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche,rnewman This involves making the number of visible smart folders dynamic, so the history adapter can properly display its contents. MozReview-Commit-ID: 6b4V6IHB7BE
2329e646600993d7603ede43851faaf8ea8c8da0: Bug 1277978 - Part 0b - Add target api annotation in BrowserApp. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 20 Aug 2016 16:59:59 +0200 - rev 341962
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 0b - Add target api annotation in BrowserApp. r=liuche Otherwise Android Studio complains because it doesn't recognise our version switch. MozReview-Commit-ID: 2QpD3nNSryK
c5c0de78a445cdd0875b723ed8849b9d087c3407: Bug 1277978 - Part 0a - Fix typo. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 16 Aug 2016 20:42:20 +0200 - rev 341961
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277978 - Part 0a - Fix typo. r=liuche MozReview-Commit-ID: 50wzRmX7iTz
cf134ae84918e0a139fd8bac471791c66c1eb3d4: Bug 1298500 - Don't explicitly set the startpane pref. r=liuche
Michael Kaply <mozilla@kaply.com> - Thu, 08 Sep 2016 14:49:19 -0500 - rev 341865
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1298500 - Don't explicitly set the startpane pref. r=liuche
c8096f896f7cf570dd77b503861650847337febc: Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases. r=billm,chutten,liuche
Mike Conley <mconley@mozilla.com> - Wed, 07 Sep 2016 13:22:12 -0400 - rev 341605
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases. r=billm,chutten,liuche MozReview-Commit-ID: 2XzfXDqoB
6a563348b8be866a9c0a3ac18c323b151a73d18f: Bug 1266836 - Part 1 - Fix password manager handling of popup windows in e10s. r=MattN r=liuche
Johann Hofmann <jhofmann@mozilla.com> - Tue, 30 Aug 2016 15:47:38 +0200 - rev 340701
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1266836 - Part 1 - Fix password manager handling of popup windows in e10s. r=MattN r=liuche MozReview-Commit-ID: OVsgkHhyg9
e0e98ba78d86c127ccf1008c3b1021540478237b: Bug 1281220 - Remove about:accounts telemetry on Fennec. r=liuche
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 16:25:19 +0200 - rev 340328
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1281220 - Remove about:accounts telemetry on Fennec. r=liuche MozReview-Commit-ID: GTKaauQIDKo
3d534ebc1ac3151aa0dacc9d76247cc96bc07370: Bug 1297905 - Remove usage of getAllDisabledHosts in sanitize implementations. r=liuche,markh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 24 Aug 2016 17:41:10 -0700 - rev 339783
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1297905 - Remove usage of getAllDisabledHosts in sanitize implementations. r=liuche,markh Bug 1058438 moved disabled hosts to the permission manager which are already cleared by these modules. MozReview-Commit-ID: InprrYLvjMR
eb0c3d8a6d53e5ca5138001e454b06e2dcabe98e: Bug 1281220 - Remove about:accounts telemetry on Fennec. r=liuche
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 16:25:19 +0200 - rev 339610
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1281220 - Remove about:accounts telemetry on Fennec. r=liuche MozReview-Commit-ID: GTKaauQIDKo
ccd9edf8d3847e9d3dc7836451ba9a8038fc4771: Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram. r=liuche
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 15:38:59 +0200 - rev 339382
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram. r=liuche MozReview-Commit-ID: CvSLLCAACZv
b9a2275439794bd0b406c054530ccf19a63af901: Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0. r=liuche
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 15:37:46 +0200 - rev 339381
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0. r=liuche MozReview-Commit-ID: 8ymVQAm51VB
e336054c4c852458dc7a4b28e333212343f2bb61: Bug 1293002 - Replace in-tree consumer of non-standard Iterator() with Object.{values,entries} in mobile/. r=liuche
Tuhina <tuhinatwyla@gmail.com> - Wed, 10 Aug 2016 02:01:20 +0530 - rev 337989
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1293002 - Replace in-tree consumer of non-standard Iterator() with Object.{values,entries} in mobile/. r=liuche
5d16433ff39ebc0ac79ec07083e4a8a30973fe47: Bug 1277800 - Part 2 - Clear the RecentTabsAdapter's "Tabs from last time" by listening to "Sanitize:Finished". r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 09 Jun 2016 20:08:26 +0200 - rev 337584
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277800 - Part 2 - Clear the RecentTabsAdapter's "Tabs from last time" by listening to "Sanitize:Finished". r=liuche The "Tabs from last time" section of the "Recently closed" folder is only read from sessionstore.bak when the adapter is created and subsequently never updated. To prevent those tabs from lingering around after clearing history, the history panel initially directly called the RecentTabsAdapter. To handle this in a more generic manner, we now have the RecentTabsAdapter listen for "Sanitize:Finished" notifications instead. MozReview-Commit-ID: AADXHd5iDo2
d4d2e1b77615dcb0d484893077b421360f0b377b: Bug 1277800 - Part 1 - Convert GeckoPreferences's "Sanitize:Finished" listener to a NativeEventListener. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 29 Jul 2016 20:50:06 +0200 - rev 337583
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1277800 - Part 1 - Convert GeckoPreferences's "Sanitize:Finished" listener to a NativeEventListener. r=liuche We can't register both GeckoEventListeners and NativeEventListeners for the same event - since GeckoEventListeners are deprecated anyway, we should simply convert GeckoPreferences's "Sanitize:Finished" listener to a NativeEventListener, so as not to cause conflicts with the RecentTabsAdapter. MozReview-Commit-ID: Dh3iXPQIJPC
c641ec05e581be364beed66102bdc886e1632f1a: Bug 1291060 - Android: When a password field is added to a document (possibly outside of a <form>) the autofill code should run. r=liuche
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 02 Aug 2016 14:20:35 -0700 - rev 336525
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1291060 - Android: When a password field is added to a document (possibly outside of a <form>) the autofill code should run. r=liuche Android version of bug 1168707 MozReview-Commit-ID: 4OZ8Jp9aVgN
c580c468fdb4a396bde95c2d2b69d2302e88d3ba: Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases. r=billm,chutten,liuche, a=lizzard
Mike Conley <mconley@mozilla.com> - Wed, 07 Sep 2016 13:22:12 -0400 - rev 335322
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases. r=billm,chutten,liuche, a=lizzard MozReview-Commit-ID: 2XzfXDqoB
27b3a5123d75480bf02b77120425ef94c83ab022: Bug 1281220 - Remove about:accounts telemetry on Fennec. r=liuche, a=ritu
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 16:25:19 +0200 - rev 335241
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1281220 - Remove about:accounts telemetry on Fennec. r=liuche, a=ritu MozReview-Commit-ID: GTKaauQIDKo
1536a4c14d4e6741d5b06fd32f92bb7ee59f601f: Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram. r=liuche, a=ritu
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 15:38:59 +0200 - rev 335136
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1287387 - Remove FENNEC_RESTRICTED_PROFILE_RESTRICTIONS histogram. r=liuche, a=ritu MozReview-Commit-ID: CvSLLCAACZv
6e4a66c6dfd39f4953a84d9c85539e209e53875d: Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0. r=liuche, a=ritu
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 23 Aug 2016 15:37:46 +0200 - rev 335135
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1287387 - Set histograms FENNEC_CUSTOM_HOMEPAGE, FENNEC_LOAD_SAVED_PAGE, ZOOMED_VIEW_ENABLED to expire in Firefox 60.0. r=liuche, a=ritu MozReview-Commit-ID: 8ymVQAm51VB
6a77bd1526331c3a09675d9950103c46a9ca5135: Bug 1221646 - Report getInstallerPackageName() in telemetry. r=ahunt,liuche
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 20 Jul 2016 11:58:35 +0200 - rev 333573
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1221646 - Report getInstallerPackageName() in telemetry. r=ahunt,liuche MozReview-Commit-ID: EiPNDsVam0x
d70bb3bdb5cc14df566cc1ed2c12f38e184a2f54: Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry r=liuche
Andrzej Hunt <ahunt@mozilla.com> - Tue, 05 Jul 2016 15:29:55 -0700 - rev 332765
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry r=liuche We want to be able to detect when we've opened a reader view item. Note: this is independent of whether or not we're in the Reading List smartfolder: it's possible to open reader view bookmarks from any real bookmark folder, or the smartfolder. MozReview-Commit-ID: KhqclodWSji
23bdc280b66e339a0fe8d5c2e9bfdfc601b01d54: Bug 1253654 - Part 2 - Don't show the item divider in the history panel after a section header. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 14 Jul 2016 20:57:43 +0200 - rev 332586
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1253654 - Part 2 - Don't show the item divider in the history panel after a section header. r=liuche That way, the section headers (e.g. "Today", "Yesterday", "Last 7 days" etc.) blend better with the following item. The correct hiding of the divider depends on the view type reported for the respective RecylerView child items. Because the view type is stored a simple number, this means that any other RecylerView wanting to use this divider decoration implementation must use the same item types as the history panel in order to remain compatible, otherwise the divider could be unexpectedly hidden. Therefore, we rename the DividerItemDecoration to underline its intended usage scope. MozReview-Commit-ID: 8JUS6ke3RBL
1557fb4540f2bfa0f167c284318002e2b38f0332: Bug 1253654 - Part 1 - Update home panels section header styling. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Jul 2016 15:38:23 +0200 - rev 332585
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1253654 - Part 1 - Update home panels section header styling. r=liuche MozReview-Commit-ID: EflkRCg0Xby
e8d3a286f70ed10ad64ca62287115e55fe26c674: Bug 1278725 - Restore original "up" arrow scaling r=liuche
Andrzej Hunt <ahunt@mozilla.com> - Thu, 09 Jun 2016 10:32:24 -0700 - rev 328731
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1278725 - Restore original "up" arrow scaling r=liuche Before introducing the folder count, the bookmark folder icon was set as the drawable on a TextView. This actually resulted in scaling that doesn't preserve the aspect ratio. To reproduce this in the new ImageView (added when we switched to a two-line folder layout), we simply need to set the icon size explicitly and scale to fit the whole area (as opposed to setting two constraints and fitting while preserving aspect ratio). The folder/reading-list icons are unaffected as they already have the expected aspect-ratio, the back-arrow is now scaled as expected. MozReview-Commit-ID: Fl5JY3Lznau
f87d1fde25f3a222d3c8ae9087ddd3141348e354: Bug 1251362 - Part 19 - Remove code and resources for the old Recent Tabs panel. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 26 May 2016 17:40:19 +0200 - rev 328407
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 19 - Remove code and resources for the old Recent Tabs panel. r=liuche MozReview-Commit-ID: FQJ7j8YlV6E
4509c776bcaaf9b6aa4ec15602e26a201fc1539c: Bug 1251362 - Part 18 - Migrate (customised) home panel configurations. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 21 May 2016 14:39:15 +0200 - rev 328406
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 18 - Migrate (customised) home panel configurations. r=liuche For people with customised home panels, we need to explicitly remove the Recent Tabs panel. We also unhide the Combined History panel if it was previously hidden and additionally turn it into the default panel if the Recent Tabs panel was the previous default panel. MozReview-Commit-ID: 5CSJUTRysQU
22f8e6c629ea0cee57c186c4280bf8771e09670f: Bug 1251362 - Part 17 - Turn reading list panel migration function into a generic panel removal function. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 21 May 2016 18:27:55 +0200 - rev 328405
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 17 - Turn reading list panel migration function into a generic panel removal function. r=liuche By passing the panel types to be removed/set as new default panel as arguments instead of hard coding them, we can reuse that function for our own home panel config migration. MozReview-Commit-ID: BsMxcbInRbX
2ded136fbae5d92668e02f84a36a6005381e3e46: Bug 1251362 - Part 16 - Remove the Recent Tabs panel from the default home panel config. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 02:22:03 +0200 - rev 328404
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 16 - Remove the Recent Tabs panel from the default home panel config. r=liuche MozReview-Commit-ID: IX6AkBoa3Mg
e2b22babd7b3b15e21e9e325bff5ef386611adc7: Bug 1251362 - Part 15 - Redirect direct loads of the Recent Tabs panel about:home URL to the Recent Tabs folder of the Combined History panel. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 26 May 2016 23:04:53 +0200 - rev 328403
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 15 - Redirect direct loads of the Recent Tabs panel about:home URL to the Recent Tabs folder of the Combined History panel. r=liuche After detecting multiple successive crashes in a row, we temporarily switch off automatic session restoring and display the Recent Tabs panel instead. As that panel is going to be removed, we intercept loads of the Recent Tabs panel about:home?panel=... URL and redirect them to the Combined History panel. We also use the facilities provided by bug 1060544 to jump directly to the Recent Tabs folder in that case. MozReview-Commit-ID: 7dQ7tW2dD1M
1060ef1606c577ac10f6686aba08925d79847cfe: Bug 1251362 - Part 14 - Add telemetry for restoring tabs. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 19:04:49 +0200 - rev 328402
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 14 - Add telemetry for restoring tabs. r=liuche This adds telemetry for clicking on a closed tab or the "Open all" button. Methods and extras strings are based on those used for the old Recent Tabs panel. MozReview-Commit-ID: 1Kc8fACkmIc
85eee022eb7d957112571226dbe89882a5799852: Bug 1251362 - Part 13 - Only enable swipe to refresh within the Synced devices smart folder. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 23:38:29 +0200 - rev 328401
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 13 - Only enable swipe to refresh within the Synced devices smart folder. r=liuche Recently closed tabs aren't synced, therefore being able to swipe to refresh within the Recent tabs folder isn't necessary. To avoid triggering a refresh by accident, we restrict swipe to refresh to the Synced devices folder itself. MozReview-Commit-ID: YwekSwQr2q
a284a1caa422a4f65755e8223e0e9e64f3e5c4fb: Bug 1251362 - Part 12 - Remember more recently closed tabs. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 26 May 2016 13:46:00 +0200 - rev 328400
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 12 - Remember more recently closed tabs. r=liuche MozReview-Commit-ID: 37mYEiJKfTz
7c334cfa74a08d1a1a0219835af6e54007d65b20: Bug 1251362 - Part 11 - Directly notify the RecentTabsAdapter when clearing history. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 21:27:23 +0200 - rev 328399
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 11 - Directly notify the RecentTabsAdapter when clearing history. r=liuche Sessionstore.bak is only read when we are initialising the home panels, so after clearing all history from the button in the Combined History panel, the "Tabs from last time" section would still linger around until the home panels have been closed and reopened. To prevent this, we now directly notify the RecentTabsAdapter when all history has been deleted, so it can immediately clear its own copy of the last session's tabs. MozReview-Commit-ID: 3EFY2WbWqzh
ab0c1b005ffe6f628e1d4170e19ff02fa255ba1a: Bug 1251362 - Part 10 - Display a context menu for closed tab entries. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 19:42:00 +0200 - rev 328398
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 10 - Display a context menu for closed tab entries. r=liuche MozReview-Commit-ID: Gv2tJoNRldX
8c7176aa08d7e4baa4f7848a2e0731d893f8d66c: Bug 1251362 - Part 9 - Display a button to open all recently closed tabs. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 26 May 2016 16:36:25 +0200 - rev 328397
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 9 - Display a button to open all recently closed tabs. r=liuche Depending on the History panel's PanelLevel state, we now dynamically set the panel footer button's text and determine its onClick behaviour. MozReview-Commit-ID: EjesnHsntyC
1e50a28316e7321897b9c4545049eba887192592: Bug 1251362 - Part 8 - Handle Recent Tabs in onItemClicked(). r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 18:55:32 +0200 - rev 328396
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 8 - Handle Recent Tabs in onItemClicked(). r=liuche Clicking a tab in the list of recently closed tabs now sends the appropriate message back to the session store. MozReview-Commit-ID: KF3UJjq5zQK
26b34894a22e724ba180143f41cfed5c825ead78: Bug 1251362 - Part 7 - Update closed tabs count in the History panel main view. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 20:35:07 +0200 - rev 328395
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 7 - Update closed tabs count in the History panel main view. r=liuche We need to update the recent tabs count displayed by the smart folder as necessary. To do this, we copy the approach used for updating the synced devices count. MozReview-Commit-ID: BFwv5bY1DWk
6d3b17555d95b47def48b5186fed8d883b5825ec: Bug 1251362 - Part 6 - Update empty panel state when recent tabs count changes. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 01:41:45 +0200 - rev 328394
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 6 - Update empty panel state when recent tabs count changes. r=liuche The recent tabs count might change while the Recent Tabs folder is open, e.g. immediately after startup, once we receive the first "ClosedTabs:Data" message from the session store. Therefore, we need to hide/unhide the empty view as necessary, which is normally handled by the Combined History panel's updateEmptyView() function. Since we aren't using a cursor, we can't hinge calling that on the CursorLoader's onLoadFinished() callback, so instead, we include our own callback to the Combined History panel, modelled after the DeviceUpdateHandler used for updating the count of synced devices. MozReview-Commit-ID: GLHM9LoWk2h
9ccad5daa84c0d76e2712f137c9f33e48d97ea81: Bug 1251362 - Part 5 - Actually show recently closed tabs when opening the smart folder. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 02 Jun 2016 18:08:23 +0200 - rev 328393
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 5 - Actually show recently closed tabs when opening the smart folder. r=liuche This fills the new smart folder we've previously added with life and displays the recently closed tabs as we receive them from the session store. If we can find a sessionstore.bak file (previously the "Tabs from last time"), we also add those tabs to the bottom of the list. Most of the code for communicating with the session store and reading sessionstore.bak is adapted from the original Recent Tabs panel, however unlike the previous implementation, I've opted for a cursor-less approach of storing and retrieving the recent tabs data, since the recent tabs data isn't actually powered by a database anyway. Instead, the RecentTabsAdapter maintains two arrays for storing "Recently closed tabs" (as received through messages from the Gecko session store) and "Tabs from last time" (as read from sessionstore.bak during panel initialisation). Also, as per the other Combined History panel adapters and because we're now using a RecyclerView instead of a ListView, list item types are now determined on demand through getItemTypeForPosition() instead of precalculating them during a data update and directly storing together with the tab data items in a cursor. MozReview-Commit-ID: IpoUr9f0JBP
0c997d2226360c808a63777f0e0b1bd6f21fd5a8: Bug 1251362 - Part 4 - Add a Recent Tabs folder to the Combined History panel. r=liuche
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 13 May 2016 23:52:24 +0200 - rev 328392
Push 6389 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:38:22 +0000
Bug 1251362 - Part 4 - Add a Recent Tabs folder to the Combined History panel. r=liuche This folder can be opened and closed to get back to the history view, however it doesn't contain any actual content (closed tabs) yet. Its empty view is based on the original empty view of the Recent Tabs panel. For displaying the recently closed tabs count within the smart folder similarly to how we display the number of synced devices, two new strings need to be added. MozReview-Commit-ID: IAL0yDrc2Ld