searching for reviewer(froydnj)
330002a1e73dc238250a676c071a0a7117996e6b: Bug 1496588: Avoid a UB in mozStorageService.cpp. r=froydnj, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
David Major <dmajor@mozilla.com> - Fri, 05 Oct 2018 16:23:40 -0400 - rev 357552
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1496588: Avoid a UB in mozStorageService.cpp. r=froydnj, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
fade2a70ad157186a7fdc858c8f7910bc71ef688: Bug 1485224 - Make best efforts to write a stack frame atomically. r=froydnj, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 13 Sep 2018 19:22:18 +0900 - rev 357546
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1485224 - Make best efforts to write a stack frame atomically. r=froydnj, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
0df9f3e46a2ac3e642450e61665232c8b881b5fa: Bug 1469914 - Prevent the HAL from registering duplicate observers. r=froydnj, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 22 Jun 2018 00:35:08 +0200 - rev 357520
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1469914 - Prevent the HAL from registering duplicate observers. r=froydnj, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH This also replaces the custom logic in ObserverList with an nsTObserverArray which has all the necessary logic for stable iteration over a potentially changing list of items. Unused dependencies were also removed.
bf889819fe7ec334da163a3fba9ff93582a12735: Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Ralph Giles <giles@mozilla.com> - Fri, 10 Feb 2017 12:58:18 -0800 - rev 357503
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH We use the cheddar crate to generate a C header file for our mp4parse_capi wrapper crate. Currently we do this at code check-in time via update-rust.sh. Cargo 0.18 and later will try to execute a build.rs file in the crate source tree regardless of whether it's specified in Cargo.toml so patching out that line just results in 'crate cheddar not found'. This change restores the old behaviour by substituting a 'build = false' line instead. We do have syntex vendored, but we don't currently build it by default, so I prefer this solution to just vendoring cheddar and generating the header at build time. The syntex crate is quite large and adds significantly to our compile time.
daee65cb6a9be052a5433ca527bfa27691b01659: Bug 1368150: Add IsWindows10BuildOrNewer to MFBT; r=froydnj a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Aaron Klotz <aklotz@mozilla.com> - Thu, 29 Jun 2017 13:36:47 +0900 - rev 357501
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1368150: Add IsWindows10BuildOrNewer to MFBT; r=froydnj a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH I need to be able to distinguish between builds of Windows 10. Unfortunately the stuff that I am working with cannot be sorted out via feature detection.
1315c3bb26e1af5830566f7137ed44a9fa5cf6d1: Bug 1484184 - Remove now unused _RAISE macro check to deal with MSVC 2017 15.8. r=froydnj, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 17 Aug 2018 01:27:29 +0900 - rev 357484
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1484184 - Remove now unused _RAISE macro check to deal with MSVC 2017 15.8. r=froydnj, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
82391ad3a4c05995089737ccbc39f69fa0f62242: Bug 1376057 - Replace MSVC wrappers with std::exception::_Set_raise_handler. - r=froydnj, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Jeff Gilbert <jgilbert@mozilla.com> - Wed, 22 Mar 2017 16:43:11 -0700 - rev 357478
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1376057 - Replace MSVC wrappers with std::exception::_Set_raise_handler. - r=froydnj, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
755067c14b06f36f28450311e5c4a9aa9132dae5: Bug 1413868 - Fix broken mingw-w64 build. r=froydnj, a=RyanVM FIREFOX_52_9_0esr_BUILD2 FIREFOX_52_9_0esr_RELEASE
Georg Koppen <gk@torproject.org> - Wed, 20 Jun 2018 09:32:05 +0200 - rev 357251
Push 7750 by ryanvm@gmail.com at Thu, 21 Jun 2018 13:39:46 +0000
Bug 1413868 - Fix broken mingw-w64 build. r=froydnj, a=RyanVM
f18535a212da01cb384259f9b286006d0ae8eb37: Bug 1462912 - Fixed BufferList::Extract to handle the case where the call consumes the entirety of the BufferList. r=froydnj, a=RyanVM
Alex Gaynor <agaynor@mozilla.com> - Tue, 22 May 2018 13:04:59 -0400 - rev 357210
Push 7728 by ryanvm@gmail.com at Thu, 07 Jun 2018 19:18:19 +0000
Bug 1462912 - Fixed BufferList::Extract to handle the case where the call consumes the entirety of the BufferList. r=froydnj, a=RyanVM MozReview-Commit-ID: 1LWODn8JaNL
32509dfde003b1a689c81a94815d6aaed95bad3e: Bug 1456189 - Simplify BufferList::Extract to make the lifetimes clearer. r=froydnj, a=RyanVM
Alex Gaynor <agaynor@mozilla.com> - Fri, 18 May 2018 18:59:00 -0400 - rev 357209
Push 7728 by ryanvm@gmail.com at Thu, 07 Jun 2018 19:18:19 +0000
Bug 1456189 - Simplify BufferList::Extract to make the lifetimes clearer. r=froydnj, a=RyanVM
93f6797768fca6ecc10767003690fac3db2c36bf: Bug 1452619 - Implement mozilla::IsAsciiAlpha. r=froydnj, a=lizzard FIREFOX_52_7_4esr_RELBRANCH
Jeff Walden <jwalden@mit.edu> - Mon, 09 Apr 2018 12:02:43 -0700 - rev 357071
Push 7654 by asasaki@mozilla.com at Sat, 28 Apr 2018 00:51:35 +0000
Bug 1452619 - Implement mozilla::IsAsciiAlpha. r=froydnj, a=lizzard
2b75d55ccf0ed88d4a04ee12a4848b9d4b72d4d2: Bug 1452619 - Implement mozilla::IsAsciiAlpha. r=froydnj, a=lizzard
Jeff Walden <jwalden@mit.edu> - Mon, 09 Apr 2018 12:02:43 -0700 - rev 357063
Push 7649 by ryanvm@gmail.com at Thu, 26 Apr 2018 07:02:08 +0000
Bug 1452619 - Implement mozilla::IsAsciiAlpha. r=froydnj, a=lizzard
134c728799c175b297e3704c441372398fb556e8: Bug 1452202 - Clean up PLDHashTable move operator. r=froydnj, a=RyanVM
Eric Rahm <erahm@mozilla.com> - Mon, 09 Apr 2018 11:01:59 -0700 - rev 357038
Push 7637 by ryanvm@gmail.com at Mon, 16 Apr 2018 18:26:32 +0000
Bug 1452202 - Clean up PLDHashTable move operator. r=froydnj, a=RyanVM
5678bfed134899310dd6b51c64a0d520de103093: Bug 1445582 - Error out when the searchplugins list is empty or a plugin is missing. r=froydnj, a=release
Julien Cristau <jcristau@mozilla.com> - Wed, 14 Mar 2018 10:39:36 +0100 - rev 357001
Push 7619 by ryanvm@gmail.com at Tue, 03 Apr 2018 15:28:09 +0000
Bug 1445582 - Error out when the searchplugins list is empty or a plugin is missing. r=froydnj, a=release MozReview-Commit-ID: DCUEc526d8D
28855df568d86d8b54832922da70a96cf33a74c8: Bug 1398021 - Update lz4 to version 1.8.0. r=froydnj, a=RyanVM
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 13 Sep 2017 09:43:00 -0400 - rev 356869
Push 7554 by ryanvm@gmail.com at Thu, 22 Feb 2018 17:12:10 +0000
Bug 1398021 - Update lz4 to version 1.8.0. r=froydnj, a=RyanVM
aa4b11615431883042498ed4db91c0b58e17458b: Bug 1408017 - Clear gStartupCacheWrapper in the dtor. r=froydnj, a=ritu
Andrew McCreight <continuation@gmail.com> - Thu, 26 Oct 2017 16:47:27 -0400 - rev 356718
Push 7488 by ryanvm@gmail.com at Wed, 10 Jan 2018 02:42:40 +0000
Bug 1408017 - Clear gStartupCacheWrapper in the dtor. r=froydnj, a=ritu
592df608892624c388863e739b607f9c2519e231: Bug 1407751 - DefineOSFileConstants should return false if OSFileConstants service is not initialized. r=froydnj, a=ritu
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 07:11:40 +0200 - rev 356446
Push 7362 by ryanvm@gmail.com at Fri, 13 Oct 2017 20:32:12 +0000
Bug 1407751 - DefineOSFileConstants should return false if OSFileConstants service is not initialized. r=froydnj, a=ritu
3af5bf8bdea0e59aff3820b4de2a656855e5a7fa: Bug 1400003 - Mark Heap<T> and barrier classes as MOZ_NON_MEMMOVABLE. r=sfink, r=froydnj, a=ritu
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 09 Oct 2017 10:03:20 +0100 - rev 356445
Push 7362 by ryanvm@gmail.com at Fri, 13 Oct 2017 20:32:12 +0000
Bug 1400003 - Mark Heap<T> and barrier classes as MOZ_NON_MEMMOVABLE. r=sfink, r=froydnj, a=ritu
47590f0c274be9d16f0a607343cb68d084c6d62e: Bug 1369561 - Address misc. SnprintfLiteral correctness nits. r=jld, r=froydnj, a=ritu
David Keeler <dkeeler@mozilla.com> - Fri, 15 Sep 2017 14:47:54 -0700 - rev 356431
Push 7356 by ryanvm@gmail.com at Wed, 11 Oct 2017 17:58:23 +0000
Bug 1369561 - Address misc. SnprintfLiteral correctness nits. r=jld, r=froydnj, a=ritu
4a00b7063be1f0e8da066e2638cd93d9593149aa: Bug 1279171 - Do not use WMF when application is in Windows pre-2000 compatibility mode. r=froydnj, r=mattwoodrow, a=jcristau
Kilik Kuo <kikuo@mozilla.com> - Thu, 07 Sep 2017 11:52:13 +0800 - rev 356312
Push 7295 by ryanvm@gmail.com at Fri, 08 Sep 2017 18:05:38 +0000
Bug 1279171 - Do not use WMF when application is in Windows pre-2000 compatibility mode. r=froydnj, r=mattwoodrow, a=jcristau
21af4e17cbf9f225e99c4103ac73a72311a702d1: Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj a=jorgk DONTBUILD THUNDERBIRD_52_VERBRANCH
Ralph Giles <giles@mozilla.com> - Fri, 10 Feb 2017 12:58:18 -0800 - rev 356230
Push 7261 by mozilla@jorgk.com at Mon, 14 Aug 2017 18:35:45 +0000
Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj a=jorgk DONTBUILD We use the cheddar crate to generate a C header file for our mp4parse_capi wrapper crate. Currently we do this at code check-in time via update-rust.sh. Cargo 0.18 and later will try to execute a build.rs file in the crate source tree regardless of whether it's specified in Cargo.toml so patching out that line just results in 'crate cheddar not found'. This change restores the old behaviour by substituting a 'build = false' line instead. We do have syntex vendored, but we don't currently build it by default, so I prefer this solution to just vendoring cheddar and generating the header at build time. The syntex crate is quite large and adds significantly to our compile time. MozReview-Commit-ID: InJRRODWAdP
fdbd6734448b56e8fec5917cfae3bb1c45342aa2: Bug 1368150: Add IsWindows10BuildOrNewer to MFBT; r=froydnj a=jorgk THUNDERBIRD_52_VERBRANCH
Aaron Klotz <aklotz@mozilla.com> - Thu, 29 Jun 2017 13:36:47 +0900 - rev 356228
Push 7261 by mozilla@jorgk.com at Mon, 14 Aug 2017 18:35:45 +0000
Bug 1368150: Add IsWindows10BuildOrNewer to MFBT; r=froydnj a=jorgk I need to be able to distinguish between builds of Windows 10. Unfortunately the stuff that I am working with cannot be sorted out via feature detection.
f5967db0a0f3110312014a9006d4040c6398c953: Bug 1356025 - Add Capacity checks to nsTSubstring constructor. r=froydnj, a=gchang
Eric Rahm <erahm@mozilla.com> - Mon, 15 May 2017 16:52:43 -0700 - rev 355878
Push 7115 by ryanvm@gmail.com at Mon, 22 May 2017 18:18:21 +0000
Bug 1356025 - Add Capacity checks to nsTSubstring constructor. r=froydnj, a=gchang MozReview-Commit-ID: 6RIwuvalcRz
c8ba3f911eb1fdd4f763f7dbeb96fca09b22eca4: Bug 1354308 - Entries API must support patches containing '..'. r=froydnj, a=ritu
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 27 Apr 2017 08:19:56 +0200 - rev 355817
Push 7089 by ryanvm@gmail.com at Fri, 12 May 2017 01:45:26 +0000
Bug 1354308 - Entries API must support patches containing '..'. r=froydnj, a=ritu
1d14abf37cf8cac38763f79c70742fac5a0fbb16: Bug 1338574 - Part 7: Use MOZ_CRASH_UNSAFE_PRINTF in XPCOM. r=froydnj, a=NPOTB
Emanuel Hoogeveen <emanuel.hoogeveen@gmail.com> - Tue, 21 Feb 2017 18:02:03 +0100 - rev 355808
Push 7088 by ryanvm@gmail.com at Thu, 11 May 2017 21:13:08 +0000
Bug 1338574 - Part 7: Use MOZ_CRASH_UNSAFE_PRINTF in XPCOM. r=froydnj, a=NPOTB
337398a83aa5168326f57177dd496b06c213130f: Bug 1338574 - Part 1: Add MOZ_CRASH_UNSAFE_OOL and MOZ_CRASH_UNSAFE_PRINTF to crash with a runtime generated explanation string. r=froydnj, a=NPOTB
Emanuel Hoogeveen <emanuel.hoogeveen@gmail.com> - Tue, 21 Feb 2017 18:01:41 +0100 - rev 355803
Push 7087 by ryanvm@gmail.com at Thu, 11 May 2017 20:39:55 +0000
Bug 1338574 - Part 1: Add MOZ_CRASH_UNSAFE_OOL and MOZ_CRASH_UNSAFE_PRINTF to crash with a runtime generated explanation string. r=froydnj, a=NPOTB
243d7bffa4f120bc396991e1bb76fc893d9f2f9f: Bug 1338574 - Part 0: Pass __LINE__ as an argument to MOZ_REALLY_CRASH() instead of using it directly. r=froydnj, a=NPOTB
Emanuel Hoogeveen <emanuel.hoogeveen@gmail.com> - Tue, 21 Feb 2017 18:01:38 +0100 - rev 355802
Push 7087 by ryanvm@gmail.com at Thu, 11 May 2017 20:39:55 +0000
Bug 1338574 - Part 0: Pass __LINE__ as an argument to MOZ_REALLY_CRASH() instead of using it directly. r=froydnj, a=NPOTB
2553531f83b9aede79994880dd0518b24de88703: Bug 1297111 - Refactor a thread-safe ExpirationTracker for the use in SurfaceCache. r=froydnj, r=mystor, r=aosmond, r=tnikkel, a=ritu
Andrew Osmond <aosmond@mozilla.com> - Tue, 11 Apr 2017 12:50:10 +0800 - rev 355722
Push 7061 by ryanvm@gmail.com at Thu, 04 May 2017 03:00:49 +0000
Bug 1297111 - Refactor a thread-safe ExpirationTracker for the use in SurfaceCache. r=froydnj, r=mystor, r=aosmond, r=tnikkel, a=ritu
64495dfa29db66c7768e94438a7f0ddea6a4747b: Bug 1349719 - Share max capacity logic in nsTString. r=froydnj, a=jcristau
Eric Rahm <erahm@mozilla.com> - Thu, 23 Mar 2017 12:32:53 -0700 - rev 355594
Push 7008 by ryanvm@gmail.com at Fri, 07 Apr 2017 00:45:16 +0000
Bug 1349719 - Share max capacity logic in nsTString. r=froydnj, a=jcristau This refactors the max capacity logic so that both |MutatePrep| and |Adopt| can share it. MozReview-Commit-ID: CMn4kiAoWub
b7c1f472aed7c35d94588ab69b7094420ef62761: Bug 1345413 - Fallback to getpwuid() info when LOGNAME is not set when creating the XRemote mutex. r=froydnj a=jcristau FIREFOX_ESR_52_0_X_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Tue, 14 Mar 2017 14:11:55 +0900 - rev 355393
Push 6960 by ryanvm@gmail.com at Mon, 20 Mar 2017 20:55:55 +0000
Bug 1345413 - Fallback to getpwuid() info when LOGNAME is not set when creating the XRemote mutex. r=froydnj a=jcristau
055d03b56e147429139d37b4d7e93de0fe3d61be: Bug 1345413 - Fallback to getpwuid() info when LOGNAME is not set when creating the XRemote mutex. r=froydnj a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Tue, 14 Mar 2017 14:11:55 +0900 - rev 355365
Push 6946 by ryanvm@gmail.com at Thu, 16 Mar 2017 19:46:03 +0000
Bug 1345413 - Fallback to getpwuid() info when LOGNAME is not set when creating the XRemote mutex. r=froydnj a=jcristau
f075b15b50d5da294b866a13dd70ef3b45beaa46: Bug 1151506 - Null-check the count parameter in GetConstantCount. r=froydnj, a=sledru
David Major <dmajor@mozilla.com> - Wed, 24 Jun 2015 09:07:11 -0700 - rev 354553
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1151506 - Null-check the count parameter in GetConstantCount. r=froydnj, a=sledru
b7bb31e5a851d6f8e142c39dc077e3774719eced: Bug 1330119 - Build Linux aarch64 code in XPTCALL also on BSDs. r=froydnj a=jcristau
Jan Beich <jbeich@FreeBSD.org> - Tue, 10 Jan 2017 22:50:32 +0000 - rev 354444
Push 6904 by ryanvm@gmail.com at Fri, 24 Feb 2017 21:54:48 +0000
Bug 1330119 - Build Linux aarch64 code in XPTCALL also on BSDs. r=froydnj a=jcristau MozReview-Commit-ID: 92T1qG5yVx2
97ce4f0843b9aa1288ddf3553efe1d0c2fd8c6a4: Bug 1335854 - Tone down non-zero refcount message for dynamic atoms. r=froydnj, a=jcristau
Jorg K <jorgk@jorgk.com> - Wed, 01 Feb 2017 11:47:00 -0500 - rev 354270
Push 6893 by ryanvm@gmail.com at Tue, 14 Feb 2017 20:53:58 +0000
Bug 1335854 - Tone down non-zero refcount message for dynamic atoms. r=froydnj, a=jcristau
578c951dde5fbd337481ac08e32175fd838d640c: Bug 1322825 - Incremental tokenizer. r=froydnj, a=jcristau
Honza Bambas <honzab.moz@firemni.cz> - Wed, 08 Feb 2017 05:24:00 -0500 - rev 354196
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1322825 - Incremental tokenizer. r=froydnj, a=jcristau
49b3ad9f467d48194dab8121f82e4c938b70b484: Bug 1328643 - Add some locking to prevent races caused by Cancel/Init from threads other than the target. (build fixed) r=froydnj, a=jcristau FIREFOX_52_0b5_BUILD1 FIREFOX_52_0b5_RELEASE
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 11 Jan 2017 13:59:19 -0600 - rev 354182
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1328643 - Add some locking to prevent races caused by Cancel/Init from threads other than the target. (build fixed) r=froydnj, a=jcristau MozReview-Commit-ID: FdAPTGDNKup
16f96708bef9c19fd9ad80d5201bda24ceb5f235: Bug 1328643 - Add some locking to prevent races caused by Cancel/Init from threads other than the target. r=froydnj, a=jcristau
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 11 Jan 2017 13:59:19 -0600 - rev 354178
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1328643 - Add some locking to prevent races caused by Cancel/Init from threads other than the target. r=froydnj, a=jcristau MozReview-Commit-ID: FdAPTGDNKup
ec7ea9c6e94a6c640b9512f43473508dbfea25da: Bug 1328569 - Don't call UnmapViewOfFile() with a null address. r=froydnj, a=jcristau
Cervantes Yu <cyu@mozilla.com> - Wed, 04 Jan 2017 18:42:51 +0800 - rev 354161
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1328569 - Don't call UnmapViewOfFile() with a null address. r=froydnj, a=jcristau MozReview-Commit-ID: Ca5n8rSXQ4x
172c98a3b287f6d0a0bc7ba7a56478e8eb186330: Bug 1321244 - Lazily init global variables that could implicitly initialize NSPR. r=froydnj, a=jcristau
Cervantes Yu <cyu@mozilla.com> - Thu, 01 Dec 2016 11:48:32 +0800 - rev 354160
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1321244 - Lazily init global variables that could implicitly initialize NSPR. r=froydnj, a=jcristau MozReview-Commit-ID: IPU9Qc8lr50
af422c1e8f80521e4c95a22878b0e7733d1674b0: Bug 1308610 - Part 1: Remove use-counter mochitest's flaky chunk about testing counters in SVG "list-style-image" docs. r=froydnj, a=test-only
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 07 Feb 2017 14:52:02 -0800 - rev 354146
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1308610 - Part 1: Remove use-counter mochitest's flaky chunk about testing counters in SVG "list-style-image" docs. r=froydnj, a=test-only It's hard to predict the timing of SVG-as-an-image document teardown, for SVG images used in CSS, so this piece of the test was flaky. And anyway, we have other tests for use counters in SVG-as-an-image (see calls to "check_use_counter_img"), which should exercise the codepath we care about here. MozReview-Commit-ID: DbYWDYUOc1c
31048f0f80cea76e509591b7d563df4838755921: Bug 1308610 - Part 0: Remove no-longer-used mochitest helper file "file_use_counter_svg_background.html". r=froydnj, a=test-only
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 07 Feb 2017 14:52:00 -0800 - rev 354145
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1308610 - Part 0: Remove no-longer-used mochitest helper file "file_use_counter_svg_background.html". r=froydnj, a=test-only The only usages of this file were removed in an earlier bug, in this changeset: https://hg.mozilla.org/mozilla-central/rev/fe97a239ab5a MozReview-Commit-ID: ERHhgJizvSE
6a044187aa43e948d62b1b766a8aad9e7f3073c8: Bug 1321579 - Add -fno-lifetime-dse when building with GCC >= 5.0. r=froydnj, a=lizzard
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Feb 2017 17:01:17 +0900 - rev 354117
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1321579 - Add -fno-lifetime-dse when building with GCC >= 5.0. r=froydnj, a=lizzard
b9e7643b8be64976276573389670f70d57e1fe9f: Bug 1334537 - Make sure to clear out our external string cache if the length doesn't match, since our length no longer needs to match our stringbuffer. r=froydnj, a=lizzard
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 01 Feb 2017 15:29:47 -0500 - rev 354048
Push 6872 by ryanvm@gmail.com at Fri, 03 Feb 2017 00:24:19 +0000
Bug 1334537 - Make sure to clear out our external string cache if the length doesn't match, since our length no longer needs to match our stringbuffer. r=froydnj, a=lizzard Without this change, we could do a "short" get of a string (e.g. from XMLHttpRequest), then do another get that returns the same stringbuffer but a longer length. But we wouldn't notice, hit our cache, and return the same, too-short, external string. The site would not see the new data it should have seen.
d6ff11588e1d1de9e257555319e6c4d0cb378e8c: Bug 1332202 - Convert most infallible NS_EscapeURL calls to fallible version. r=froydnj, a=jcristau
Eric Rahm <erahm@mozilla.com> - Tue, 24 Jan 2017 11:11:44 -0800 - rev 353951
Push 6843 by ryanvm@gmail.com at Mon, 30 Jan 2017 17:33:00 +0000
Bug 1332202 - Convert most infallible NS_EscapeURL calls to fallible version. r=froydnj, a=jcristau This makes most users of |NS_EscapeURL| use the fallible version. A few are left infallible as it seems like the entire function is assumed to be infallible. MozReview-Commit-ID: Cy1L5jQwjO1
47beb6fad37a97a96db8fbd03f064905b7153a99: Bug 1317259 - Prevent double init in mozilla::TimeStamp::Startup() on Windows. r=froydnj, a=jcristau
Cervantes Yu <cyu@mozilla.com> - Mon, 14 Nov 2016 19:01:17 +0800 - rev 353878
Push 6830 by ryanvm@gmail.com at Thu, 26 Jan 2017 21:49:19 +0000
Bug 1317259 - Prevent double init in mozilla::TimeStamp::Startup() on Windows. r=froydnj, a=jcristau MozReview-Commit-ID: JKfEFqo5qHj
1522cb56a651b62675f392d4064bd4365aac07f4: Bug 1330759 - Part 6: Make the null-termination asserts in nsStringBuffer::ToString into diagnostic asserts. r=froydnj, a=jcristau
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 18 Jan 2017 22:20:15 -0500 - rev 353787
Push 6805 by ryanvm@gmail.com at Tue, 24 Jan 2017 05:52:45 +0000
Bug 1330759 - Part 6: Make the null-termination asserts in nsStringBuffer::ToString into diagnostic asserts. r=froydnj, a=jcristau
121ee6ad585ef8d8f26a986830d71afc9b306c86: Bug 1330759 - Part 5: Back out the nsTSubstring changes we made in bug 1324430, because they can lead to non-null-terminated nsStrings. r=froydnj, a=jcristau
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 18 Jan 2017 22:20:15 -0500 - rev 353786
Push 6805 by ryanvm@gmail.com at Tue, 24 Jan 2017 05:52:45 +0000
Bug 1330759 - Part 5: Back out the nsTSubstring changes we made in bug 1324430, because they can lead to non-null-terminated nsStrings. r=froydnj, a=jcristau
cdaba011494a6f01f7ed4e8f419653b4ee5dbcca: Bug 1330759 - Part 4: Change XMLHttpRequest's responseText getter to take a DOMString, not an nsAString. r=froydnj, a=jcristau
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 18 Jan 2017 22:20:15 -0500 - rev 353785
Push 6805 by ryanvm@gmail.com at Tue, 24 Jan 2017 05:52:45 +0000
Bug 1330759 - Part 4: Change XMLHttpRequest's responseText getter to take a DOMString, not an nsAString. r=froydnj, a=jcristau
0f3d229ed368c45b2e12e080d0e1d4956a88aaa0: Bug 1330759 - Part 3: Add a "stringbuffer we own" mode to DOMString. r=froydnj, a=jcristau
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 18 Jan 2017 22:20:14 -0500 - rev 353784
Push 6805 by ryanvm@gmail.com at Tue, 24 Jan 2017 05:52:45 +0000
Bug 1330759 - Part 3: Add a "stringbuffer we own" mode to DOMString. r=froydnj, a=jcristau We're going to need it because we're going to add a consumer that cannot in fact promise that its stringbuffer reference will outlive the DOMString.
8dcb11ae3b13d49ccfecfd7d43c1aaed9f4360ad: Bug 1330759 - Part 2: Fix XPCConvert::JSData2Native to not share an external string stringbuffer if it would create a non-null-terminated string. r=froydnj, a=jcristau
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 18 Jan 2017 22:20:14 -0500 - rev 353783
Push 6805 by ryanvm@gmail.com at Tue, 24 Jan 2017 05:52:45 +0000
Bug 1330759 - Part 2: Fix XPCConvert::JSData2Native to not share an external string stringbuffer if it would create a non-null-terminated string. r=froydnj, a=jcristau