searching for reviewer(chmanchester)
2829cd1b5e25e13c2aaafd935bfcdf9649b66ad8: Bug 1347576 - Add a 'mach repackage' command, with OSX dmg support; r=chmanchester a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
Mike Shal <mshal@mozilla.com> - Fri, 10 Mar 2017 18:36:23 -0500 - rev 357564
Push 7836 by frgrahl@gmx.net at Mon, 15 Jul 2019 16:17:02 +0000
Bug 1347576 - Add a 'mach repackage' command, with OSX dmg support; r=chmanchester a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only. This is the initial support of 'mach repackage', which can take an existing tarball and create a DMG on either an OSX host or on a Linux host with cross-OSX tools. Configure is needed in order to find the tools necessary to create the DMG. On a Linux cross-compiled environment with tooltool, this can be as simple as: export MKFSHFS=$topsrcdir/hfsplus-tools/newfs_hfs export DMG_TOOL=$topsrcdir/dmg/dmg export HFS_TOOL=$topsrcdir/dmg/hfsplus ac_add_options --disable-compile-environment MozReview-Commit-ID: 6t2rlXpwUvu
8a25ba5859ed45b6827ad7a96823b5570f297f7b: bug 1358215 - add MOZ_PHOTON_ANIMATIONS config var/define, default enabled on nightly. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Ted Mielczarek <ted@mielczarek.org> - Mon, 08 May 2017 16:01:44 -0400 - rev 357461
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
bug 1358215 - add MOZ_PHOTON_ANIMATIONS config var/define, default enabled on nightly. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
8ba410e8ca332d078126b2b358068b0b05768a42: Bug 1316956 - Add a when argument to check_prog. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Sat, 13 May 2017 07:12:56 +0900 - rev 357456
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1316956 - Add a when argument to check_prog. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
e64be065932348fbb737065cbc3c51da107c9285: Bug 1363585 - Forbid boolean operations on @depends functions. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 10 May 2017 11:35:22 +0900 - rev 357455
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1363585 - Forbid boolean operations on @depends functions. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Doing something like "not foo" when foo is a @depends function is never going to do what the user expects, while not necessarily leading to an error (like, when used in set_config). It is better to have an error in those cases where it's expected not to work, at the expense of making templates a little more verbose, rather than silently do something the user is not expecting.
d35db7517f0493253bc109b6cca95f5c84943e8a: Bug 1335666 - Remove @depends_when. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 01 Feb 2017 16:25:29 +0900 - rev 357454
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1335666 - Remove @depends_when. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH In bug 1296530, we made @depends take a when argument, it can now replace all uses of @depends_when.
2b94be1f975cabc2c2fcded911bb41bca348ccca: Bug 1322025 - Provide variants of host and target that depend on --help. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:54:16 +0900 - rev 357451
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Provide variants of host and target that depend on --help. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH We want to avoid giving --help dependencies to host and target, so that they we don't spawn config.guess and config.sub when running configure --help, and don't need to reach out to the which module to find a suitable shell to execute them. So, when --help is given, we return a fake host/target namespace, and avoid the config.guess/config.sub-invoking code being executed. Then, by giving the --help option to the linter, it can properly find that the config.guess/config.sub-invoking code doesn't need the dependency on --help. This effectively unbreaks configure --help after bug 1313306.
d87d2f649f437c59f29180d6edf856edbdfc55ad: Bug 1322025 - Allow to combine two DependsFunctions with "|". r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:42:33 +0900 - rev 357450
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Allow to combine two DependsFunctions with "|". r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Ideally, it would have been better if it were "or", but it's not possible to override "or" in python ; __or__ is for "|". This does feel magic, but it's also shorter than adding something like @depends_any(), and while we're only adding "|" as of this change, we can add other operations such as "&" in the future, or __getattr__ for things like milestone.is_nightly. An alternative form in moz.configure could require the @depends function to be called, e.g. "a() | b()" instead of "a | b", but I'm not particularly convinced that one is less magic than the other. This feature is hooked up such that b is not resolved if a is true, although in practice, it will still be resolved in Sandbox.run... but not when --help is passed. In the long run, the forced resolution of @depends functions will be removed from Sandbox.run.
e7762fd623b92c2256cf0081860277d9ba920d2b: Bug 1322025 - Don't automatically add --help dependencies to CombinedDependsFunctions. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:10:03 +0900 - rev 357449
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Don't automatically add --help dependencies to CombinedDependsFunctions. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Adding those dependencies, retrospectively, only worked around the poor handling of --help requirements by the linter, that we fixed a few commits ago. This is now not necessary anymore.
01c6332e22b0ec6858748f8f4a5ffa4e476bd413: Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 16:50:29 +0900 - rev 357448
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Several things were wrong with the wrapping: - the equality test on functions was actually comparing the memoized functions, which have a type memoize, which inherits from dict. So they weren't comparing actual functions, but the dict used to store the cache of their invocation. - each CombinedDependsFunction created for the same combination function used a different wrapped function, so even if the dict problem wasn't there, the equality test still wouldn't work, except if the function wrapping itself was memoized. - the memoization was not particularly useful. Also, for upcoming changes, we'd actually like the combination function to take an iterable instead of a variable argument list, so that items of the iterable can be skipped.
4ba744632d51076e2a0d8324fa8a590dcfb5441f: Bug 1322025 - Make DependsFunction.func less public. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 16:32:03 +0900 - rev 357447
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Make DependsFunction.func less public. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH We're going to change the function signature for CombinedDependsFunction, so make it visible in the API that the function member is not meant to be used directly. The linter still does, though, because it needs to look in their guts. At the same time, avoid setting DependsFunction names via the function name itself, because in upcoming changes, it will not be modifiable in some cases.
38a758ced7935484ca54b923b695df11769d8a02: Bug 1322025 - Enforce --help requirement on option's when argument. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 14:37:34 +0900 - rev 357446
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Enforce --help requirement on option's when argument. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Options with a `when` argument (either directly, or inherited through only_when() or an include) require --help per _value_for_option, but that code path is not exercised during a lint pass. With this change, along the previous one, we now correctly detect that bug 1316957 was not supposed to work as is.
d20b7ab6e1cc5c683ec2261baacdb0ca090cf074: Bug 1322025 - Enforce --help requirement on indirect dependencies. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 14:25:58 +0900 - rev 357445
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1322025 - Enforce --help requirement on indirect dependencies. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Bug 1313306 relaxed the --help dependency requirement in some cases, but while doing so, the requirement was also removed in other, unexpected cases. Specifically, the --help dependency ended up not being required on indirect dependencies that should have had it, had the --help dependency been explicit on the direct dependency.
5e2864d31392d48997173bfcc09cd4b008c53811: Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Sat, 12 Nov 2016 06:05:07 +0900 - rev 357442
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
e58b690756a9557c3017ffaf720919d53e0c7b03: Bug 1317504 - Don't try to set LD from old-configure. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:47:10 +0900 - rev 357441
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1317504 - Don't try to set LD from old-configure. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Now, it's completely unused.
5e4c8a0a40d9d7114678851666c90aed2ee6d599: Bug 1317504 - Make MSVC builds use the LINK variable instead of LD. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:45:16 +0900 - rev 357440
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1317504 - Make MSVC builds use the LINK variable instead of LD. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH At the same time, remove HOST_LD. It was only used for MSVC builds, which don't support cross-compile anyways, so we can, at least for now, use LINK for both host and target.
991d3accea4b689f712638107041c57567b8c77b: Bug 1317504 - Remove the GNU_LD variable, nothing uses it. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:25:42 +0900 - rev 357439
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1317504 - Remove the GNU_LD variable, nothing uses it. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
2e38641c583bf5a3222ba7400b0769b748610238: Bug 1317504 - Remove unused non-GCC/clang flags settings. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:17:59 +0900 - rev 357438
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1317504 - Remove unused non-GCC/clang flags settings. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH Compilers other than GCC, clang and MSVC have not been supported for a while, and have been explicitly rejected since bug 1259382. There are a few branches in old-configure that are taken for non-GCC/clang compilers, but all of them are later overwritten by the MSVC setup. So we just remove those.
9753423e54d427657833698cecf8acbaf3d6916a: Bug 1317504 - Warn that LD is not used by the build system. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:07:01 +0900 - rev 357437
Push 7834 by frgrahl@gmx.net at Sun, 13 Jan 2019 12:17:02 +0000
Bug 1317504 - Warn that LD is not used by the build system. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH It turns out that, in practice, the LD variable is not used by the build system, except on Windows, where it's used to feed the default for LINK, which is then re-injected as LD. The upcoming changes are going to normalize the use of LD/LINK.
21e81dba88928435646096c6e2b824d917b6b6d9: Bug 1316844 - Make the linter detect unused dependencies. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Nov 2016 12:52:58 +0900 - rev 357432
Push 7833 by frgrahl@gmx.net at Sat, 12 Jan 2019 20:48:20 +0000
Bug 1316844 - Make the linter detect unused dependencies. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
9c6528a8536168e93e3d073ecf0885739a9c451e: Bug 1316844 - Remove unused dependencies. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Nov 2016 12:52:37 +0900 - rev 357431
Push 7833 by frgrahl@gmx.net at Sat, 12 Jan 2019 20:48:20 +0000
Bug 1316844 - Remove unused dependencies. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
533de0d51af681ab721bf23e67de65f9eaeeaedc: Bug 1316844 - Improve function unwrapping to properly cover templates. r=chmanchester, a=IanN CLOSED TREE DONTBUILD SEAMONKEY_2_49_ESR_RELBRANCH
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Nov 2016 11:32:43 +0900 - rev 357430
Push 7833 by frgrahl@gmx.net at Sat, 12 Jan 2019 20:48:20 +0000
Bug 1316844 - Improve function unwrapping to properly cover templates. r=chmanchester, a=IanN CLOSED TREE DONTBUILD mozilla-esr52 SEAMONKEY_2_49_ESR_RELBRANCH
10be69536c446764fa0cea672768abc93540b31d: Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester, r=mikedeboer, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Aug 2016 18:17:35 +0900 - rev 353855
Push 6826 by ryanvm@gmail.com at Wed, 25 Jan 2017 17:02:21 +0000
Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester, r=mikedeboer, a=jcristau
1a240efc72a9c50d8e846f42948f0c08406a40d0: Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Nov 2016 07:43:39 +0900 - rev 352451
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester, a=jcristau
03d26fc3da000f90bf441feb6aad233b71ef4a6b: Bug 1317359 - Move add_old_configure_* functions to util.configure. r=chmanchester, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Nov 2016 14:35:22 +0900 - rev 352450
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1317359 - Move add_old_configure_* functions to util.configure. r=chmanchester, a=jcristau
2b174353e76a8c7b7595f29b21a797f8f84af72c: Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Sat, 12 Nov 2016 06:05:07 +0900 - rev 352258
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
fb579bc49c2f153e61cf06b34bcd6a03a409e6c4: Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:32:28 +0900 - rev 351895
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
53f988e1c1fd34ca2ff5f42a59fa05b4a768a1e5: Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:22:17 +0900 - rev 351894
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester The current state of python configure sandbox execution is that if a template imports a module, and a function defined in the template tries to use the module, it doesn't work. Ideally, it would, but rather than try to fix this corner case, we remove the unit tests that assume it works (and consequently pass for half bad reasons), and add a unit test so that the behavior doesn't change unwillingly.
1a61a17b9986e0ecb70d33ed28cb512c0843ed0a: Bug 1314894 - Avoid path changes from b6be0e9e3e1e. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 04 Nov 2016 06:50:43 +0900 - rev 351008
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1314894 - Avoid path changes from b6be0e9e3e1e. r=chmanchester Importing 'os' in python configure functions, on Windows, changes the separate the various os.path functions use, and that can have unexpected, badly handled, consequences. While on the long term, it is desirable to make @imports('os') modify os.path to use the same base functions as if there were no @imports, let's go with the simpler workaround of restoring the non-{isfile,isdir,exists} os.path functions from b6be0e9e3e1e.
f74ebe3e7a86429a4157049956996a84a2ef0c25: Bug 1313028 - GCC 6 null pointer check removal causes segfaulting in ActionResultHolder::GetValueAndDelete(). r=chmanchester.
Julian Seward <jseward@acm.org> - Tue, 01 Nov 2016 17:23:46 +0100 - rev 350647
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313028 - GCC 6 null pointer check removal causes segfaulting in ActionResultHolder::GetValueAndDelete(). r=chmanchester.
8158226d06a0ca0f69c60a87adfaef1a6151f285: Bug 1313306 - Remove --help dependencies from @dependable and delayed_getattr. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 27 Oct 2016 15:00:51 +0900 - rev 350460
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313306 - Remove --help dependencies from @dependable and delayed_getattr. r=chmanchester This sadly requires to replace a few @dependendable to pass the lint check.
0ac9e88ff47be0989d6a2eb609583c78acac2ade: Bug 1313306 - Allow @depends(when=something) without additional dependencies. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 26 Oct 2016 16:42:06 +0900 - rev 350459
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313306 - Allow @depends(when=something) without additional dependencies. r=chmanchester Also allow when=True/False to avoid the chicken-egg problem of using a generic `when` to use in replacement of @depends('--help') for things like @dependable.
a801ef597f1fe732469ef362a9a160940e42a5d9: Bug 1313306 - Relax the rules for --help dependencies. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 27 Oct 2016 13:40:42 +0900 - rev 350458
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313306 - Relax the rules for --help dependencies. r=chmanchester --help dependencies currently help identify functions that will run when running configure --help, which we don't want to have spreading too much. OTOH, when such functions have no side effect, it's not really that important to have them explicitly marked. So, allow missing --help dependencies for functions that: - don't use @imports - don't have a closure - don't use global variables This is a first step towards entirely removing the --help markings (the end goal being that --help dependencies will indicate actual --help dependencies). As such, we don't really care about updating the lint error message.
b6be0e9e3e1ead9c62fc04e60d65015aa13cb08c: Bug 1313306 - Don't expose os.path.{exists,isdir,isfile} to python configure without an @imports. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 26 Oct 2016 11:49:58 +0900 - rev 350457
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313306 - Don't expose os.path.{exists,isdir,isfile} to python configure without an @imports. r=chmanchester We want functions without an @imports to not have any side effects, and to not use external resources. So remove the few functions we expose from os.path without @imports('os') that do.
0e64d3d27520fa2b092a47ce1522754fa134f060: Bug 1313306 - Move --help dependency checks to the linter. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 27 Oct 2016 10:02:21 +0900 - rev 350456
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313306 - Move --help dependency checks to the linter. r=chmanchester Missing such dependencies shouldn't impair running configure itself after local modifications, but they are currently required for (mostly) documentation purpose. Which means they are better done in the linter.
caf5e078e7ef8fbac007d3ef7851b961d009a87c: Bug 1313306 - Add a placeholder python configure linter. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 27 Oct 2016 09:36:33 +0900 - rev 350455
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313306 - Add a placeholder python configure linter. r=chmanchester
97db1163c72973f0027e25591b09819a903c2b50: Bug 1305534 - Add debug artifact builds on try; r=chmanchester
Maja Frydrychowicz <mjzffr@gmail.com> - Tue, 18 Oct 2016 11:18:58 -0400 - rev 350177
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1305534 - Add debug artifact builds on try; r=chmanchester MozReview-Commit-ID: Gg46RzHarO1
efba37187d2d41078def06a75991770f6058f26d: Bug 1263876 - Improve python configure handling of toolchain prefix. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 21 Oct 2016 07:50:40 +0900 - rev 349324
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1263876 - Improve python configure handling of toolchain prefix. r=chmanchester The toolchain checks are now such that we can stop special casing x86-64 <-> x86 cross compiling. OTOH, depending on the target, the toolchain prefix can be of the form `cpu-os` or `cpu-machine-os`. We were only using the former, and we change this to allow to try both. Finally, the toolchain prefix being a gcc thing, it applies on all target platforms where we try to use gcc. However, the status quo is kept for the value of TOOLCHAIN_PREFIX exposed to old-configure and the build system, until the various tools paths (such as ar, readelf, etc.) are handled in python configure.
619ccb0d81f1adc30894807a13196d63ddbe7966: Bug 1311871 - Fix NSIS version check for NSIS version 3.0. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 21 Oct 2016 09:15:34 +0900 - rev 349005
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1311871 - Fix NSIS version check for NSIS version 3.0. r=chmanchester
fc577423948f36ef86955ebac4a8e468ddd3a8ab: Bug 1311761 - Fixup after bug 1311069. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 21 Oct 2016 06:15:38 +0900 - rev 348847
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1311761 - Fixup after bug 1311069. r=chmanchester
83a03cc29bb7674645a46b805cafdc75502f2afe: Bug 1311069 - Don't throw InvalidOptionError exceptions when a non-available option was set from an environment variable. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 19 Oct 2016 09:06:41 +0900 - rev 348707
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1311069 - Don't throw InvalidOptionError exceptions when a non-available option was set from an environment variable. r=chmanchester
d74a9133f9a5c0a7374bef2a0be15e3ed7b37113: Bug 1302153 - Test jobs busted when artifact build forced on linux64 debug taskcluster; r=chmanchester
Maja Frydrychowicz <mjzffr@gmail.com> - Thu, 13 Oct 2016 17:42:27 -0400 - rev 348501
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1302153 - Test jobs busted when artifact build forced on linux64 debug taskcluster; r=chmanchester Upload symbols when --enable-artifact-build-symbols is specified. Add --enable-artifact-build-symbols to artifact config for linux, linux64, win32, win64, macosx64. MozReview-Commit-ID: LpuwfzWXPBH
69a218996577506c9b5756cccb3ff77fb293c31c: Bug 1250700 - Use the gecko.v2 instead of buildbot for artifact builds; r=chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 30 Sep 2016 15:22:28 -0400 - rev 348385
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1250700 - Use the gecko.v2 instead of buildbot for artifact builds; r=chmanchester MozReview-Commit-ID: Hn55McoK1sY
793b6eeb323a11768a95fbe679159e87a3dc1267: Bug 1296530 - Replace include_when with include, and remove include_when. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 13 Oct 2016 17:15:24 +0900 - rev 348324
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Replace include_when with include, and remove include_when. r=chmanchester
8bc8d974ae1091b155130608c40f8dac477e637a: Bug 1296530 - Add an only_when context manager, and a `when` argument to include(). r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 16:56:11 +0900 - rev 348323
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Add an only_when context manager, and a `when` argument to include(). r=chmanchester
7b7af91ddac6d2f921513b3909e522f4ac7d7fb4: Bug 1296530 - Add a `when` argument to imply_option(). r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 14:48:47 +0900 - rev 348322
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Add a `when` argument to imply_option(). r=chmanchester
c728d106f0d84893dbb4a5c7f43ad298aadb3fdd: Bug 1296530 - Add a `when` argument to set_config() and set_define(). r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 14:24:28 +0900 - rev 348321
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Add a `when` argument to set_config() and set_define(). r=chmanchester
38130e1d78cbfacaa0c9277533bbabdfd31ed2e2: Bug 1296530 - Add a `when` argument to option(). r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 17:45:53 +0900 - rev 348320
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Add a `when` argument to option(). r=chmanchester
8641bc42dcccd5fa7b3dbfc8dc6a770fa85d80de: Bug 1296530 - Add a `when` argument to @depends(). r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 13:52:08 +0900 - rev 348319
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Add a `when` argument to @depends(). r=chmanchester
45b4e523d944bae67f268413973355f25836c2bb: Bug 1296530 - Add a test for unexpected keyword argument to @depends. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 13:48:23 +0900 - rev 348318
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Add a test for unexpected keyword argument to @depends. r=chmanchester
9ae12fd1dd3d2ddfd2de86aec4c3d44b40ff505b: Bug 1296530 - Get help text out of TestConfigure.get_config when given --help. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 12 Oct 2016 11:11:56 +0900 - rev 348317
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1296530 - Get help text out of TestConfigure.get_config when given --help. r=chmanchester