searching for reviewer(billm)
e0e23e1fd9e3bf023397ebf0dd412ccc6d6954d4: Bug 1314520 - part 2 Finish initializing TabChild rendering state even if compositing IPC is lost. r=billm a=IanN DONTBUILD CLOSED TREE SEAMONKEY_2_49_ESR_RELBRANCH
David Anderson <danderson@mozilla.com> - Mon, 14 Nov 2016 14:58:22 -0800 - rev 357569
Push 7836 by frgrahl@gmx.net at Mon, 15 Jul 2019 16:17:02 +0000
Bug 1314520 - part 2 Finish initializing TabChild rendering state even if compositing IPC is lost. r=billm a=IanN DONTBUILD CLOSED TREE SeaMonkey ESR52 release branch only.
2f30955c1dca3c1664668c09624346c582b9a1a6: Bug 1334097 - Remove unused variable. r=billm, a=bustage
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 18 May 2017 14:41:14 -0400 - rev 355864
Push 7107 by ryanvm@gmail.com at Thu, 18 May 2017 18:41:25 +0000
Bug 1334097 - Remove unused variable. r=billm, a=bustage
9e17e0266d219c19918e4d404d4e594b45a3094b: Bug 1354294 - Don't clear extra slots when nuking a proxy to avoid reviving dead compartments. r=billm, a=jcristau
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 23 Nov 2016 10:15:05 +0000 - rev 355667
Push 7037 by ryanvm@gmail.com at Mon, 17 Apr 2017 13:52:02 +0000
Bug 1354294 - Don't clear extra slots when nuking a proxy to avoid reviving dead compartments. r=billm, a=jcristau Backport of https://hg.mozilla.org/mozilla-central/rev/ace95a181f29, originally from bug 1318384.
bc646835442bf9af795fa8fe88fe7414b6f30649: Bug 1208957 - No need for a condvar for thread shutdown. r=billm, a=jcristau
Blake Kaplan <mrbkap@gmail.com> - Tue, 14 Mar 2017 23:36:02 -0700 - rev 355531
Push 6992 by ryanvm@gmail.com at Thu, 30 Mar 2017 23:54:34 +0000
Bug 1208957 - No need for a condvar for thread shutdown. r=billm, a=jcristau Now that we join on the thread exiting, we no longer need to have the thread explicitly tell us it's shutting down. MozReview-Commit-ID: LycPjUvyeX
2b68880d8f6b1a5636f0f672d27856ae16203598: Bug 1208957 - Join the watchdog thread to avoid shutdown races. r=billm, a=jcristau
Blake Kaplan <mrbkap@gmail.com> - Tue, 14 Mar 2017 23:27:21 -0700 - rev 355530
Push 6992 by ryanvm@gmail.com at Thu, 30 Mar 2017 23:54:34 +0000
Bug 1208957 - Join the watchdog thread to avoid shutdown races. r=billm, a=jcristau MozReview-Commit-ID: FlnPO2fJWVu
08f2bc167ae82a6f86e427283d8b972ba794b846: Bug 1299500 - Get rid of DeviceStorage API - part 10 - DeviceStorage, r=ehsan, r=billm, a=jcristau
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 08 Mar 2017 20:15:45 +0100 - rev 355512
Push 6987 by ryanvm@gmail.com at Wed, 29 Mar 2017 15:48:26 +0000
Bug 1299500 - Get rid of DeviceStorage API - part 10 - DeviceStorage, r=ehsan, r=billm, a=jcristau
c5c236ff438c31fd9652ab4659d4113eef77f490: Bug 1343453 - Backport some upstream libevent fixes to our in-tree copy. r=billm, a=ritu
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 09 Mar 2017 19:37:52 -0500 - rev 355315
Push 6936 by ryanvm@gmail.com at Fri, 10 Mar 2017 23:06:26 +0000
Bug 1343453 - Backport some upstream libevent fixes to our in-tree copy. r=billm, a=ritu Fixes for upstream issues #317, #318, #332, and #335.
0bb3236cb12af980fcf222a50e441fd5395d8df3: Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access. r=billm a=ritu
Kris Maglione <maglione.k@gmail.com> - Tue, 22 Nov 2016 12:31:37 -0800 - rev 355056
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access. r=billm a=ritu MozReview-Commit-ID: IS7mpOnQ8y0
313505a1047e248f591b8345765090a609512581: Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing. r=billm a=ritu
Kris Maglione <maglione.k@gmail.com> - Wed, 23 Nov 2016 18:04:03 -0800 - rev 355055
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing. r=billm a=ritu MozReview-Commit-ID: KXA7xlq8Voc
679df985e0566c7805e6e441fabc0ae4984fc5b4: Bug 1308920: Part 2 - Support posting messages across windows with different addonId origins. r=billm a=ritu
Kris Maglione <maglione.k@gmail.com> - Tue, 01 Nov 2016 19:04:13 -0700 - rev 355015
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1308920: Part 2 - Support posting messages across windows with different addonId origins. r=billm a=ritu MozReview-Commit-ID: 89TD8x5cUlZ
6b065281b17bfda001f0fd98ff5d9ebc1edf3ca6: Bug 1309823 - Forget file descriptors before starting actor destruction. r=billm, a=lizzard
Ben Kelly <ben@wanderview.com> - Fri, 14 Oct 2016 08:27:28 +0200 - rev 354978
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1309823 - Forget file descriptors before starting actor destruction. r=billm, a=lizzard
2d23fe5dc5e2c6f72c005403d36738e0ff4895b4: Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases on a CLOSED TREE. r=billm,chutten,liuche, a=lizzard
Mike Conley <mconley@mozilla.com> - Wed, 07 Sep 2016 13:22:12 -0400 - rev 354962
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases on a CLOSED TREE. r=billm,chutten,liuche, a=lizzard MozReview-Commit-ID: 2XzfXDqoB
7e7b02185615e796c6698fa41aeb2d7b47fbbaee: Bug 1254856 - Use a better window for 3rd-party checks. r=sicking, r=billm, a=sledru
Blake Kaplan <mrbkap@gmail.com> - Fri, 11 Mar 2016 23:28:00 -0500 - rev 354806
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1254856 - Use a better window for 3rd-party checks. r=sicking, r=billm, a=sledru
c728f7d9d0dc1373f116563ae336280c23ffbf3e: Bug 1254856 - Use a better window for 3rd-party checks. r=sicking, r=billm, a=sledru
Blake Kaplan <mrbkap@gmail.com> - Fri, 11 Mar 2016 23:28:00 -0500 - rev 354804
Push 6908 by raliiev@mozilla.com at Mon, 27 Feb 2017 16:57:28 +0000
Bug 1254856 - Use a better window for 3rd-party checks. r=sicking, r=billm, a=sledru
07fc9bc143f7bfa4a6be7ecb5c0d3c591211b3a7: Bug 1318914 - Fix --with-system-libevent build against libevent 2.1. r=billm, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Sun, 20 Nov 2016 17:51:17 +0900 - rev 354200
Push 6892 by ryanvm@gmail.com at Tue, 14 Feb 2017 16:13:02 +0000
Bug 1318914 - Fix --with-system-libevent build against libevent 2.1. r=billm, a=jcristau
0f339c1e154f75c484fe2fac507a9a225990d212: Bug 1334047 - Remove the release assertion for docgroup keys matching until we fix the code to adhere to this (branch fix); r=billm a=jcristau FIREFOX_52_0b2_BUILD1 FIREFOX_52_0b2_RELEASE
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 27 Jan 2017 08:11:00 +0100 - rev 353947
Push 6842 by eakhgari@mozilla.com at Mon, 30 Jan 2017 14:52:52 +0000
Bug 1334047 - Remove the release assertion for docgroup keys matching until we fix the code to adhere to this (branch fix); r=billm a=jcristau
aeac5786707489d14ceed90061ba9d107662b9eb: Bug 1331685 - Ensure that the ContentChild constructor send methods return null when shutting down. r=billm, a=jcristau
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 16 Jan 2017 21:33:48 -0500 - rev 353851
Push 6826 by ryanvm@gmail.com at Wed, 25 Jan 2017 17:02:21 +0000
Bug 1331685 - Ensure that the ContentChild constructor send methods return null when shutting down. r=billm, a=jcristau Otherwise, the IPC attempt will crash the content process.
5c6671c08dbb19a4e873452d9eb1475db380bca6: Bug 1331787 - Make IPDL aborts fatal in release builds. r=billm, a=jcristau
Andrew McCreight <continuation@gmail.com> - Tue, 17 Jan 2017 15:42:30 -0800 - rev 353726
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1331787 - Make IPDL aborts fatal in release builds. r=billm, a=jcristau MozReview-Commit-ID: JSgNXtnjNxv
2eab2dda495abb9ee50f81c3d1b249eb770b9d7a: Bug 1323319 - Make sure we can force paint remote tabs even during the first activation. r=billm, a=jcristau
Mike Conley <mconley@mozilla.com> - Wed, 21 Dec 2016 16:09:09 -0500 - rev 353704
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1323319 - Make sure we can force paint remote tabs even during the first activation. r=billm, a=jcristau MozReview-Commit-ID: EV9u7M2i2sL
82ca0b8cafe57be09bcede3a195f3b4cf46f9249: Bug 1331706 - Make vsync non-prioritized for Firefox 52. r=billm, a=jcristau
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 17 Jan 2017 11:37:00 -0500 - rev 353698
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1331706 - Make vsync non-prioritized for Firefox 52. r=billm, a=jcristau
5a6e8c89b306ba8f959822c38f0b0ca3664e8b53: Bug 1330018 - Ensure we always unwrap CpowEntries. r=bholley, r=billm, a=jcristau
Andrew McCreight <continuation@gmail.com> - Fri, 13 Jan 2017 13:50:35 -0800 - rev 353688
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1330018 - Ensure we always unwrap CpowEntries. r=bholley, r=billm, a=jcristau We can drop async messages that contain CPOWs, which can cause us to leak them either until we successfully send a CPOW or forever, depending on the direction of the message. This is causing intermittent leaks until shutdown with e10s-multi. MozReview-Commit-ID: 3iIaIBZKZR2
08b67f1167751fd9cde52cd0f3da8da46e65426e: Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access. r=billm a=ritu
Kris Maglione <maglione.k@gmail.com> - Tue, 22 Nov 2016 12:31:37 -0800 - rev 352610
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access. r=billm a=ritu MozReview-Commit-ID: IS7mpOnQ8y0
6e687af3b7cb22c4f0f5fce6d08e7e266bbe191b: Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing. r=billm a=ritu
Kris Maglione <maglione.k@gmail.com> - Tue, 22 Nov 2016 12:07:59 -0800 - rev 352609
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing. r=billm a=ritu MozReview-Commit-ID: KXA7xlq8Voc
fab432069073857f66824c73353a6067fb493286: bug 1306591, add secondary event queue to let high priority messages to be processed sooner, r=billm
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 08 Nov 2016 14:05:45 +0200 - rev 351668
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
bug 1306591, add secondary event queue to let high priority messages to be processed sooner, r=billm
c04f84afb1bd6b3ea372164012735de6c8f2d582: Make it safe to close an IPC channel that has already been closed by its remote endpoint. (bug 1314816 part 2, r=billm)
David Anderson <danderson@mozilla.com> - Fri, 04 Nov 2016 18:31:30 -0700 - rev 351286
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Make it safe to close an IPC channel that has already been closed by its remote endpoint. (bug 1314816 part 2, r=billm)
97bf9717631977f76a43fadd51c99dea1df770c6: Bug 1313218 - Preload libmozsandbox.so in child processes on Linux. r=tedd r=billm r=glandium
Jed Davis <jld@mozilla.com> - Fri, 04 Nov 2016 18:16:05 -0600 - rev 351285
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313218 - Preload libmozsandbox.so in child processes on Linux. r=tedd r=billm r=glandium Preloading libmozsandbox allows the symbol interpositions used by sandboxing to be defined there instead of statically linked into the executable; this patch also does that. MozReview-Commit-ID: FL1QWLSKA0S
71ddd5bf19ecea894ab97d175b12add5cf00c68d: Bug 1313686 - Add opt-out Telemetry probe to see how long it takes for TabChild::RecvSetDocShellIsActive to paint a tab. data-review=liuche, r=billm,liuche
Mike Conley <mconley@mozilla.com> - Fri, 28 Oct 2016 11:48:24 -0400 - rev 350788
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313686 - Add opt-out Telemetry probe to see how long it takes for TabChild::RecvSetDocShellIsActive to paint a tab. data-review=liuche, r=billm,liuche MozReview-Commit-ID: 5B588cs3cJ8
36b37ea010f1baacac9513a3554c202f609a6ec9: Bug 1308920: Part 2 - Support posting messages across windows with different addonId origins. r=billm
Kris Maglione <maglione.k@gmail.com> - Tue, 01 Nov 2016 19:04:13 -0700 - rev 350751
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1308920: Part 2 - Support posting messages across windows with different addonId origins. r=billm MozReview-Commit-ID: 89TD8x5cUlZ
97147b709fd84ed5693376f14b14e8d0d452d616: Bug 1312540 - Maintain a cache of GMPs capabilities in content processes. r=billm,gerald
Chris Pearce <cpearce@mozilla.com> - Tue, 01 Nov 2016 16:25:19 +1300 - rev 350483
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1312540 - Maintain a cache of GMPs capabilities in content processes. r=billm,gerald In order to avoid doing a synchronous call from content process to chrome process in order to determine what GMPs are usable, maintain a cache of GMP capabilities in the content processes. We must seed the cache when content processes are created, as the GMP service is started up and GMPs are added to it before the first (or any subsequent) content process is created. MozReview-Commit-ID: Eb4Pu81XHmn
8b1ef926af1c77f31dd32f5112e04b9a00a098d1: Bug 1312880 - Remove sync message when starting up RemoteAddonsChild. r=billm
Mike Conley <mconley@mozilla.com> - Fri, 28 Oct 2016 10:16:00 -0400 - rev 350183
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1312880 - Remove sync message when starting up RemoteAddonsChild. r=billm MozReview-Commit-ID: LHNXZOphynk
fe339dd59a0188e201cf24498723a624f13f2146: Bug 1303196 - Part 1: Add the DocGroup and TabGroup Objects, r=billm
Michael Layzell <michael@thelayzells.com> - Thu, 06 Oct 2016 17:23:08 -0400 - rev 349905
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1303196 - Part 1: Add the DocGroup and TabGroup Objects, r=billm MozReview-Commit-ID: ILXWUlPPeHM
2a18e840e4b8ac08fffe201e678a98eb45e9f8b1: Bug 1312549 - use equality comparison rather than ordered comparison in ~GeckoChildProcessHost; r=billm
Nathan Froyd <froydnj@mozilla.com> - Tue, 25 Oct 2016 23:08:11 -0400 - rev 349486
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1312549 - use equality comparison rather than ordered comparison in ~GeckoChildProcessHost; r=billm clang has recently made |x $RELATIONAL_OP 0|, where |x| is a variable of pointer type, to be an error. On Windows, GeckoChildProcessHost::mChildProcessHandle is a HANDLE, which is really just a pointer. So the comparison |> 0| in ~GeckoChildProcessHost is invalid. Fortunately, we can use an equality comparison here and it amounts to the same thing.
4f7f541d40ec6064018b95f0f5afe9189bffcb8d: Ensure the hang monitor is enabled in the GPU process. (bug 1311716, r=billm)
David Anderson <danderson@mozilla.com> - Mon, 24 Oct 2016 01:07:54 -0700 - rev 349202
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Ensure the hang monitor is enabled in the GPU process. (bug 1311716, r=billm)
c0a8fecacb46f22d16205470dfdeb5e6aea815f8: Bug 1287007 - Fix timing issue in browser_ext_windows_create_tabId.js r=billm
Rob Wu <rob@robwu.nl> - Fri, 21 Oct 2016 01:35:03 +0200 - rev 349187
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Fix timing issue in browser_ext_windows_create_tabId.js r=billm When tabs.onUpdated is called before the promise of windows.create resolves, the test fails. This test failure was observed on almost every try run with non-e10s, and sometimes (rarely) with e10s. MozReview-Commit-ID: 3znCP1uAUSB
f10221d238ac3f5bb4e0f2a00591291d4ee4cee9: Bug 1287007 - Work-around for test failure in test_ext_cookies.html r=billm
Rob Wu <rob@robwu.nl> - Wed, 12 Oct 2016 19:13:46 +0200 - rev 349186
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Work-around for test failure in test_ext_cookies.html r=billm There is a timing-sensitive bug in window.create and/or cookies API. I haven't figured out the exact details, but created a minimal test case and reported it at bugzil.la/1309637 Without this patch, the test will fail as described in that bug report. MozReview-Commit-ID: DiJOao8h8Q7
434598e8b200a661b6a4dafb667ad9299ed92396: Bug 1287007 - Fix timing issue in browser_ext_contextMenus.js r=billm
Rob Wu <rob@robwu.nl> - Wed, 12 Oct 2016 01:10:33 +0200 - rev 349185
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Fix timing issue in browser_ext_contextMenus.js r=billm MozReview-Commit-ID: D7No2zFUWjf
3915db2d27b13a14d1647ceb5370d6cbc04582e5: Bug 1287007 - Fix timing issue in browser_ext_tabs_onUpdated.js r=billm
Rob Wu <rob@robwu.nl> - Sat, 01 Oct 2016 01:07:22 +0200 - rev 349183
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Fix timing issue in browser_ext_tabs_onUpdated.js r=billm Reload about:blank tab after opening it and registering the `tabs.onUpdated` event. This is needed because about:blank loads very fast, before the callback of `tabs.create` is invoked. This effect is amplified by the fact that the APIs are now proxied. MozReview-Commit-ID: DgPtIqHSUDx
e6a612e71387531f50d8fab977f3c6151cf2f561: Bug 1287007 - Remove contextMenusInternal.onClicked r=billm
Rob Wu <rob@robwu.nl> - Sat, 01 Oct 2016 00:46:19 +0200 - rev 349182
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Remove contextMenusInternal.onClicked r=billm contextMenusInternal.onClicked is already inlined in context_menus.json. It should be removed because otherwise the `browser.contextMenusInternal.onClicked` API would be generated. MozReview-Commit-ID: LAKd2IGM5GU
2b6e6f6614091834bcadaca619909b2a2033fa5c: Bug 1287007 - Make browser_ext_tabs_executeScript.js reliable r=billm
Rob Wu <rob@robwu.nl> - Thu, 15 Sep 2016 15:53:03 -0700 - rev 349180
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Make browser_ext_tabs_executeScript.js reliable r=billm The ProxyMessenger registers a listener whenever the first addon starts. Although the map does not have any listeners any more at the end of the test, the listener itself is not removed because the message-manager-close notification is not sent for them. So do not count these persistent message managers in the test. The actual message managers of interest are those associated with the (closed) tab. Note: When the test is run in isolation, it may still fail due to bugzil.la/1293583. See bug for work-around if you want to test. MozReview-Commit-ID: IiDHhmvQPcv
437ef72ca3543d70dd1e106830ec5fee02e03d97: Bug 1287007 - Make window.close in extension pages async r=billm
Rob Wu <rob@robwu.nl> - Tue, 13 Sep 2016 20:26:18 -0700 - rev 349179
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Make window.close in extension pages async r=billm Test coverage by tabs.onRemoved + window.close() in: toolkit/components/extensions/test/mochitest/test_ext_tab_teardown.html MozReview-Commit-ID: 7asg2XGrTaQ
919c8b9e2ab4ef7aa51f7cf91c6c738a77e592e2: Bug 1287007 - Remove .contentWindow from ProxyContext r=billm
Rob Wu <rob@robwu.nl> - Tue, 13 Sep 2016 16:02:03 -0700 - rev 349178
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Remove .contentWindow from ProxyContext r=billm MozReview-Commit-ID: ASNigrM07yz
851e08a1f368c42fcbe0f1522f22e36690dba0ae: Bug 1287007 - Enable proxying of most APIs. r=billm
Rob Wu <rob@robwu.nl> - Mon, 12 Sep 2016 21:19:53 -0700 - rev 349176
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Enable proxying of most APIs. r=billm MozReview-Commit-ID: KrI42XrsVVG
44c68913ebf56daf3aef3454c615597fef3d62b9: Bug 1287007 - Fix timing issue in test_ext_storage.js r=billm
Rob Wu <rob@robwu.nl> - Tue, 13 Sep 2016 00:45:00 -0700 - rev 349175
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Fix timing issue in test_ext_storage.js r=billm MozReview-Commit-ID: 63Ra7ThuHuf
f2f75e6e2d607e8a123e2444c2fd9fe9a4e276c8: Bug 1287007 - Fix "onclick" in contextMenus, to child. r=billm
Rob Wu <rob@robwu.nl> - Mon, 12 Sep 2016 18:26:03 -0700 - rev 349174
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Fix "onclick" in contextMenus, to child. r=billm Main thing: Making contextMenus implementation webext-oop compatible. Preparation: - Add getParentEvent to ChildAPIManager to allow use of remote events. - Introduce `addon_parent_only` to "allowedContexts" to only generate a schema API in the main process. - Do not fill in `null` for missing keys if the schema declares a key as `"optional": "omit-key-if-missing"`. This is needed for the second point in the next list. Drive-by fixes: - Ensure that the "onclick" handler is erased when a context closes. - Do not clear the "onclick" handler in `contextMenus.update` if the onclick key has been omitted (parity with Chrome). - Remove some unnecessary `Promise.resolve()` - Add extensive set of tests that check the behavior of the contextMenus APIs with regards to the onclick attribute in various scenarios. MozReview-Commit-ID: A5f3AUQzU8T
4c43afedf60f8852f0a1729123af998da103f50b: Bug 1287007 - Move part of browserAction and pageAction to child r=billm
Rob Wu <rob@robwu.nl> - Sun, 11 Sep 2016 04:18:35 -0700 - rev 349173
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Move part of browserAction and pageAction to child r=billm And remove redundant `Promise.resolve()` because it is the default for async functions. setIcon is not supported on Android, so there was no need to change mobile/android/components/extensions/ext-pageAction.js. MozReview-Commit-ID: 94ebaJFxLAi
09fa6078095c96453fb793ee97755cc3c66a986c: Bug 1287007 - Set parent cloneScope to child cloneScope r=billm
Rob Wu <rob@robwu.nl> - Sun, 11 Sep 2016 03:10:21 -0700 - rev 349172
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Set parent cloneScope to child cloneScope r=billm This is only to help with migration. This change allows all APIs to behave identical regardless of whether the API is proxied. Change cloneScope to be a getter because cloneScope is `this.contentWindow`, which may be nulled when the context navigates away (but stays in the bfcache). Any API that is not proxied must have an identical clone scope to make sure that properties such as toJSON (in the native messaging stringifier) and ArrayBuffer (in webRequest as requestBody) are visible to the caller. MozReview-Commit-ID: 9aT3SUBieHK
54c25251246826c4bca1af8208ddbb0dcb4da0b2: Bug 1287007 - Track message manager / browser swaps r=billm
Rob Wu <rob@robwu.nl> - Fri, 09 Sep 2016 23:04:04 -0700 - rev 349171
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Track message manager / browser swaps r=billm Neither the message manager nor the XUL browser is guaranteed to be constant during a ProxyContext's lifetime. Add a new class to follow the `<browser>` belonging to the current docshell and update the ProxyContext properties as needed. NOTE: The `BrowserDocshellFollower` class assumes that docshells are swapped using `newBrowser.swapDocShells(oldBrowser)`. If this assumption turns out to be false, then the tracker will lose track of the `<browser>`. See bugzil.la/1301837 for more details. Also, renamed `messageManager` to `currentMessageManager` because the `messageManager` property is overwritten by the `setContentWindow` hack in WannabeChildAPIManager in ExtensionChild.jsm. browser/components/extensions/test/browser/browser_ext_currentWindow.js provides test coverage for this feature once the `test` API goes through a ChildAPIManager instead of directly through a WannabeChildAPIManager. Why? Because that test calls `test.onMessage.addListener` in the script that is loaded in a popup page. Popups are loaded in two stages: First the content is preloaded in a `<browser>`, and then when the popup is shown a new `<browser>` is created and the docshells are swapped. When the script runs while the popup script is being preloaded, the `ParentAPIManager` receives the IPC message with the target set to the `<browser>` used for preloading. When the API response is ready, `target.messageManager.sendAsyncMessage` is called. Meanwhile the docshells have been swapped, the message manager is gone and this fails. With this patch, the message manager is correctly tracked and this test passes. MozReview-Commit-ID: C5Z0ZJRXKyw
709a07bf036212cc6f667eca11b1ae9d585c79d0: Bug 1287007 - Use frame script to initialize background/popup page r=billm
Rob Wu <rob@robwu.nl> - Thu, 08 Sep 2016 20:41:43 -0700 - rev 349170
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Use frame script to initialize background/popup page r=billm MozReview-Commit-ID: 8Di1nTnwpbU
fca5d1ec8c26491ea887e2e6f80cac8a3e32419b: Bug 1287007 - Only close extension tabs upon shutdown r=billm
Rob Wu <rob@robwu.nl> - Thu, 08 Sep 2016 19:02:56 -0700 - rev 349169
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Only close extension tabs upon shutdown r=billm In one of the previous patches, the viewType of popup changed from "popup" to "tab". As a result it was closed by the `page-shutdown` event handler in ext-tabs.js. This prevents that from happening. Also added a test that checks whether the options page type is a tab, to prevent future regressions. MozReview-Commit-ID: 3Qcf08PgNqb
817299c12d6d608a2e5c6a2badc2f952414e43ab: Bug 1287007 - Set the principal in ChildAPIManager r=billm
Rob Wu <rob@robwu.nl> - Wed, 07 Sep 2016 20:35:39 -0700 - rev 349168
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1287007 - Set the principal in ChildAPIManager r=billm The `browser.downloads.download` API takes a "url" parameter. The schema file at downloads.json defines the type to be "url". This means that the parameter is checked with `context.checkLoadURL(url)` in Schemas.jsm. This method uses the principal of the object that was passed to `Schemas.inject`. Currently, this works just fine because the `schemaWrapper` in Extension.jsm returns the context's principal. But when we move to using the ChildAPIManager, the principal is not defined and Schemas.jsm will fall back to a Null principal. As a result, the test_ext_downloads_download.js fails because the blob:-URL with the extension origin cannot be loaded by a null principal. To fix this, the context's principal must be set. MozReview-Commit-ID: FmpqYfPemyY