0ddd1de392d811da6cf3497a42f2b833e53c093e: Bug 1291110 Part 2 - Rename availableSpaceHeight to availableSpaceBSize. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Nov 2016 13:42:14 +0800 - rev 351906
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1291110 Part 2 - Rename availableSpaceHeight to availableSpaceBSize. r=dbaron Rename to make the variable name consistent with the writing-mode terminology used in PlaceLine(). MozReview-Commit-ID: AvhwHyHz7hV
0bc5e1c941a21a32668adae737030887a7865fba: Bug 1291110 Part 1 - Fix log and comment related to float. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 22 Aug 2016 19:41:53 +0800 - rev 351905
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1291110 Part 1 - Fix log and comment related to float. r=dbaron MozReview-Commit-ID: ICUflMUOsD2
d2192fd7bf45180fce623528e0d81d93a0657b74: Bug 1316408 - Remove all b2g related code from testing/xpcshell, r=jmaher
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 09 Nov 2016 14:50:45 -0500 - rev 351904
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316408 - Remove all b2g related code from testing/xpcshell, r=jmaher MozReview-Commit-ID: KF5Pw5WBleX
f6f28be8d8f25ff7ed865a0e8cfd11e36334e3cc: Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
Jared Wein <jwein@mozilla.com> - Mon, 07 Nov 2016 22:34:25 -0500 - rev 351903
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop MozReview-Commit-ID: DnpVQRrG9Ec
60bf1293eabf295bef0dd400ebde9668af3bd9ae: Bug 1316205: P3. Remove WaveDecoder::IsEnable(). r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 10 Nov 2016 11:53:07 +1100 - rev 351902
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316205: P3. Remove WaveDecoder::IsEnable(). r=gerald It would always return true, and there's already a MediaDecoder::IsWaveEnabled() MozReview-Commit-ID: 6FXgMRMnVb9
133477f27fe6a4aa490cded021cbcb5dd025793d: Bug 1316205: P2. Remove wave duplicated code. r=kaku
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 09 Nov 2016 13:08:56 +1100 - rev 351901
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316205: P2. Remove wave duplicated code. r=kaku MozReview-Commit-ID: 5s7eeMa9DU9
c61363a3c27106bc7f27929969d87348d84b591e: Bug 1316205: P1. Remove unused WaveReader. r=kaku
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 09 Nov 2016 12:52:53 +1100 - rev 351900
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316205: P1. Remove unused WaveReader. r=kaku MozReview-Commit-ID: 6pMFt9jrFED
87e4efe2210fcf79a4731cf7da59327b011147ef: Bug 1313632: P2. Cleaner Ogg related headers. r=kaku
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 09 Nov 2016 12:19:06 +1100 - rev 351899
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313632: P2. Cleaner Ogg related headers. r=kaku MozReview-Commit-ID: DpnezpZw27H
864ab5efde71487c27619d175978818b37c1ac74: Bug 1313632: P1. Remove unused OggReader. r=kaku
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 09 Nov 2016 11:54:41 +1100 - rev 351898
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1313632: P1. Remove unused OggReader. r=kaku Also remove related preference. MozReview-Commit-ID: D5pkyPXAoG9
8ffd0e45ac580a8d0a85d603e5395297b5f2d9d3: Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop
Jared Wein <jwein@mozilla.com> - Tue, 08 Nov 2016 15:14:19 -0500 - rev 351897
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop MozReview-Commit-ID: 2Xuj5nxuQdO
b737f14975c2a83bf6c3753528641e0f51745778: Bug 1316040 - Change target to non-target in test_caret_not_appear_when_typing_in_scrollable_content. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Wed, 09 Nov 2016 14:14:53 +0800 - rev 351896
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316040 - Change target to non-target in test_caret_not_appear_when_typing_in_scrollable_content. r=mtseng In this test, we assume the caret does not appear at the end of the input. However in this case, self.actions.flick() will select all text within the input, and then send_keys() will replace it with '!'. As a result, the final content might varies on different platforms. Test the final content match tho target_content might not be reliable. To fix this, we instead assert that final content does *not* match the non_target_content as the bug occurs. MozReview-Commit-ID: 2YRN8W3PUXG
fb579bc49c2f153e61cf06b34bcd6a03a409e6c4: Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:32:28 +0900 - rev 351895
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
53f988e1c1fd34ca2ff5f42a59fa05b4a768a1e5: Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:22:17 +0900 - rev 351894
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester The current state of python configure sandbox execution is that if a template imports a module, and a function defined in the template tries to use the module, it doesn't work. Ideally, it would, but rather than try to fix this corner case, we remove the unit tests that assume it works (and consequently pass for half bad reasons), and add a unit test so that the behavior doesn't change unwillingly.
30d3890fca9847a283859a53043277713b7eadab: Bug 1316206 - Make RefPtr(decltype(nullptr)) MOZ_IMPLICIT - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Tue, 08 Nov 2016 15:12:33 +1100 - rev 351893
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316206 - Make RefPtr(decltype(nullptr)) MOZ_IMPLICIT - r=froydnj Making this constructor non-explicit will permit automatic conversions from 'nullptr' into RefPtr types, which I think are not dangerous. The one spot that this affects is in 'UserDataType nsBaseHashtable::Get(KeyType)', which does a 'return 0;' into the UserDataType, which could be a bool, an int, a RefPtr or other. I'm changing that into a C++11 "value initialization", which falls back to "zero initialization" for PODs: 'return UserDataType{};'. Also fixed the comment to clarify not-found return values, as Get(KeyType) was not only used for pointers anyway. MozReview-Commit-ID: F41VlvTNOZU
9380a01deaf545a1ef339caaf15ffb951c158681: Bug 1316206 - Fix RefPtr assignments from 0 - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Tue, 08 Nov 2016 14:34:06 +1100 - rev 351892
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316206 - Fix RefPtr assignments from 0 - r=froydnj Giving '0' (literal zero) to RefPtr is now ambiguous, as both RefPtr(decltype(nullptr)) and RefPtr(T*) could be used. In any case, our coding standards mandate the use of 'nullptr' for pointers. So I'm changing all zeroes into nullptr's where necessary. MozReview-Commit-ID: A458A4e9for
d78a1d9f6a4a82a3f134c095ead3d6ecf95ec204: Bug 1316206 - RefPtr construction/assignment from nullptr - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Thu, 10 Nov 2016 07:58:10 +1100 - rev 351891
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316206 - RefPtr construction/assignment from nullptr - r=froydnj Added constructor and operator= from a nullptr, bypassing the incoming pointer check. Note that the constructor is 'explicit', because one particular use in nsBaseHashtable is doing a 'return 0' into a templated type that is a RefPtr in many cases. Making this new constructor explicit removes it from consideration in this case. As it's not strictly necessary to have it MOZ_IMPLICIT (but could still be nice), I will tackle that in the patch after next. Also changed all zeroes into nullptr when relevant in RefPtr.h (other system- wide affected files will be updated in following patch.) MozReview-Commit-ID: Ds4CEv9hZWI
2635cff0413bd1d4c6b0be57b579aa41393ad1ab: bug 1316165 ensure xcb_get_input_focus_reply is called to avoid leaking the reply r=lsalzman
Karl Tomlinson <karlt+@karlt.net> - Wed, 09 Nov 2016 08:56:27 +1300 - rev 351890
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
bug 1316165 ensure xcb_get_input_focus_reply is called to avoid leaking the reply r=lsalzman MozReview-Commit-ID: JPi0TeKVCB5
2ab7ed6880d3e0f973d1209ba4f1639f6f89d00f: Bug 1315675 - Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 08 Nov 2016 14:08:52 +0000 - rev 351889
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1315675 - Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches. r=mak MozReview-Commit-ID: HgLy6Dis0jU
a9d136b32432b84504635fc93a52e22b9f61c377: Bug 1316287 - Remove test_history_redirects.js as it doesn't actually test anything. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 09 Nov 2016 11:42:37 +0000 - rev 351888
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316287 - Remove test_history_redirects.js as it doesn't actually test anything. r=mak MozReview-Commit-ID: GkX9yjsXk9G
a87aea7bdeda45126ad8306f2df47a694b052780: Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html r=dholbert
Neerja Pancholi <npancholi@mozilla.com> - Wed, 09 Nov 2016 13:15:27 -0800 - rev 351887
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html r=dholbert MozReview-Commit-ID: 47XhcgMrOu6
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip