searching for reviewer(spohl)
b6ffa501bd27ad6f6d5a78d5ef92e116d241fedd: Bug 1257765 - Limit the length of notification strings to 5000 characters. r=spohl , a=ritu
Josh Aas <joshmoz@fastmail.com> - Tue, 05 Jul 2016 16:41:00 +0200 - rev 312140
Push 178 by cbook@mozilla.com at Tue, 05 Jul 2016 14:41:18 +0000
Bug 1257765 - Limit the length of notification strings to 5000 characters. r=spohl , a=ritu
5aecc34603af791fdb1ab1806f7d70a082c5178b: Bug 1187613 - Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK. r=spohl a=sylvestre
Steven Michaud <smichaud@pobox.com> - Wed, 09 Sep 2015 17:07:29 -0500 - rev 311607
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1187613 - Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK. r=spohl a=sylvestre
4bfd19d00ed4eaa9cf0bbd1d9a3fd3f817c40195: Bug 1165135 - Distribution directory not removed on pave over install. r=spohl, a=sledru
Robert Strong <robert.bugzilla@gmail.com> - Fri, 15 May 2015 10:36:09 -0700 - rev 311432
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1165135 - Distribution directory not removed on pave over install. r=spohl, a=sledru
b7ba1695d4945b13f4de7a60d374e2ea8c92ba55: Bug 1234355 - Part 1: Remove "Don't ask me again" footgun option from the "Enable DRM" info bar notification. r=spohl a=lizzard
Chris Peterson <cpeterson@mozilla.com> - Fri, 22 Jan 2016 20:57:09 -0800 - rev 311097
Bug 1234355 - Part 1: Remove "Don't ask me again" footgun option from the "Enable DRM" info bar notification. r=spohl a=lizzard
8e913ace1e198c34423bfadc807296f6400078bd: Bug 1230857 - Make GMPInstallManager enforce sensible permissions on GMP files at install time. r=spohl, a=sylvestre
Chris Pearce <cpearce@mozilla.com> - Thu, 14 Jan 2016 15:16:06 +1300 - rev 310923
Bug 1230857 - Make GMPInstallManager enforce sensible permissions on GMP files at install time. r=spohl, a=sylvestre This ensures that GMP packages with bad permissions will still be usable. For example, a GMP without execute/read permissions in its zip won't work without this.
8fa1bffbfeafb3ab9c9a9693896cb638d19440fb: Bug 1225137 - Avoid crash on some platforms if scrollbar fading is enabled and the duration is set to zero. r=spohl
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 16 Nov 2015 10:44:45 -0500 - rev 306899
Bug 1225137 - Avoid crash on some platforms if scrollbar fading is enabled and the duration is set to zero. r=spohl
c4dd82aa903d89b3835ceb38cf0341a4190c383e: Bug 1221449: Add null ptr check and fix variable shadowing in OSXNotificationCenter.mm. r=spohl
Josh Aas <joshmoz@fastmail.com> - Sat, 07 Nov 2015 18:23:00 +0900 - rev 305790
Bug 1221449: Add null ptr check and fix variable shadowing in OSXNotificationCenter.mm. r=spohl
1f83c66c4cb951d5ae012de6b01d9a4ba50df2fc: Bug 1221451: Don't pass nil when an argument is required. r=spohl
Josh Aas <joshmoz@fastmail.com> - Fri, 06 Nov 2015 10:24:19 +0900 - rev 305582
Bug 1221451: Don't pass nil when an argument is required. r=spohl
a14abc3d5087398ec699b5e850824275ee8d5c17: Bug 1220358 - Fix -Wunreachable-code warnings in widget/cocoa. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Fri, 30 Oct 2015 18:22:55 -0700 - rev 305020
Bug 1220358 - Fix -Wunreachable-code warnings in widget/cocoa. r=spohl widget/cocoa/nsNativeThemeCocoa.mm:3774:7 [-Wunreachable-code-break] 'break' will never be executed widget/cocoa/nsNativeThemeCocoa.mm:3790:7 [-Wunreachable-code-break] 'break' will never be executed widget/cocoa/nsNativeThemeCocoa.mm:3818:5 [-Wunreachable-code-break] 'break' will never be executed
874761c630c2d02abff6bd179985ce81b9ce64a9: Bug 1216575 - [mozbuild] Remove if statement that sets bindir to resource dir on osx, r=spohl
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 21 Oct 2015 10:04:21 -0400 - rev 302173
Bug 1216575 - [mozbuild] Remove if statement that sets bindir to resource dir on osx, r=spohl
1117b2bc65c2fd5e601d8a50114dd6e562c4a601: Bug 1216416 - Fix -Wimplicit-fallthrough warnings in widget/cocoa. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Tue, 06 Oct 2015 21:03:59 -0700 - rev 302129
Bug 1216416 - Fix -Wimplicit-fallthrough warnings in widget/cocoa. r=spohl widget/cocoa/nsChildView.mm:1664:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels widget/cocoa/nsChildView.mm:1761:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels widget/cocoa/nsNativeThemeCocoa.mm:3700:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
be03da7901730224a81ed2f058ff5dd8b2a5dabd: Bug 1192924: Split out add-on update.xml parsing code from GMP modules. r=spohl
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 08 Sep 2015 15:00:28 -0700 - rev 297464
Bug 1192924: Split out add-on update.xml parsing code from GMP modules. r=spohl The system add-on update checks will use the same update.xml format as GMP so this splits out the code for parsing and downloading files into a standalone module that both can reuse.
ab8764ec9c2e46308b17c822bb6116579738d087: Bug 1204398 - Fix -Wshadow warnings in widget/cocoa. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Fri, 11 Sep 2015 20:32:37 -0700 - rev 297352
Bug 1204398 - Fix -Wshadow warnings in widget/cocoa. r=spohl
a6860f880e01572924f05421adf26bee06a72cb4: Bug 1192924: Split out add-on update.xml parsing code from GMP modules. r=spohl
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 08 Sep 2015 15:00:28 -0700 - rev 297122
Bug 1192924: Split out add-on update.xml parsing code from GMP modules. r=spohl The system add-on update checks will use the same update.xml format as GMP so this splits out the code for parsing and downloading files into a standalone module that both can reuse.
9d8c4abf0417ac64b8cb83d6ce5d05cd24aeb22e: Bug 1206766 - Show meaningful module offsets in stack traces even when no symbol found. r=spohl
Steven Michaud <smichaud@pobox.com> - Mon, 21 Sep 2015 14:20:35 -0500 - rev 297033
Bug 1206766 - Show meaningful module offsets in stack traces even when no symbol found. r=spohl
2cbe7dae98c5061f822c1523cf7aefb2545e5f3f: Bug 1205178 - Make GMPProvider check that GMPs are the right arch before loading. r=spohl
Chris Pearce <cpearce@mozilla.com> - Thu, 17 Sep 2015 13:28:48 +1200 - rev 295552
Bug 1205178 - Make GMPProvider check that GMPs are the right arch before loading. r=spohl
8a316d4c6458cfda9ef83b9d0aa0feea44a0adff: Bug 1204170 - Fix icns file for b2g graphene builds. r=spohl
Brian R. Bondy <netzen@gmail.com> - Sat, 12 Sep 2015 14:11:46 -0400 - rev 294806
Bug 1204170 - Fix icns file for b2g graphene builds. r=spohl
9dc18f7a238f8636c0a08ac1faff3e07e869f543: Bug 1187613 - Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK. r=spohl
Steven Michaud <smichaud@pobox.com> - Wed, 09 Sep 2015 17:07:29 -0500 - rev 294262
Bug 1187613 - Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK. r=spohl
8f87021133f713936d22362ed81db80e48640dc4: Bug 1201672 - Package more files for B2G desktop on OS X. r=spohl
J. Ryan Stinnett <jryans@gmail.com> - Thu, 03 Sep 2015 15:15:36 -0500 - rev 293592
Bug 1201672 - Package more files for B2G desktop on OS X. r=spohl
10592387dea48e4495fd0ad970ad5e859829620e: Bug 1131473 - crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl
Steven Michaud <smichaud@pobox.com> - Thu, 27 Aug 2015 15:54:15 -0500 - rev 292296
Bug 1131473 - crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl
053d760eb1cf9fd1b7c93f42188b57c985dceb67: Bug 1193227 - Exclude tests from Mac B2G / Mulet packages. r=spohl
J. Ryan Stinnett <jryans@gmail.com> - Wed, 26 Aug 2015 17:35:00 -0400 - rev 292292
Bug 1193227 - Exclude tests from Mac B2G / Mulet packages. r=spohl
55bea2798c68e18837b1c3a6bf3503f721f00c08: Bug 1131473 - crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl
Steven Michaud <smichaud@pobox.com> - Thu, 27 Aug 2015 12:01:56 -0500 - rev 292282
Bug 1131473 - crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl
cf3c8f3091346a0d08184bbfae9011350afcf46c: Bug 1181977 - Firefox app menu contains only "Quit" in certain edgecases. r=spohl
Steven Michaud <smichaud@pobox.com> - Mon, 24 Aug 2015 10:57:02 -0500 - rev 291655
Bug 1181977 - Firefox app menu contains only "Quit" in certain edgecases. r=spohl
662ef65e5017b79b2c0ea3dc32e093d8359885b7: Bug 862173 - don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O). r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Thu, 20 Aug 2015 10:05:05 -0700 - rev 291196
Bug 862173 - don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O). r=spohl
66bf3e9e71d4d1730c15bbdd0448b91c8c1a15b8: Bug 1177861 - remove remaining unused declarations and cleanup update staging. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Tue, 11 Aug 2015 14:30:35 -0700 - rev 289944
Bug 1177861 - remove remaining unused declarations and cleanup update staging. r=spohl
d03bf9e14763ebbb5df611e2bd121815e6b71870: Bug 1187613 - Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK. r=spohl a=sylvestre
Steven Michaud <smichaud@pobox.com> - Wed, 09 Sep 2015 17:07:29 -0500 - rev 289649
Bug 1187613 - Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK. r=spohl a=sylvestre
7a794d1f6b44a866241b11cf6f3921d450f4c4c8: Bug 1205178 - Make GMPProvider check that GMPs are the right arch before loading. r=spohl,a=sylvestre
Chris Pearce <cpearce@mozilla.com> - Thu, 17 Sep 2015 13:28:48 +1200 - rev 289373
Bug 1205178 - Make GMPProvider check that GMPs are the right arch before loading. r=spohl,a=sylvestre
fecd7b5233da677992ad6989d6cab5db6e4d8c69: Bug 1131473 - Crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl, a=ritu
Steven Michaud <smichaud@pobox.com> - Thu, 27 Aug 2015 15:54:15 -0500 - rev 289068
Bug 1131473 - Crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl, a=ritu
b1cb1d513a8549128d3be223764871d2425eee6a: Bug 1177861 - Remove remaining unused declarations and cleanup update staging. r=spohl, a=ritu
Robert Strong <robert.bugzilla@gmail.com> - Tue, 11 Aug 2015 14:30:35 -0700 - rev 288892
Bug 1177861 - Remove remaining unused declarations and cleanup update staging. r=spohl, a=ritu
da2876c5f5acbc86183aaa64e1b11f6c0a6b6cc5: Bug 1188425 - Add a pref to allow insecure text input, thereby avoiding crashes at [ChildView keyDown:] in non-release builds. r=spohl
Steven Michaud <smichaud@pobox.com> - Wed, 29 Jul 2015 16:31:14 -0500 - rev 286993
Bug 1188425 - Add a pref to allow insecure text input, thereby avoiding crashes at [ChildView keyDown:] in non-release builds. r=spohl
63c709f71ce30f2c892b30be39b516cd5561efdb: Bug 1186158 - Receive notifications of sandbox violations in the browser on OS X. r=spohl
Steven Michaud <smichaud@pobox.com> - Tue, 28 Jul 2015 15:19:55 -0500 - rev 286710
Bug 1186158 - Receive notifications of sandbox violations in the browser on OS X. r=spohl
4fd14cf6b4154051f65bdaff453bc07ecadafeb5: Bug 1186158 - Receive notifications of sandbox violations in the browser on OS X. r=spohl
Steven Michaud <smichaud@pobox.com> - Mon, 27 Jul 2015 13:56:08 -0500 - rev 286501
Bug 1186158 - Receive notifications of sandbox violations in the browser on OS X. r=spohl
edb7fc17176fcf7dc85eeb6e79dc9f573727b8ea: Bug 1174565 - [EME] Report telemetry about which GMP files are missing - r=cpearce,spohl
Gerald Squelart <gsquelart@mozilla.com> - Thu, 02 Jul 2015 10:12:49 +1000 - rev 282942
Bug 1174565 - [EME] Report telemetry about which GMP files are missing - r=cpearce,spohl * * * Bug 1174565 - [EME] Updated xpcshell test - r=cpearce,spohl
39a2abd5d26c8f0a1537d0a190b79d616362bd72: Bug 1178984 - Crashes at nsMenuBarX::RemoveMenuAtIndex. r=spohl
Steven Michaud <smichaud@pobox.com> - Wed, 01 Jul 2015 14:28:05 -0500 - rev 282665
Bug 1178984 - Crashes at nsMenuBarX::RemoveMenuAtIndex. r=spohl
c8b342e749014f9c0845bdba732d8fa9df6e145e: Bug 1131473 - Crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl, a=ritu
Steven Michaud <smichaud@pobox.com> - Thu, 27 Aug 2015 15:54:15 -0500 - rev 282150
Bug 1131473 - Crash in -[NativeMenuItemTarget menuItemHit:]. r=spohl, a=ritu
447736aa246bb69ec461b11e54ecd4b6774a1aeb: Bug 1177861 - remove remaining unused declarations and cleanup update staging. r=spohl, a=rkothari
Robert Strong <robert.bugzilla@gmail.com> - Tue, 25 Aug 2015 18:07:00 -0700 - rev 282024
Bug 1177861 - remove remaining unused declarations and cleanup update staging. r=spohl, a=rkothari
5c14f816e9da87ffc07dbaf80147d6af1ff8ea9c: Bug 1188425 - Add a pref to allow insecure text input, thereby avoiding crashes at [ChildView keyDown:] in non-release builds. r=spohl a=rkothari
Steven Michaud <smichaud@pobox.com> - Tue, 04 Aug 2015 15:27:10 -0500 - rev 281796
Bug 1188425 - Add a pref to allow insecure text input, thereby avoiding crashes at [ChildView keyDown:] in non-release builds. r=spohl a=rkothari
702fa333520f63f722f1f09a726d2b50a15671b0: Bug 1178984 - Crashes at nsMenuBarX::RemoveMenuAtIndex. r=spohl, a=lmandel
Steven Michaud <smichaud@pobox.com> - Wed, 01 Jul 2015 14:28:05 -0500 - rev 281382
Bug 1178984 - Crashes at nsMenuBarX::RemoveMenuAtIndex. r=spohl, a=lmandel
9c45565cdccc03a06be779fa31f219337732ceed: Bug 1175006 - Reset state so we re-try creating a trial GMPVideoDecoder whenever Firefox updates. r=spohl
Chris Pearce <cpearce@mozilla.com> - Wed, 17 Jun 2015 11:00:42 +1200 - rev 280030
Bug 1175006 - Reset state so we re-try creating a trial GMPVideoDecoder whenever Firefox updates. r=spohl
51056edec2f3ac5736c722237d42d2aacd184d01: Bug 1171792 - An update is attempted from an update notification when it is not possible to update. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Mon, 08 Jun 2015 13:11:43 -0700 - rev 278696
Bug 1171792 - An update is attempted from an update notification when it is not possible to update. r=spohl
f514cab5623b41a7aa6430234a9a2f0357bef256: Bug 1169129 - reset media.{0}.trial-create on GMP install. r=spohl
Chris Pearce <cpearce@mozilla.com> - Fri, 05 Jun 2015 21:55:52 +1200 - rev 278146
Bug 1169129 - reset media.{0}.trial-create on GMP install. r=spohl
feb054f75ff2f308814161a82caf9b9c19479264: Bug 1150688 - Update sections of GMPInstallManager.jsm, which were copied from nsUpdateService.js, to reflect the changes to nsUpdateService.js from bug 1149334. r=spohl
Vijendra Singh <vijendrasingh161@gmail.com> - Thu, 04 Jun 2015 17:21:17 -0700 - rev 278033
Bug 1150688 - Update sections of GMPInstallManager.jsm, which were copied from nsUpdateService.js, to reflect the changes to nsUpdateService.js from bug 1149334. r=spohl
e2c4ccb516bd516b22ccf17badf35da812eac729: Bug 1168720 - Remove use of test env var MOZ_NO_REPLACE_FALLBACK and associated tests that are covered by other tests. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Thu, 04 Jun 2015 09:20:00 -0700 - rev 277973
Bug 1168720 - Remove use of test env var MOZ_NO_REPLACE_FALLBACK and associated tests that are covered by other tests. r=spohl
9b110d0cbbf605497bca4c72989c5da6e349269c: Bug 1165061 - Fix Intermittent test_0102_background_restartNotification_staging.xul by not copying app files when staging for tests and enable the tests for Linux and Mac. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Wed, 03 Jun 2015 11:29:51 -0700 - rev 277897
Bug 1165061 - Fix Intermittent test_0102_background_restartNotification_staging.xul by not copying app files when staging for tests and enable the tests for Linux and Mac. r=spohl
0c9e32f0a414336522a7d5291b609d9a382e2961: Bug 1151345 - Firefox app menu sometimes contains only "Quit" on OS X. r=spohl
Steven Michaud <smichaud@pobox.com> - Wed, 03 Jun 2015 16:19:51 -0500 - rev 277834
Bug 1151345 - Firefox app menu sometimes contains only "Quit" on OS X. r=spohl
feef553c3dae9d99b77633da133748c79273233a: Bug 1168489 - Combine XPCSHELL_TESTS_MANIFESTS entries in moz.build. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Tue, 02 Jun 2015 12:17:45 -0700 - rev 277448
Bug 1168489 - Combine XPCSHELL_TESTS_MANIFESTS entries in moz.build. r=spohl
23410ef11a4af7c954fa957a478672d5ec19358e: Bug 1168009 - heap-use-after-free (ASAN build) in updater.cpp mstrtok. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Mon, 01 Jun 2015 11:52:08 -0700 - rev 277300
Bug 1168009 - heap-use-after-free (ASAN build) in updater.cpp mstrtok. r=spohl
d39ba5b549c53efa063b966361969a8343d501d7: Bug 1165061 - prevent test timeouts by not copying files when staging an update in mochitest-chrome tests. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Wed, 20 May 2015 13:34:29 -0700 - rev 275639
Bug 1165061 - prevent test timeouts by not copying files when staging an update in mochitest-chrome tests. r=spohl
3950e0f5253283f22b60b1925cd6fc322835b443: Bug 1154876 - Block calls to hooked methods off the plugin thread. r=spohl
Steven Michaud <smichaud@pobox.com> - Tue, 19 May 2015 20:56:34 -0500 - rev 275461
Bug 1154876 - Block calls to hooked methods off the plugin thread. r=spohl
4f55489df935494682d012d5d4d1e4f7dd064904: Bug 1165156 - Remove the removal of the java console extension that are seldom seen from the installer. r=spohl
Robert Strong <robert.bugzilla@gmail.com> - Fri, 15 May 2015 12:56:59 -0700 - rev 274936
Bug 1165156 - Remove the removal of the java console extension that are seldom seen from the installer. r=spohl