searching for reviewer(smaug)
6172686bf59c0263ef1789d76bd563cc9a53f9a6: Bug 1343642 - Ensure to grab nsFrameSelection before calling its methods unless calling only const methods. r=smaug, a=abillings
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 06 Apr 2017 12:50:40 +0900 - rev 312868
Push 517 by ryanvm@gmail.com at Fri, 07 Apr 2017 21:09:07 +0000
Bug 1343642 - Ensure to grab nsFrameSelection before calling its methods unless calling only const methods. r=smaug, a=abillings
dcf468969700d19536a34f59efccbcce69b10757: Bug 1343795 - Hold a strong ref on the Selection while calling ScrollIntoView with SCROLL_DO_FLUSH. r=smaug, a=jcristau
Mats Palmgren <mats@mozilla.com> - Tue, 21 Mar 2017 02:12:41 +0100 - rev 312811
Push 490 by ryanvm@gmail.com at Fri, 24 Mar 2017 21:40:19 +0000
Bug 1343795 - Hold a strong ref on the Selection while calling ScrollIntoView with SCROLL_DO_FLUSH. r=smaug, a=jcristau MozReview-Commit-ID: 5C10dmT0bI9
4ae2261bfab034c759cdc1137b7b74b977ac5a40: Bug 1347979 - Don't call methods that may flush in nsRange::GetInnerTextNoFlush. r=smaug, a=jcristau
Mats Palmgren <mats@mozilla.com> - Sat, 18 Mar 2017 18:44:27 +0100 - rev 312810
Push 490 by ryanvm@gmail.com at Fri, 24 Mar 2017 21:40:19 +0000
Bug 1347979 - Don't call methods that may flush in nsRange::GetInnerTextNoFlush. r=smaug, a=jcristau MozReview-Commit-ID: AsnRqTH4FkM
e5083d8a855a12f5f35e824573748fad71fa6693: Bug 1341137 - Backport nsISelection::AsSelection() to fix bustage. r=smaug, a=bustage FIREFOX_45_8_0esr_BUILD2 FIREFOX_45_8_0esr_RELEASE
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 17 Jun 2016 16:16:10 +0900 - rev 312738
Push 455 by ryanvm@gmail.com at Thu, 02 Mar 2017 02:16:44 +0000
Bug 1341137 - Backport nsISelection::AsSelection() to fix bustage. r=smaug, a=bustage This patch adds nsISelection::AsSelection() for safer "upcast". MozReview-Commit-ID: LlxoMaU0oE
9aebee8b8cb99d8c0c27b810f3e492a92b6b3e63: Bug 1341137 - Part 2: Provide a way to add ranges to Selection objects that aren't associated with a shell/nsFrameSelection. r=smaug, a=gchang
Mats Palmgren <mats@mozilla.com> - Sat, 25 Feb 2017 11:33:34 +0100 - rev 312735
Push 454 by ryanvm@gmail.com at Wed, 01 Mar 2017 23:02:43 +0000
Bug 1341137 - Part 2: Provide a way to add ranges to Selection objects that aren't associated with a shell/nsFrameSelection. r=smaug, a=gchang
e86e0423dad14ab7044ab37e47d6734abf00105c: Bug 1341137 - Part 1: Make Selection::addRange silently reject ranges that have a different root. r=smaug, a=gchang
Mats Palmgren <mats@mozilla.com> - Sat, 25 Feb 2017 11:33:34 +0100 - rev 312734
Push 454 by ryanvm@gmail.com at Wed, 01 Mar 2017 23:02:43 +0000
Bug 1341137 - Part 1: Make Selection::addRange silently reject ranges that have a different root. r=smaug, a=gchang
556dd9e4a9e32849b7c824ce7eba2bf2633b99bb: Bug 1340138. r=smaug, a=gchang
Mats Palmgren <mats@mozilla.com> - Tue, 28 Feb 2017 16:41:08 +0100 - rev 312733
Push 454 by ryanvm@gmail.com at Wed, 01 Mar 2017 23:02:43 +0000
Bug 1340138. r=smaug, a=gchang MozReview-Commit-ID: HoTn7hfCiSC
c38f8546be5f67f829ebd9d9b6eb0ddad81f6a41: Bug 1328861 - Be a little less trusting about our error codes in ErrorResult. r=smaug, a=gchang
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 10 Feb 2017 23:06:34 -0500 - rev 312672
Push 424 by ryanvm@gmail.com at Mon, 13 Feb 2017 18:33:26 +0000
Bug 1328861 - Be a little less trusting about our error codes in ErrorResult. r=smaug, a=gchang
910ad552cbf529656161b68f394a205216754f06: Bug 1329403 - Ensure onload blocker is added once mScriptGlobalObject is set. r=smaug, a=lizzard FIREFOX_45_7_0esr_BUILD1 FIREFOX_45_7_0esr_RELEASE
JW Wang <jwwang@mozilla.com> - Mon, 16 Jan 2017 17:12:33 +0800 - rev 312600
Push 390 by ryanvm@gmail.com at Wed, 18 Jan 2017 20:34:37 +0000
Bug 1329403 - Ensure onload blocker is added once mScriptGlobalObject is set. r=smaug, a=lizzard MozReview-Commit-ID: KREnly28m0v
0fc43af8982eeba01c92262e9fb3a35144871560: Bug 1312609. r=smaug, a=gchang
Timothy Nikkel <tnikkel@gmail.com> - Tue, 29 Nov 2016 15:15:35 -0600 - rev 312423
Push 303 by ryanvm@gmail.com at Wed, 30 Nov 2016 23:48:05 +0000
Bug 1312609. r=smaug, a=gchang
576f1725a57e14f2d570e6745f88161fe92090bc: Bug 1299686 - Fix crash in nsScriptLoader.cpp. r=smaug, a=ritu
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 22 Sep 2016 16:58:46 -0400 - rev 312233
Push 229 by ryanvm@gmail.com at Wed, 05 Oct 2016 22:15:47 +0000
Bug 1299686 - Fix crash in nsScriptLoader.cpp. r=smaug, a=ritu
fc818ab03f157dc836a17fde60aa90310045e7fe: Bug 1287721 - Keep strong pointers for nodes in the invalidation list of a document accessible. r=smaug a=sylvestre
Alexander Surkov <surkov.alexander@gmail.com> - Wed, 24 Aug 2016 22:16:45 -0400 - rev 312209
Push 216 by cbook@mozilla.com at Mon, 05 Sep 2016 14:25:11 +0000
Bug 1287721 - Keep strong pointers for nodes in the invalidation list of a document accessible. r=smaug a=sylvestre
6b17b640955d2644154862d247acda23bcbd8cc5: Bug 1287760 - "Comment out AddEventListenerOptions.once". r=smaug, a=sylvestre
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 19 Jul 2016 07:03:00 +0200 - rev 312159
Push 194 by cbook@mozilla.com at Mon, 25 Jul 2016 11:54:52 +0000
Bug 1287760 - "Comment out AddEventListenerOptions.once". r=smaug, a=sylvestre
a3fff31b8b70dfae487b7a360bfd6ee77c2fe3d9: Bug 1261933 - Continue unlocking pointer even if the widget has gone. r=smaug a=lizzard
Xidorn Quan <quanxunzhen@gmail.com> - Thu, 14 Apr 2016 17:38:13 +1000 - rev 312091
Push 154 by kwierso@gmail.com at Wed, 01 Jun 2016 22:49:23 +0000
Bug 1261933 - Continue unlocking pointer even if the widget has gone. r=smaug a=lizzard MozReview-Commit-ID: 1siQhemFf9O
02df988a56aec832631463de58cd52f3a8f7c007: Bug 1266194 - Implement boolean or EventListenerOptions as 3rd param to addEventListener, r=smaug a=sylvestre
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 26 May 2016 10:06:15 -0700 - rev 312066
Push 140 by kwierso@gmail.com at Thu, 26 May 2016 17:07:22 +0000
Bug 1266194 - Implement boolean or EventListenerOptions as 3rd param to addEventListener, r=smaug a=sylvestre
4ed86d63c09a98741da02a33c178cf9a696c8538: Bug 1258576 - Part 1: nsContentIterator should give up to find next/previous node if it reached the root node unexpectedly. r=smaug, a=rkent THUNDERBIRD_45_VERBRANCH
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 31 Mar 2016 15:00:50 +0900 - rev 312050
Push 132 by kent@caspia.com at Tue, 17 May 2016 16:06:34 +0000
Bug 1258576 - Part 1: nsContentIterator should give up to find next/previous node if it reached the root node unexpectedly. r=smaug, a=rkent nsContentIterator isn't designed as working fine with a tree whose some nodes are being removed. In such case, NextNode() and PrevNode() meets orphan node (i.e., a node whose parent is nullptr). Then, nsContentIterator should mark it as "done". However, it should keep crashing if it's debug build for detecting bugs explicitly. MozReview-Commit-ID: 81ZQgoHD67T
cc9d03146a3992fa43c58559c698283710906020: Bug 1255735 - "Firefox 45 does not send content-type in empty input[type=file] anymore". r=smaug, a=sylvestre GECKO4501esr_2016031618_RELBRANCH
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 18 Mar 2016 10:40:00 +0100 - rev 311922
Push 72 by kwierso@gmail.com at Thu, 07 Apr 2016 18:38:17 +0000
Bug 1255735 - "Firefox 45 does not send content-type in empty input[type=file] anymore". r=smaug, a=sylvestre MozReview-Commit-ID: KR6QAauKLdp
261d78308372e2f555b77aa79c59ed57606d70ae: Bug 1255735 - "Firefox 45 does not send content-type in empty input[type=file] anymore". r=smaug, a=sylvestre
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 18 Mar 2016 10:40:00 +0100 - rev 311902
Push 64 by ryanvm@gmail.com at Sat, 02 Apr 2016 02:41:49 +0000
Bug 1255735 - "Firefox 45 does not send content-type in empty input[type=file] anymore". r=smaug, a=sylvestre
b659e2416ea9cee69ab3f98bd7c605c284a66bed: Bug 1249685 - Use more nsCOMPtrs for stack variables in DOM code. r=smaug, a=sylvestre
Andrew McCreight <continuation@gmail.com> - Tue, 23 Feb 2016 16:23:43 -0800 - rev 311718
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1249685 - Use more nsCOMPtrs for stack variables in DOM code. r=smaug, a=sylvestre
7f685bdc616a8557f4a516ce9f0d5fc015e18237: Bug 1233970 - Override YouTube userAgent to fake Firefox 42 in Firefox 43. r=smaug, a=sylvestre
Chris Pearce <cpearce@mozilla.com> - Tue, 22 Dec 2015 20:53:00 +0100 - rev 311659
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1233970 - Override YouTube userAgent to fake Firefox 42 in Firefox 43. r=smaug, a=sylvestre
7ba0c0811b23e2cbc0e3fb4a67a37bce2d96e082: Bug 1150284 - Disable offsetX/offsetY properties in FxOS/Fennec. r=smaug, a=lizzard
Robert O'Callahan <robert@ocallahan.org> - Sat, 20 Jun 2015 18:10:03 +0100 - rev 311486
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1150284 - Disable offsetX/offsetY properties in FxOS/Fennec. r=smaug, a=lizzard
5e9ddb2825ac2ce23703c84d62eaec756e65d210: Bug 1248794 - Clean up observer on WindowsGamepadService shutdown; r=ted r=smaug a=sylvestre
Kyle Machulis <kyle@nonpolynomial.com> - Tue, 16 Feb 2016 17:31:12 -0800 - rev 311361
Bug 1248794 - Clean up observer on WindowsGamepadService shutdown; r=ted r=smaug a=sylvestre
73fb5191562e1e2842c80d5124088d23480eb304: Bug 1154277: Part 1 - allow to swap docShells on remote browsers that are not a child of a BrowserDOMWindow. r=smaug, a=lizzard
Mike de Boer <mdeboer@mozilla.com> - Tue, 16 Feb 2016 10:30:10 +0000 - rev 311267
Bug 1154277: Part 1 - allow to swap docShells on remote browsers that are not a child of a BrowserDOMWindow. r=smaug, a=lizzard --HG-- extra : transplant_source : %8F%00h%A2%28%7C854%99%0A%07%E2b%A5%3C%AD%15%D05
e753a943bd68e78c947b7b0266650c7e2d34f0a9: Bug 1154277: Part 1 - allow to swap docShells on remote browsers that are not a child of a BrowserDOMWindow. r=smaug, a=lizzard
Mike de Boer <mdeboer@mozilla.com> - Thu, 04 Feb 2016 12:50:03 +0100 - rev 311249
Bug 1154277: Part 1 - allow to swap docShells on remote browsers that are not a child of a BrowserDOMWindow. r=smaug, a=lizzard
ce08fa9d4ed6c89d009a29bddd8ea3075bb868fc: Bug 1228103. r=smaug. a=sylvestre
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 09 Feb 2016 12:45:59 +0200 - rev 311225
Bug 1228103. r=smaug. a=sylvestre
07434c70518d0a5aeb7cc00504320def9c0f446c: Bug 1243555: Remove unnecessary nsDocShell static_cast in EventListenerManager::HandleEventInternal(). r=smaug, a=sylvestre
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 11 Feb 2016 10:51:51 -0800 - rev 311215
Bug 1243555: Remove unnecessary nsDocShell static_cast in EventListenerManager::HandleEventInternal(). r=smaug, a=sylvestre
cb8ee60c69f45c0dc2b2184d304d6ec5400887d1: Bug 1240208 - use inputmode in XUL to get better hinting for IME and on-screen keyboards, r=masayuki r=smaug, a=sylvestre
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 01 Feb 2016 17:57:29 +0000 - rev 311153
Bug 1240208 - use inputmode in XUL to get better hinting for IME and on-screen keyboards, r=masayuki r=smaug, a=sylvestre
f542c0715e921cc819291d2d75b09542fb1629b8: Bug 1245674. Null-check mGlobal before dereferencing it in one more place in Promise code. r=smaug, a=sylvestre
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 05 Feb 2016 13:12:52 -0500 - rev 311141
Bug 1245674. Null-check mGlobal before dereferencing it in one more place in Promise code. r=smaug, a=sylvestre
826352bbda0a84bab2e3747f495d31be51cbf50d: Bug 1187157 - new FormData::get() should return an empty string if the file is not set - part 2, r=smaug, a=test-only
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 07 Jan 2016 09:54:16 +0000 - rev 310975
Bug 1187157 - new FormData::get() should return an empty string if the file is not set - part 2, r=smaug, a=test-only
fbf8189d69513bea5486eb1ddc68030a9089218f: Bug 1187157 - new FormData::get() should return an empty string if the file is not set - part 1, r=smaug, a=sylvestre
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 07 Jan 2016 09:54:00 +0000 - rev 310974
Bug 1187157 - new FormData::get() should return an empty string if the file is not set - part 1, r=smaug, a=sylvestre
020925ff18814a1e56593c55ca63ffc9f7bdf98d: Bug 1234049 - Ensure we always invalidate new PresShells that are created for an inactive DocShell upon reactivating them. r=smaug, a=sylvestre
George Wright <george@mozilla.com> - Wed, 13 Jan 2016 17:00:15 -0500 - rev 310927
Bug 1234049 - Ensure we always invalidate new PresShells that are created for an inactive DocShell upon reactivating them. r=smaug, a=sylvestre
01b93573f9d466514485a3188bc666bb621d09bb: Bug 1235908 - measure total event wait and process time. r=smaug, a=sylvestre
Chris H-C <chutten@mozilla.com> - Mon, 18 Jan 2016 11:13:00 +0100 - rev 310889
Bug 1235908 - measure total event wait and process time. r=smaug, a=sylvestre Native events come with timestamps indicating when they were created or generated by the user. Using those, we can get a full picture of how long it takes between the user trying to do something and us responding to it. This is currently only for ports that populate WidgetEvent's timeStamp (presently gtk, Windows).
d41f633eeaf68bbac784738493a1fdf651e25481: Bug 1224766 - forward callID to disambiguate multiple gUM requests from same window. r=jesup,smaug a=sylvestre
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 07 Jan 2016 17:30:10 -0500 - rev 310821
Bug 1224766 - forward callID to disambiguate multiple gUM requests from same window. r=jesup,smaug a=sylvestre
0abf97cf3a7e1f6eac129128b7791a439044afd0: Bug 1236195 - Add missing requestFlakyTimeout for pointerlock/movementXY test. r=smaug a=testonly
Xidorn Quan <quanxunzhen@gmail.com> - Wed, 13 Jan 2016 10:29:09 +1100 - rev 310807
Bug 1236195 - Add missing requestFlakyTimeout for pointerlock/movementXY test. r=smaug a=testonly
75f2ab55c835179d31c671f2ce4bbdd62a40759e: Bug 1236329 - Back out the patch for bug 492933 (revision d8012b35413b) because it's not web-compatible in practice. r=smaug, a=ritu
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 05 Jan 2016 15:05:23 -0500 - rev 310772
Bug 1236329 - Back out the patch for bug 492933 (revision d8012b35413b) because it's not web-compatible in practice. r=smaug, a=ritu
02e0b7cd62ac0686adc5e47e6b30f3943a899153: Bug 1236329 - Back out the patch for bug 492933 (revision d8012b35413b) because it's not web-compatible in practice. r=smaug, a=ritu
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 05 Jan 2016 15:05:23 -0500 - rev 310766
Bug 1236329 - Back out the patch for bug 492933 (revision d8012b35413b) because it's not web-compatible in practice. r=smaug, a=ritu
4fdf6b0bed8b983745e919be1523a0fe9a2e8a44: Bug 1200092 - Add time gap between subtests of fullscreen-api-race test. r=smaug a=test-only
Xidorn Quan <quanxunzhen@gmail.com> - Tue, 05 Jan 2016 10:00:37 +1100 - rev 310720
Bug 1200092 - Add time gap between subtests of fullscreen-api-race test. r=smaug a=test-only
624eb61f2c315472061af83ef042ec1b18041532: Bug 1232829 - Detach obsolete DocumentTimeline from refresh driver when the document is reset; r=smaug a=sylvestre
Brian Birtles <birtles@gmail.com> - Tue, 22 Dec 2015 10:08:19 +0900 - rev 310616
Bug 1232829 - Detach obsolete DocumentTimeline from refresh driver when the document is reset; r=smaug a=sylvestre
f8931d8e5e4647cbf1e591851d5d1c9f7190a060: Bug 1221992 - Skip closed windows in GetMostRecentNonPBWindow. r=smaug
Catalin Badea <catalin.badea392@gmail.com> - Fri, 11 Dec 2015 13:32:15 -0500 - rev 310361
Bug 1221992 - Skip closed windows in GetMostRecentNonPBWindow. r=smaug
7f5522ec58503986db0b9c89c630b00f2b273842: Bug 1221992 - Fix test using GetMostRecentWindow from the child process. r=smaug
Catalin Badea <catalin.badea392@gmail.com> - Fri, 11 Dec 2015 13:32:15 -0500 - rev 310360
Bug 1221992 - Fix test using GetMostRecentWindow from the child process. r=smaug
25e2b2725a549cbc5a6983726e5082b5664845a8: Bug 1221992 - Prevent ServiceWorkerClients.OpenWindow from opening tabs in private mode windows. r=smaug
Catalin Badea <catalin.badea392@gmail.com> - Fri, 11 Dec 2015 13:32:15 -0500 - rev 310359
Bug 1221992 - Prevent ServiceWorkerClients.OpenWindow from opening tabs in private mode windows. r=smaug
95608418cba5a6b730d22151bccfc810765ae194: Bug 1179632 part.6 KeyboardEvent.isComposing shouldn't expose IME state on different document r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Dec 2015 18:50:43 +0900 - rev 310311
Bug 1179632 part.6 KeyboardEvent.isComposing shouldn't expose IME state on different document r=smaug
7d06dabf27696ff8746f8d8b92f2ca6b1ce175ba: Bug 1179632 part.5 WidgetCompositionEvent::mNativeIMEContext should be used at looking for a TextComposition instance for a WidgetCompositionEvent r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Dec 2015 18:50:34 +0900 - rev 310310
Bug 1179632 part.5 WidgetCompositionEvent::mNativeIMEContext should be used at looking for a TextComposition instance for a WidgetCompositionEvent r=smaug
98f5d0788f2e257292c88faa534c9dfcc16e59ea: Bug 1179632 part.4 Clean up the code to request IME to commit composition across process boundary r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 Dec 2015 15:15:58 +0900 - rev 310309
Bug 1179632 part.4 Clean up the code to request IME to commit composition across process boundary r=smaug
d285dc8f2ed559cbddfeae63117a66a7e466e6d0: Bug 1179632 part.3 TabParent::RecvEndIMEComposition() shouldn't return true with aNoCompositionEvent when there is no widget r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 04 Dec 2015 18:38:28 +0900 - rev 310308
Bug 1179632 part.3 TabParent::RecvEndIMEComposition() shouldn't return true with aNoCompositionEvent when there is no widget r=smaug
63101b99fa95195574c9eab5680b1f1acd4442ba: Bug 1179632 part.2 WidgetCompositionEvent should store NativeIMEContext which caused the event and PuppetWidget should store it for GetNativeIMEContext() r=smaug, sr=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 Dec 2015 15:15:57 +0900 - rev 310307
Bug 1179632 part.2 WidgetCompositionEvent should store NativeIMEContext which caused the event and PuppetWidget should store it for GetNativeIMEContext() r=smaug, sr=smaug
a58871d438cc47cc9e5b835b969ca27084cbbae4: Bug 1179632 part.1 native IME context should not be stored in InputContext but should be able to retrieve with nsIWidget::GetNativeData() r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 Dec 2015 15:15:57 +0900 - rev 310306
Bug 1179632 part.1 native IME context should not be stored in InputContext but should be able to retrieve with nsIWidget::GetNativeData() r=smaug
a9f19893d34d4743bad603e9e32a3f373f7b21e1: Bug 1231124 - addded mCurve to constructor. r=smaug
Bogdan Postelnicu <bogdan.postelnicu> - Wed, 09 Dec 2015 00:00:00 +0100 - rev 310111
Bug 1231124 - addded mCurve to constructor. r=smaug
99dd62654b77b3ca88987caad6fbd829c725a6f6: Bug 1225968 - Add authentication secret to push API, r=kitcambridge,smaug
Martin Thomson <martin.thomson@gmail.com> - Wed, 09 Dec 2015 07:26:42 +1100 - rev 310064
Bug 1225968 - Add authentication secret to push API, r=kitcambridge,smaug
493f9c9164b7b8e38257064b4eb718a16c5546ac: Bug 1230700. Make Notification::ShowInternal explicitly suppress the exception from GetPermissionInternal. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 07 Dec 2015 18:41:59 -0500 - rev 310005
Bug 1230700. Make Notification::ShowInternal explicitly suppress the exception from GetPermissionInternal. r=smaug