searching for reviewer(rillian)
7ebfe49f001c522e899f85a88f1ce77f14687635: Bug 1263384: validate input frames against configured resolution in vp8 r=rillian, a=ritu,lizzard
Randell Jesup <rjesup@jesup.org> - Fri, 15 Apr 2016 23:11:01 -0400 - rev 312077
Push 145 by rjesup@wgate.com at Fri, 27 May 2016 19:24:12 +0000
Bug 1263384: validate input frames against configured resolution in vp8 r=rillian, a=ritu,lizzard MozReview-Commit-ID: BxDCnJe0mzs
3662a8ec90d127cdd9fc6cefba79fdb9ca3763a1: Bug 1198435 - Call RemoveMediaElementFromURITable before modifying mLoadingSrc, so that a future LookupMediaElementURITable won't access this element anymore. r=rillian a=ritu
Gerald Squelart <gsquelart@mozilla.com> - Thu, 10 Sep 2015 09:01:44 +0200 - rev 311559
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1198435 - Call RemoveMediaElementFromURITable before modifying mLoadingSrc, so that a future LookupMediaElementURITable won't access this element anymore. r=rillian a=ritu
0bfe8c7362cb94785844109faee6cd672548f20c: Bug 1198435 - Call RemoveMediaElementFromURITable before modifying mLoadingSrc, so that a future LookupMediaElementURITable won't access this element anymore. r=rillian a=ritu
Gerald Squelart <gsquelart@mozilla.com> - Thu, 10 Sep 2015 09:01:44 +0200 - rev 311556
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1198435 - Call RemoveMediaElementFromURITable before modifying mLoadingSrc, so that a future LookupMediaElementURITable won't access this element anymore. r=rillian a=ritu
df2dea56618821ee6fc34eb8b420efab5813b023: Bug 1198435 - MediaElementTableCount now checks that the element is not present for URIs other than the expected one. r=rillian a=ritu
Gerald Squelart <gsquelart@mozilla.com> - Thu, 10 Sep 2015 09:00:15 +0200 - rev 311555
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1198435 - MediaElementTableCount now checks that the element is not present for URIs other than the expected one. r=rillian a=ritu
fd83808c7eba4f3c403fe7f4b16f9f370b95e94a: Bug 1237848 - Check lookahead ctx - r=rillian, a=sylvestre
Gerald Squelart <gsquelart@mozilla.com> - Thu, 04 Feb 2016 11:29:00 +1100 - rev 311357
Bug 1237848 - Check lookahead ctx - r=rillian, a=sylvestre Copied from https://chromium-review.googlesource.com/324510
b4a141cbb4544e489cdde767f1fc97dde0a5d10e: Bug 1230295 - Add telemetry to report when Ogg chaining is used. r=rillian,r=vladan
Chris Pearce <cpearce@mozilla.com> - Thu, 10 Dec 2015 12:10:41 -0500 - rev 310248
Bug 1230295 - Add telemetry to report when Ogg chaining is used. r=rillian,r=vladan
429cd1f9006d3327aa54e526c7d1ef1e7b0bee0f: Bug 1224361 - Upstream update patch - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:46 +1100 - rev 309520
Bug 1224361 - Upstream update patch - r=rillian
9ca27c3da0328c41fc12915c069e8889c721165f: Bug 1224361 - Clamp QIndex also in abs-value mode - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:46 +1100 - rev 309519
Bug 1224361 - Clamp QIndex also in abs-value mode - r=rillian
ea96a37f1a43e9926be3a930a2f3c7b25b5286ff: Bug 1224361 - Added vp8/ivf test case - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:46 +1100 - rev 309518
Bug 1224361 - Added vp8/ivf test case - r=rillian
6b7901d50318a6e485af823ef7fe9137daa618d9: Bug 1224369 - p2: Added vp8/ivf test case - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:46 +1100 - rev 309517
Bug 1224369 - p2: Added vp8/ivf test case - r=rillian
06c9e401ee3c3b62a4d488d17f56c1c592164e95: Bug 1224369 - p1: Test cases given as list - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:46 +1100 - rev 309516
Bug 1224369 - p1: Test cases given as list - r=rillian No actual test changes from before. This will help with this bug and future ones, to easily add more test cases.
fcca1d97bd3263337b1cfba8891303651a51cd72: Bug 1224363 - Upstream update patch - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:45 +1100 - rev 309515
Bug 1224363 - Upstream update patch - r=rillian
f0cc92be4cd8cb1a55f2a029a102ec2d079eafef: Bug 1224363 - Clamp seg_lvl also in abs-value mode - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:45 +1100 - rev 309514
Bug 1224363 - Clamp seg_lvl also in abs-value mode - r=rillian Even when the segment feature data is in absolute mode, it is still read as a 6-bit value with an added sign, so it could have values between -63 and +63. Later, this signed value is used without checks as a filter level, which is used to access an entry in an array of size MAX_LOOP_FILTER+1=64. This patch just extends the existing clamping (that was done only to relative- mode data) to absolute mode data, before it is blindly 'memset' in lfi->lvl[seg][0], which was where the out-of-bound filter_value was read in subsequent vp8_loop_filter_row_simple.
9f6b527b5e1377940474a7086965d2e1717270ec: Bug 1224363 - Added vp8/ivf test case - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 14:14:45 +1100 - rev 309513
Bug 1224363 - Added vp8/ivf test case - r=rillian
d036b1daeb0b1b61f85f69eff722eeccccd5ffd4: Bug 1229615 - Compare track counts between rust and stagefright. r=rillian
Matthew Gregan <kinetik@flim.org> - Wed, 02 Dec 2015 12:19:29 -0800 - rev 309499
Bug 1229615 - Compare track counts between rust and stagefright. r=rillian Use the new capi calls in rust mp4parse v0.1.5 to query audio and video track counts and compare with what we get from stagefright.
80aa7ecf9456fb36b02992e7586ff4da630e5cd7: Bug 1229615 - Compare track counts between rust and stagefright. r=rillian
Matthew Gregan <kinetik@flim.org> - Wed, 02 Dec 2015 12:19:29 -0800 - rev 309469
Bug 1229615 - Compare track counts between rust and stagefright. r=rillian Use the new capi calls in rust mp4parse v0.1.5 to query audio and video track counts and compare with what we get from stagefright.
cddca26367a2cc6c693554ace02f964ffec634db: Bug 1210319 - p2. Minor intf clean-up, RIP trex - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Tue, 01 Dec 2015 13:45:55 -0800 - rev 309234
Bug 1210319 - p2. Minor intf clean-up, RIP trex - r=rillian Made some class interfaces a bit more "C++11"-ish, to protect against some possible issues. Also removed 'trex', which was only used by code removed in previous patch.
571d6fc4fcdde4b0587bbf22e84e5e7141bbaebf: Bug 1210319 - p1. Removed unused code - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Tue, 01 Dec 2015 13:45:42 -0800 - rev 309233
Bug 1210319 - p1. Removed unused code - r=rillian
5d977c74e5741a13e15c295c5caa377428e3b844: Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian
sajitk <sajitk@rocketmail.com> - Sun, 15 Nov 2015 14:49:01 +0100 - rev 306839
Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian
1e5f3d1151d60a1edd6424a35a2e38b5ab17adad: Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian
sajitk <sajitk@rocketmail.com> - Wed, 11 Nov 2015 06:52:00 +0100 - rev 306328
Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian
98c4817458d1f8b6aca34cd848176f1a71e764dd: Bug 1216845 - Check fallible allocations - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Wed, 11 Nov 2015 12:37:53 +0100 - rev 306235
Bug 1216845 - Check fallible allocations - r=rillian - Made externally-sized 'new' allocations fallible. - Check return value of every new(fallible)/malloc/realloc. - Consistently return -ENOMEM when allocations fail. - MPEG4Extractor::getTrack() and getMetaData() can return null (because of failed parse or failed alloc); added missing checks in callers. Note: Some allocs in the 2nd half of MPEG4Extractor have not been touched, as they are in unused code to be removed in bug 1210319.
330c1763806e3c1ec477084b0ec13e40a4d33fda: Bug 1216748 - p4. Check other Metadata::setData uses - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Wed, 11 Nov 2015 12:36:26 +0100 - rev 306234
Bug 1216748 - p4. Check other Metadata::setData uses - r=rillian Found only one other use that needed better checks: the size of the pssh data was only checked after all items were added up; so it would be possible to create a set of big items such that they create an overflow, but the final sum looks reasonable. Instead each item size should be checked, and the sum should also be checked at each step.
71113b0fe61f105583f2d7f3718b16896f874000: Bug 1216748 - p3. Ensure 'covr' data size cannot create underflow - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Wed, 11 Nov 2015 12:36:05 +0100 - rev 306233
Bug 1216748 - p3. Ensure 'covr' data size cannot create underflow - r=rillian
0962522f86abe4c3d74ccd5054cc47f92a326aa3: Bug 1216748 - p2. Handle failed malloc in Metadata storage - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Wed, 11 Nov 2015 12:35:52 +0100 - rev 306232
Bug 1216748 - p2. Handle failed malloc in Metadata storage - r=rillian
a0eedfc2faec5f0239a8b9757508b8ea22352f34: Bug 1216748 - p1. Added test case with different 'covr' sizes - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Wed, 11 Nov 2015 12:35:38 +0100 - rev 306231
Bug 1216748 - p1. Added test case with different 'covr' sizes - r=rillian
d79ccfd9bbe7159551e7cdb275c34829edccfa8f: Bug 1185230 - p1: Added mp4 test case to libstagefright gtest - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 23:20:00 +0100 - rev 305709
Bug 1185230 - p1: Added mp4 test case to libstagefright gtest - r=rillian
586b898cca97997325fdd0e1c0e99fba0fc6374f: Bug 1185230 - p2: Store MPEG4Source::mTimescale as uint32_t - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 20:10:00 +0100 - rev 305708
Bug 1185230 - p2: Store MPEG4Source::mTimescale as uint32_t - r=rillian The timescale is read as an unsigned integer, but was stored signed in MPEG4Source, causing it to overflow into a negative number if too big, causing later issues when exporting indices with negative timestamps.
9f4513bf2d03334e34167646fd8904bdf2bee52c: Bug 1181213 - Added Added mp4 test case to libstagefright gtest - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:12:00 +0100 - rev 305707
Bug 1181213 - Added Added mp4 test case to libstagefright gtest - r=rillian Note: This bug is effectively fixed by bug 1181215, so only this test case is provided to prove the successful resolution of this bug.
e61b1ed57f87776d333287dd423a893dc845c48a: Bug 1181215 - p1: Added mp4 test case to libstagefright gtest - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:11:00 +0100 - rev 305706
Bug 1181215 - p1: Added mp4 test case to libstagefright gtest - r=rillian
f8db80facd1a07af8e77b01cade5ea5c6b3bdae8: Bug 1181215 - p2: Better track verification - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 03:11:00 +0100 - rev 305705
Bug 1181215 - p2: Better track verification - r=rillian Copied some tests from MPEG4Source constructor to MPEG4Extractor::verifyTrack so that we don't get late surprises, in particular a missing track ID.
7964a5a4b0bd914d82822c9b1bb38dea19f90232: Bug 1181220 - p2: Check if MIME types are valid - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:10:00 +0100 - rev 305704
Bug 1181220 - p2: Check if MIME types are valid - r=rillian
a5555f3b971232e9991ed4d430a3336e2321475e: Bug 1181220 - p1: Added mp4 test case to libstagefright gtest - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:08:00 +0100 - rev 305703
Bug 1181220 - p1: Added mp4 test case to libstagefright gtest - r=rillian
cd0c64a4656b4d0924c2f86f4a22e58dba235d90: Bug 1181223 - p2: Handle wrong saio/saiz size instead of assuming it is correct - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:06:00 +0100 - rev 305702
Bug 1181223 - p2: Handle wrong saio/saiz size instead of assuming it is correct - r=rillian
741fc69a16795f5f83a6f8af1039912b9dbacd9b: Bug 1181223 - p1: Added mp4 test case to libstagefright gtest - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:05:00 +0100 - rev 305701
Bug 1181223 - p1: Added mp4 test case to libstagefright gtest - r=rillian
141a05a200420244bf618ad7d5618765a566b820: Bug 1181719 - p1: Added mp4 test case to libstagefright gtest - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 05 Nov 2015 19:01:00 +0100 - rev 305700
Bug 1181719 - p1: Added mp4 test case to libstagefright gtest - r=rillian Remove mdat, which is big and not useful in this test that only looks at metadata.
2801114b2b72e4f74f53848aea02de0ab39ad4e1: Bug 1181719 - p2: Check numBitsLeft before each getBits - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Wed, 04 Nov 2015 23:42:00 +0100 - rev 305699
Bug 1181719 - p2: Check numBitsLeft before each getBits - r=rillian
f15dc0e76382e7904095c7997b39db5db3559216: Bug 1216748 - p4. Check other Metadata::setData uses - r=rillian, a=lizzard
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 15:48:04 +0100 - rev 303958
Bug 1216748 - p4. Check other Metadata::setData uses - r=rillian, a=lizzard Found only one other use that needed better checks: the size of the pssh data was only checked after all items were added up; so it would be possible to create a set of big items such that they create an overflow, but the final sum looks reasonable. Instead each item size should be checked, and the sum should also be checked at each step.
da91739d14435e9de123bf4a5c9bf207316b424c: Bug 1216748 - p3. Ensure 'covr' data size cannot create underflow - r=rillian, a=lizzard
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 15:47:35 +0100 - rev 303957
Bug 1216748 - p3. Ensure 'covr' data size cannot create underflow - r=rillian, a=lizzard
ab26e636d6add840a60d74b1d7e2a9cfda520080: Bug 1216748 - p2. Handle failed malloc in Metadata storage - r=rillian, a=lizzard
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 15:47:13 +0100 - rev 303956
Bug 1216748 - p2. Handle failed malloc in Metadata storage - r=rillian, a=lizzard
29467b3d2124c963eb6646373839b5c5e4d48fc2: Bug 1156505 - p2: Null-check sampleTable before use. r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Fri, 02 Oct 2015 16:13:00 +0200 - rev 299607
Bug 1156505 - p2: Null-check sampleTable before use. r=rillian
22384f4ad5e1ce0908c399ebabfb2931065b2063: Bug 1156505 - p1: Added test case file from bug. r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Mon, 05 Oct 2015 04:01:00 +0200 - rev 299606
Bug 1156505 - p1: Added test case file from bug. r=rillian
dd628d2021d51130544e143d536c15f88cc41ddf: Bug 1156505 - p2: Null-check sampleTable before use - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Fri, 02 Oct 2015 16:13:00 +0200 - rev 299408
Bug 1156505 - p2: Null-check sampleTable before use - r=rillian
b05d8992f36cdcb65ee3487ed5afd2fb75a10814: Bug 1156505 - p1: Added test case file from bug - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Thu, 01 Oct 2015 00:59:00 +0200 - rev 299407
Bug 1156505 - p1: Added test case file from bug - r=rillian
35958f485b2987e8b54fa3e66500174ba5cda867: Bug 1204580 - p2: Check box ranges. r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Fri, 02 Oct 2015 09:20:39 +0200 - rev 299096
Bug 1204580 - p2: Check box ranges. r=rillian
0f18e328113b444de6b8002e621250ab0170fef7: Bug 1204580 - p1: Added test case files. r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Fri, 02 Oct 2015 09:20:13 +0200 - rev 299095
Bug 1204580 - p1: Added test case files. r=rillian
fb9fad31d6325ff1de1c8c7067882005f3f1ebb4: Bug 1200326 - p4 - Added test case from bug 1200326, with more checks - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Sat, 26 Sep 2015 04:44:00 +0200 - rev 298105
Bug 1200326 - p4 - Added test case from bug 1200326, with more checks - r=rillian
ff255d58ce896ed6e48b34720e90d89f90170e92: Bug 1200326 - p3 - Test case filenames are now in a list, to allow adding more tests - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Sat, 26 Sep 2015 04:43:00 +0200 - rev 298104
Bug 1200326 - p3 - Test case filenames are now in a list, to allow adding more tests - r=rillian
a318ed9150221f37885499fad4984eb6c0984f6b: Bug 1200326 - part 2 - Parse subsets of the input stream - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Sat, 26 Sep 2015 04:42:00 +0200 - rev 298103
Bug 1200326 - part 2 - Parse subsets of the input stream - r=rillian In addition to starting parsing at different points across the input stream, different sizes are given, from the minimum step size up to the remainder of the stream.
875c69bd35507afd3aebe21b212426f44db2cf20: Bug 1200326 - P 1 - Moved test case contents from test source into separate file - r=rillian
Gerald Squelart <gsquelart@mozilla.com> - Sat, 26 Sep 2015 04:40:00 +0200 - rev 298102
Bug 1200326 - P 1 - Moved test case contents from test source into separate file - r=rillian This will make it easier to modify input files and add more of them.
dd66dc8e2eb1e88e5242aa01a629f9dadd803dd8: Bug 1216748 - p4. Check other Metadata::setData uses - r=rillian a=lizzard
Gerald Squelart <gsquelart@mozilla.com> - Thu, 03 Dec 2015 15:03:34 -0800 - rev 296871
Bug 1216748 - p4. Check other Metadata::setData uses - r=rillian a=lizzard Found only one other use that needed better checks: the size of the pssh data was only checked after all items were added up; so it would be possible to create a set of big items such that they create an overflow, but the final sum looks reasonable. Instead each item size should be checked, and the sum should also be checked at each step.