searching for reviewer(mcmanus)
290f10412f9291f49e74fe7ff32af3259c944e9a: Bug 1343505. r=mcmanus, a=abillings
Nicholas Hurley <hurley@mozilla.com> - Wed, 22 Mar 2017 16:57:46 -0400 - rev 312804
Push 487 by ryanvm@gmail.com at Wed, 22 Mar 2017 20:58:26 +0000
Bug 1343505. r=mcmanus, a=abillings MozReview-Commit-ID: 7OPJQfzW4FU
bc2f5467b33d70d5dc03fdc0d2fcf0d52356f186: Bug 1287266 - Integer overflow check in WebSocketChannel::ProcessInput, r=mcmanus, a=sylvestre
Michal Novotny <michal.novotny@gmail.com> - Wed, 20 Jul 2016 17:15:32 +0200 - rev 312199
Push 213 by kwierso@gmail.com at Mon, 29 Aug 2016 17:22:22 +0000
Bug 1287266 - Integer overflow check in WebSocketChannel::ProcessInput, r=mcmanus, a=sylvestre
4a5d8ade4e3ebfa28287430ec8bb139efa570695: Bug 1242904 - Adjust calculation of ringbuffer_end_minus_copy_length in BrotliDecompressStreaming. r=mcmanus, a=sylvestre
Frédéric Wang <fred.wang@free.fr> - Thu, 25 Feb 2016 12:35:18 +0100 - rev 311715
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1242904 - Adjust calculation of ringbuffer_end_minus_copy_length in BrotliDecompressStreaming. r=mcmanus, a=sylvestre
c51ca5032cf04022f8ccb21116c68e3bb3fe3a05: Bug 1244505 - Allow spaces in cookie names. r=mcmanus, a=sylvestre
Nicholas Hurley <hurley@todesschaf.org> - Mon, 01 Feb 2016 09:46:24 -0800 - rev 311689
Push 4 by ryanvm@gmail.com at Tue, 01 Mar 2016 02:03:04 +0000
Bug 1244505 - Allow spaces in cookie names. r=mcmanus, a=sylvestre
0f84789c8b08ca4c93c3d85eedeb843af434e793: Bug 1240760: Update DataChannel::Close() r=mcmanus, a=ritu
Randell Jesup <rjesup@jesup.org> - Fri, 19 Feb 2016 01:08:07 -0500 - rev 311355
Bug 1240760: Update DataChannel::Close() r=mcmanus, a=ritu MozReview-Commit-ID: 7nN9h3M3O8w
8ee0a04287aab354062f50d7f5fc138ee8e04866: Bug 1246850 - check the NotifyIpInterfaceChange() return code, r=mcmanus, a=sylvestre
Daniel Stenberg <daniel@haxx.se> - Tue, 09 Feb 2016 01:31:00 +0100 - rev 311194
Bug 1246850 - check the NotifyIpInterfaceChange() return code, r=mcmanus, a=sylvestre
d6f5a4905c66b5c97582ad11e4705f142838e7b7: Bug 1244505 - Allow spaces in cookie names. r=mcmanus, a=sylvestre
Nicholas Hurley <hurley@todesschaf.org> - Mon, 01 Feb 2016 09:46:24 -0800 - rev 311115
Bug 1244505 - Allow spaces in cookie names. r=mcmanus, a=sylvestre
cbd385ecef20a6ca6c9664dcaa64bb0862ced92c: Bug 1237775 - Change pref for network monitoring on linux to false. r=mcmanus, a=sylvestre
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 08 Jan 2016 08:06:00 +0100 - rev 310837
Bug 1237775 - Change pref for network monitoring on linux to false. r=mcmanus, a=sylvestre
6252d26907b6133474714aabea3249922cc3a297: Bug 1238010 - Turn off ClosingService. r=mcmanus, a=ritu
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 08 Jan 2016 15:10:00 -0500 - rev 310811
Bug 1238010 - Turn off ClosingService. r=mcmanus, a=ritu
aa83b5c4359889ea26e3545dd9ef891b17629e64: Bug 1236170 - Make Http2Session::UncompressAndDiscard push-aware. r=mcmanus a=ritu
Nicholas Hurley <hurley@todesschaf.org> - Mon, 04 Jan 2016 12:17:39 -0800 - rev 310729
Bug 1236170 - Make Http2Session::UncompressAndDiscard push-aware. r=mcmanus a=ritu
e8b02a6a50d2a5c864d636931296d51e4fd89c4c: Bug 1231552 - Back out bug 1121800, bug 1207798 and bug 1214200 changesets. r=mcmanus
Daniel Stenberg <daniel@haxx.se> - Thu, 10 Dec 2015 07:21:00 +0100 - rev 310338
Bug 1231552 - Back out bug 1121800, bug 1207798 and bug 1214200 changesets. r=mcmanus
35d0e5235621eaf2c176695ca349191eb762bc66: Bug 1216837: add explicit error checks for packet length in srtp r=mcmanus rs=jesup
Randell Jesup <rjesup@jesup.org> - Sat, 05 Dec 2015 11:06:40 -0500 - rev 309938
Bug 1216837: add explicit error checks for packet length in srtp r=mcmanus rs=jesup
cc847f227d9a2736a62ec10b3c2dc147b69c6d34: Bug 1223808 - part 3 - replace nsAutoArrayPtr<T> with UniquePtr<T[]> in netwerk/; r=mcmanus
Nathan Froyd <froydnj@mozilla.com> - Sun, 08 Nov 2015 21:28:05 -0500 - rev 309480
Bug 1223808 - part 3 - replace nsAutoArrayPtr<T> with UniquePtr<T[]> in netwerk/; r=mcmanus
689d9f449560c540ba39d9c7c346c6666c3fb480: Bug 1223808 - part 1 - optimize creating a WebSocketFrame with a payload; r=mcmanus
Nathan Froyd <froydnj@mozilla.com> - Sun, 08 Nov 2015 21:26:46 -0500 - rev 309478
Bug 1223808 - part 1 - optimize creating a WebSocketFrame with a payload; r=mcmanus This function: - Allocates a block of memory; - Copies things into that block of memory; - Allocates another block of memory inside nsAutoCString; - Copies into our string from the block of memory we just allocated. Clearly we can avoid a memory allocation and some copying by just allocating the amount of data we need in the string first, and copying things into the string.
9a929584adeb5431e8352ca21bea2e663896d95d: Bug 1225682 - Don't use nsAuto{,C}String as class member variables in netwerk/. r=mcmanus
Mike Hommey <mh+mozilla@glandium.org> - Thu, 19 Nov 2015 18:30:23 +0900 - rev 309274
Bug 1225682 - Don't use nsAuto{,C}String as class member variables in netwerk/. r=mcmanus
39f84441cb1cb9336a020253212be9a1c44262c3: Bug 1226760 - ViewSource doesn't work for packaged app resources r=mcmanus
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 25 Nov 2015 12:44:43 +0100 - rev 308341
Bug 1226760 - ViewSource doesn't work for packaged app resources r=mcmanus * The packaged app service should use the URI of the channel, not the URI of the channel's principal.
6bfb430de85dc794354595eb788a5b00685fb79d: Bug 1225726 - enable nsDNSServiceDiscovery on OS X. r=mcmanus.
Shih-Chiang Chien <schien@mozilla.com> - Wed, 18 Nov 2015 14:02:31 +0800 - rev 307975
Bug 1225726 - enable nsDNSServiceDiscovery on OS X. r=mcmanus.
fb8fdc09bd1e0b78a7c19c64d15007a247d40b43: Bug 1210302 - Part 6: Update the documentation of the methods in the IDL file; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 02 Oct 2015 17:04:49 -0400 - rev 307801
Bug 1210302 - Part 6: Update the documentation of the methods in the IDL file; r=mcmanus
bfa7495fc298eb053b562910af95b462e00cc269: Bug 1210302 - Part 5: Add a unit test for parseRequestContentType; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 01 Oct 2015 18:12:16 -0400 - rev 307800
Bug 1210302 - Part 5: Add a unit test for parseRequestContentType; r=mcmanus
18b0d63d9f06d849a8358e5acff33f7fc70250f8: Bug 1142083 - Add test for IDN Unicode domain redirect r=mcmanus
Valentin Gosu <valentin.gosu@gmail.com> - Sat, 20 Jun 2015 00:03:57 +0300 - rev 307247
Bug 1142083 - Add test for IDN Unicode domain redirect r=mcmanus
b4d1f42f705eade8e9ac8511942aaab8e071f897: Bug 1218918 - Issues with devtools "work offline" when connectivity changes r=mcmanus,dao
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 18 Nov 2015 15:25:39 +0100 - rev 307246
Bug 1218918 - Issues with devtools "work offline" when connectivity changes r=mcmanus,dao * Flip the network.offline-mirrors-connectivity pref, so that ioservice.offline means the same as devtools work offline * ioService.manageOfflineStatus shouldn't be changed when going to offline mode. * Add logging to nsIOService in order to track offline/connectivity issues
cc4f5b4bb374b95c36c818e666c2a087fe6f20ca: Bug 412457 - should unescape hostname first, then perform IDNA r=mcmanus
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 18 Nov 2015 15:25:27 +0100 - rev 307245
Bug 412457 - should unescape hostname first, then perform IDNA r=mcmanus
19e419ab3792fa5aad9f531364e72827ea01d34c: Bug 1224046 - Remove <base href> from directory listings. r=mcmanus
Mike Hommey <mh+mozilla@glandium.org> - Thu, 12 Nov 2015 18:00:15 +0900 - rev 307180
Bug 1224046 - Remove <base href> from directory listings. r=mcmanus There was an attempt to remove it in bug 358128, but that was backed out because of FTP listings, where e.g. a 'mozilla' link on the ftp://ftp.mozilla.org/pub listing (without a trailing slash) would go to ftp://ftp.mozilla.org/pubmozilla instead of ftp://ftp.mozilla.org/pub/mozilla. It appears that versions of Firefox at the time of that bug wouldn't "redirect" directories to the same url with a trailing slash when one was not provided. It also appears that current versions of Firefox *do* "redirect" in such a way, such that the <base href> is now unnecessary. That <base href> prevents links from resource://... directory listings to work properly because of security contraints added in bug 1184387, as they force links to go to a jar/file url instead of the equivalent resource://... url, which removing <base href> allows.
410f33dfbc895cf0ac6b69ed3279b2b641c16862: Bug 1207798 - add pref to toggle proxy behavior when inaccessible. r=mcmanus
Daniel Stenberg <daniel@haxx.se> - Tue, 10 Nov 2015 15:27:45 +0100 - rev 306829
Bug 1207798 - add pref to toggle proxy behavior when inaccessible. r=mcmanus
e926606aefbf83605f7125787a2b6cade59be193: Bug 1214305 - Part 7: Decide in the child process whether an intercepted channel should go through a secure upgrade; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 02 Nov 2015 11:27:00 -0500 - rev 306697
Bug 1214305 - Part 7: Decide in the child process whether an intercepted channel should go through a secure upgrade; r=mcmanus This is OK from a security perspective, since this decision only affects whether the channel will be intercepted with the secure URI in the child process. If the intercepting service worker decides to fall back to an actual network request, we send the request to the parent process with the original pre-upgrade URI, and the parent process will still be in charge of whether a network visible HTTP request should be upgraded.
226c83ca9a2aa4c16e42603d54c2636087e985b2: Bug 1214305 - Part 6: Use a non-IPC redirect for synthesized upgraded responses to ensure the response URL is correctly propagated; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 02 Nov 2015 11:27:00 -0500 - rev 306696
Bug 1214305 - Part 6: Use a non-IPC redirect for synthesized upgraded responses to ensure the response URL is correctly propagated; r=mcmanus
be072bba15fc640071e76c99df7aee5e8b90e07d: Bug 1214305 - Part 2: Refactor the logic for obtaining the secure upgraded URI into HttpBaseChannel; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 02 Nov 2015 11:27:00 -0500 - rev 306692
Bug 1214305 - Part 2: Refactor the logic for obtaining the secure upgraded URI into HttpBaseChannel; r=mcmanus
3b85acbe7be7111f06f44ad36a324c9e10415483: Bug 1214305 - Part 1: Refactor the logic for querying whether a connection should go through a secure upgrade into NS_ShouldSecureUpgrade; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 02 Nov 2015 11:27:00 -0500 - rev 306691
Bug 1214305 - Part 1: Refactor the logic for querying whether a connection should go through a secure upgrade into NS_ShouldSecureUpgrade; r=mcmanus
167f9422e3992f8acd8fb28af3117f0db8a1d021: Bug 1224328 - Don't infinite loop when parsing headers with newlines. r=mcmanus
Nicholas Hurley <hurley@todesschaf.org> - Thu, 12 Nov 2015 14:44:31 -0800 - rev 306612
Bug 1224328 - Don't infinite loop when parsing headers with newlines. r=mcmanus
2d6c2b2974e915b75d20a645579af5771179bc03: Bug 1222867 - part 2 - be smarter about transferring ownership of WebSocketFrame; r=mcmanus
Nathan Froyd <froydnj@mozilla.com> - Sun, 08 Nov 2015 20:52:27 -0500 - rev 306115
Bug 1222867 - part 2 - be smarter about transferring ownership of WebSocketFrame; r=mcmanus WebSocketFrames are created only to be transferred in to WebSocketEventService::Frame{Sent,Received}, where a strong reference is taken to them by a runnable posted to the main thread. Let's avoid an extra AddRef/Release cycle by passing through already_AddRefed structures.
a96097c7f61265c09f488840348b08894249b4ab: Bug 1222867 - part 1 - return already_AddRefed from WebSocketEventService::CreateFrameIfNeeded; r=mcmanus
Nathan Froyd <froydnj@mozilla.com> - Sun, 08 Nov 2015 20:44:11 -0500 - rev 306114
Bug 1222867 - part 1 - return already_AddRefed from WebSocketEventService::CreateFrameIfNeeded; r=mcmanus The result of CreateFrameIfNeeded is always assigned to a RefPtr, so we can save a little code space by moving the AddRef into the callee, rather than doing it in the caller.
a5d633bb299c73ae5341550453798e82536fce30: Bug 1222829: Remove URIChecker. r=mcmanus
Jonas Sicking <jonas@sicking.cc> - Mon, 09 Nov 2015 13:48:05 -0800 - rev 305972
Bug 1222829: Remove URIChecker. r=mcmanus
82b29ff70513cebb7d915c6f6a423c3588510fd6: Bug 1219910 - make gSocketThread a relaxed atomic variable; r=mcmanus
Nathan Froyd <froydnj@mozilla.com> - Fri, 06 Nov 2015 12:00:37 -0500 - rev 305799
Bug 1219910 - make gSocketThread a relaxed atomic variable; r=mcmanus Many places that (re-)declared gSocketThread already included nsSocketTransportService2.h; we can delete the declaration for those places. For all the other places, we need to include nsSocketTransportService2.h.
173b3daa4344a15b665304b6acb6bd36bf36fdf9: Bug 1218506 - Uninitialised value use in nsHttpTransaction::OnTransportStatus. r=mcmanus.
Julian Seward <jseward@acm.org> - Tue, 03 Nov 2015 15:03:16 +0100 - rev 305132
Bug 1218506 - Uninitialised value use in nsHttpTransaction::OnTransportStatus. r=mcmanus.
fb36b34ff5f9ef03cf39acf35ad99bd8d106d066: Bug 1163030 - URL: stop escaping ` in query r=mcmanus
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 02 Nov 2015 13:55:24 +0100 - rev 304922
Bug 1163030 - URL: stop escaping ` in query r=mcmanus
c626dc6dc4fbf2a07efe0772e85e28bf2d03674c: Bug 1163028 - URL: stop escaping [ and ] in path r=mcmanus
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 02 Nov 2015 13:54:10 +0100 - rev 304919
Bug 1163028 - URL: stop escaping [ and ] in path r=mcmanus
e86590c03dc5225c615cc5f8fb4757d93cbf1051: Bug 1213577 - Use OriginAttributes in nsHttpAuthManager, r=mcmanus
Honza Bambas <honzab.moz@firemni.cz> - Thu, 29 Oct 2015 10:43:00 +0100 - rev 304889
Bug 1213577 - Use OriginAttributes in nsHttpAuthManager, r=mcmanus
2a233dadfc4927d733e32221dafc0dd3506ac301: Bug 1219910 - make gSocketThread a relaxed atomic variable; r=mcmanus
Nathan Froyd <froydnj@mozilla.com> - Thu, 29 Oct 2015 16:47:23 -0400 - rev 304582
Bug 1219910 - make gSocketThread a relaxed atomic variable; r=mcmanus All the places that (re-)declared gSocketThread already included nsSocketTransportService2.h, so we can safely delete them.
ef3cfadfccb97588653ae06eefdac28ec447c1f6: Bug 1237775 - Change pref for network monitoring on linux to false. r=mcmanus, a=sylvestre, a=ritu FIREFOX_RELEASE_44_BASE
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 08 Jan 2016 08:06:00 +0100 - rev 304274
Bug 1237775 - Change pref for network monitoring on linux to false. r=mcmanus, a=sylvestre, a=ritu
8b07fd4f3ca5812ceeadd1a6d428dffd5f5b917f: Bug 1238010 - Turn off ClosingService. r=mcmanus, a=ritu
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 08 Jan 2016 15:10:00 -0500 - rev 304253
Bug 1238010 - Turn off ClosingService. r=mcmanus, a=ritu
9d310a41f8c220b00b0b781a88f6abe974a3eca2: Bug 1231552 - Back out 2 changesets (bug 1121800, bug 1214200) r=mcmanus a=ritu
Wes Kocher <wkocher@mozilla.com> - Wed, 23 Dec 2015 12:31:22 -0800 - rev 304102
Bug 1231552 - Back out 2 changesets (bug 1121800, bug 1214200) r=mcmanus a=ritu Backed out changeset a62a3c113e40 (bug 1214200) Backed out changeset 13db8516d365 (bug 1121800)
e68fb30045aeadb1c4b578e55e8b7ea9ddc86ea8: Bug 1224328 - Don't infinite loop when parsing headers with newlines. r=mcmanus, a=ritu
Nicholas Hurley <hurley@todesschaf.org> - Thu, 12 Nov 2015 14:44:31 -0800 - rev 303745
Bug 1224328 - Don't infinite loop when parsing headers with newlines. r=mcmanus, a=ritu
778ad533a09d4f66bc80d12bedda685f4afc0cb2: Bug 1217501 P1 Expose Accept and Accept-Language to service worker FetchEvent.request. r=mcmanus
Ben Kelly <ben@wanderview.com> - Mon, 26 Oct 2015 08:25:15 -0700 - rev 303236
Bug 1217501 P1 Expose Accept and Accept-Language to service worker FetchEvent.request. r=mcmanus
a5f81cb4dcd7ce902d955281d60c67ba03956ee5: Bug 1206298 - Part 1: Update the expiration time on the fake cache entry object for an intercepted request in the non-e10s case; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 22 Oct 2015 13:34:13 -0400 - rev 303234
Bug 1206298 - Part 1: Update the expiration time on the fake cache entry object for an intercepted request in the non-e10s case; r=mcmanus
c5279ea8d3c32fca6c945528884fcf57cb2d15ab: Bug 1213060 (part 2) - Re-add state assertion in Http2Session::OnWriteSegment. r=mcmanus
Nicholas Hurley <hurley@todesschaf.org> - Thu, 22 Oct 2015 12:48:57 -0700 - rev 303019
Bug 1213060 (part 2) - Re-add state assertion in Http2Session::OnWriteSegment. r=mcmanus
66b3e867377493e29526e8d115ead25f39138fde: Bug 1213060 (part 1) - Properly handle discarding padding in Http2Session::OnWriteSegment. r=mcmanus
Nicholas Hurley <hurley@todesschaf.org> - Mon, 26 Oct 2015 12:13:53 -0700 - rev 303018
Bug 1213060 (part 1) - Properly handle discarding padding in Http2Session::OnWriteSegment. r=mcmanus
0c7e876a69e54646265585c4363794acb9e1aedb: Bug 1217501 P1 Expose Accept and Accept-Language to service worker FetchEvent.request. r=mcmanus
Ben Kelly <ben@wanderview.com> - Mon, 26 Oct 2015 08:25:15 -0700 - rev 302906
Bug 1217501 P1 Expose Accept and Accept-Language to service worker FetchEvent.request. r=mcmanus
f008f766a0ccc85efed217b20f1b7ad92475a450: Bug 1217617 - Fixes nsURIChecker.cpp dependency on nsIURI. r=mcmanus
Yury Delendik <ydelendik@mozilla.com> - Thu, 22 Oct 2015 17:21:59 -0500 - rev 302874
Bug 1217617 - Fixes nsURIChecker.cpp dependency on nsIURI. r=mcmanus
a120a9c5014542445741878642ba6ca030da04ef: Bug 1214277 - Avoid bypassing opening a cache entry for possibly intercepted channels; r=mcmanus
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 13 Oct 2015 18:36:11 -0400 - rev 302768
Bug 1214277 - Avoid bypassing opening a cache entry for possibly intercepted channels; r=mcmanus
b26934635fa1ee30a89e3cb437019ca1a365026a: Bug 1200132 - Part2: Get IP address by calling InetAddress.getHostAddress(), r=mcmanus, rnewman
Kershaw Chang <kechang@mozilla.com> - Wed, 21 Oct 2015 02:53:00 +0200 - rev 302168
Bug 1200132 - Part2: Get IP address by calling InetAddress.getHostAddress(), r=mcmanus, rnewman