Bug 1224100 - Initialize padding to 0 in Downscaler. r=seth, a=sledru
authorEdwin Flores <eflores@mozilla.com>
Wed, 02 Dec 2015 16:15:29 +0100 (2015-12-02)
changeset 260867 f6c1116a4295f5b7174a53ab4fb151e00ab240ea
parent 260866 57d0fb011812ef70b9b94543a03c55477f163d23
child 260868 a2285d85d6dcd98a8c0393ffdfe0dae0b7bd8dbe
child 260870 a6a4c3c03cb67a5243e6257b967a23839cda3779
child 260871 07df110a15c836e59d184e43309520dfc9936917
push id227
push userryanvm@gmail.com
push dateMon, 14 Dec 2015 20:43:20 +0000 (2015-12-14)
treeherdermozilla-esr38@f6c1116a4295 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersseth, sledru
bugs1224100
milestone38.5.0esrpre
Bug 1224100 - Initialize padding to 0 in Downscaler. r=seth, a=sledru
image/src/Downscaler.cpp
--- a/image/src/Downscaler.cpp
+++ b/image/src/Downscaler.cpp
@@ -81,21 +81,26 @@ Downscaler::BeginFrame(const nsIntSize& 
                                mTargetSize.width, 0,
                                mTargetSize.width, mXFilter.get());
 
   skia::resize::ComputeFilters(resizeMethod, mOriginalSize.height,
                                mTargetSize.height, 0,
                                mTargetSize.height, mYFilter.get());
 
   // Allocate the buffer, which contains scanlines of the original image.
-  mRowBuffer = MakeUnique<uint8_t[]>(mOriginalSize.width * sizeof(uint32_t));
+  size_t bufferLen = mOriginalSize.width * sizeof(uint32_t);
+  mRowBuffer = MakeUnique<uint8_t[]>(bufferLen);
   if (MOZ_UNLIKELY(!mRowBuffer)) {
     return NS_ERROR_OUT_OF_MEMORY;
   }
 
+  // Zero buffer to keep valgrind happy.
+  memset(mRowBuffer.get(), 0, bufferLen);
+
+
   // Allocate the window, which contains horizontally downscaled scanlines. (We
   // can store scanlines which are already downscale because our downscaling
   // filter is separable.)
   mWindowCapacity = mYFilter->max_filter();
   mWindow = MakeUnique<uint8_t*[]>(mWindowCapacity);
   if (MOZ_UNLIKELY(!mWindow)) {
     return NS_ERROR_OUT_OF_MEMORY;
   }