searching for reviewer(brendan)
6c236b24064bbd67c167165cd5958c2b432df7a1: Bug 882485 - Add API keys support for Google Location Service API. r=gps, jdm, gavin. sr=brendan
Doug Turner <doug.turner@gmail.com> - Wed, 12 Jun 2013 19:20:07 -0700 - rev 147528
Bug 882485 - Add API keys support for Google Location Service API. r=gps, jdm, gavin. sr=brendan
e40466e428dcfcdb7567defb9ad62322315d8583: Bug 853301 - Enable ECMAScript Internationalization API for desktop Firefox. r=gps, r=brendan, sr=asa
Norbert Lindenberg <mozilladev@lindenbergsoftware.com> - Mon, 06 May 2013 16:45:25 -0700 - rev 142038
Bug 853301 - Enable ECMAScript Internationalization API for desktop Firefox. r=gps, r=brendan, sr=asa
390be7c3dd3af133b30169e35cc59f8894d4b006: Bug 853301 - Enable ECMAScript Internationalization API for desktop Firefox. r=gps, r=brendan, sr=asa
Norbert Lindenberg <mozilladev@lindenbergsoftware.com> - Sat, 13 Apr 2013 12:27:27 -0400 - rev 139658
Bug 853301 - Enable ECMAScript Internationalization API for desktop Firefox. r=gps, r=brendan, sr=asa
bf3ce88c6ea35d0a5d94da40595c0062451f2b0d: Bug 846406 - Implement arrow functions. r=bhackett. Changes to Y.js r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Sun, 17 Mar 2013 20:42:36 -0700 - rev 135716
Bug 846406 - Implement arrow functions. r=bhackett. Changes to Y.js r=brendan.
bffcfc510a9cac94f1a8700e327951a4019cd847: Bug 618479 part 2. Use binary, not linear, search to determine timer insertion locations. r=brendan
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Feb 2013 10:11:53 -0500 - rev 131621
Bug 618479 part 2. Use binary, not linear, search to determine timer insertion locations. r=brendan
22b5a4e8c639b2e706ce12215e66be64a5509382: Bug 827816 - Follow up: whitespaces, No empty { }, rs=brendan, r=Waldo
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 11 Jan 2013 00:54:45 +0100 - rev 128426
Bug 827816 - Follow up: whitespaces, No empty { }, rs=brendan, r=Waldo
5a88ed3a3ace65a94211cbf5630df951cb50ae23: Bug 827816 - Wrong timezone offset for UK and Ireland as they had year-round DST from 1969-1971, r=brendan, r=gal
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 11 Jan 2013 00:24:34 +0100 - rev 128361
Bug 827816 - Wrong timezone offset for UK and Ireland as they had year-round DST from 1969-1971, r=brendan, r=gal
82e8e26799383fb3c9699f8e2ea0f9876dae643c: Bug 786136 - Fix invalid conversion in return; r=brendan
Terrence Cole <terrence@mozilla.com> - Fri, 31 Aug 2012 11:14:27 -0700 - rev 110339
Bug 786136 - Fix invalid conversion in return; r=brendan
21f18a7f5f9dabda3fb0d5ee2367af311e3b9e5a: Bug 775243 - Create top-level directory for Python; r=brendan
Gregory Szorc <gps@mozilla.com> - Tue, 24 Jul 2012 13:59:37 -0700 - rev 105805
Bug 775243 - Create top-level directory for Python; r=brendan
cf890c9c3e4c1514e3f6583d6fde256cd59be738: Bug 701371 - Rename mozutils to mozglue, and move it to top-level. r=khuey,a=brendan
Mike Hommey <mh+mozilla@glandium.org> - Wed, 28 Dec 2011 08:24:02 +0100 - rev 86528
Bug 701371 - Rename mozutils to mozglue, and move it to top-level. r=khuey,a=brendan
185d4aa163bce923be44f4e5ca5c6ae69d2e9c62: Bug 701371 - Rename mozutils to mozglue, and move it to top-level. r=khuey,a=brendan,a=blassey
Mike Hommey <mh+mozilla@glandium.org> - Wed, 28 Dec 2011 08:24:02 +0100 - rev 85106
Bug 701371 - Rename mozutils to mozglue, and move it to top-level. r=khuey,a=brendan,a=blassey
6b839530a88aba110b69c8ead1df5d1d77ee63a7: Bug 697279 - Properly disable some E4X opcodes in strict mode. r=brendan
Tom Schuster <evilpies@gmail.com> - Mon, 14 Nov 2011 20:43:33 +0100 - rev 81864
Bug 697279 - Properly disable some E4X opcodes in strict mode. r=brendan
bdbdde9ab432abde409bf1be9322bff54b4e925c: Bug 691001 part 2. AppendAttributeValue escapes values without creating transient StringBuffer and JSFlatString. r=brendan
Andrew Paprocki <andrew@ishiboo.com> - Mon, 24 Oct 2011 21:46:35 -0400 - rev 80589
Bug 691001 part 2. AppendAttributeValue escapes values without creating transient StringBuffer and JSFlatString. r=brendan
2fef1412e0e8ec4ef8b60f0c4194907ac17bc58f: Bug 691001 part 1. Hoist property check out of tight loop / prevent unnecessary Namespace object creation. r=brendan
Andrew Paprocki <andrew@ishiboo.com> - Mon, 24 Oct 2011 21:45:17 -0400 - rev 80588
Bug 691001 part 1. Hoist property check out of tight loop / prevent unnecessary Namespace object creation. r=brendan
0a5e72d1b479b9f015a407e33e9001e5ad0aa786: Bug 128502 - Move imagelib to mozilla/image on a CLOSED TREE. r=joe,brendan
Bobby Holley <bobbyholley@gmail.com> - Mon, 17 Oct 2011 21:32:45 -0700 - rev 80191
Bug 128502 - Move imagelib to mozilla/image on a CLOSED TREE. r=joe,brendan
ff19f221eecaa8b8f8017fa025e67e00cfbeeb36: Bug 685025 - Shell should be able to read from stdin. (r=brendan)
Chris Leary <cdleary@mozilla.com> - Wed, 14 Sep 2011 17:00:59 -0700 - rev 78022
Bug 685025 - Shell should be able to read from stdin. (r=brendan)
1a29139e6bafb68172bebb92f4208762aa939367: Bug 676343 - Lexical scoping bug involving UPVAR_LEVEL_LIMIT. r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 01 Sep 2011 11:31:09 -0500 - rev 77436
Bug 676343 - Lexical scoping bug involving UPVAR_LEVEL_LIMIT. r=brendan.
a2ccd2c8e545299cbca6b55a8069253ee121cb2a: Add local and argument closure information to JSScript (bug 592973, r=brendan+dmandelin).
David Anderson <danderson@mozilla.com> - Mon, 13 Sep 2010 22:33:44 -0700 - rev 75359
Add local and argument closure information to JSScript (bug 592973, r=brendan+dmandelin).
99e1b185792f0fcd5b5361554a8f32a177c12b8b: Add local and argument closure information to JSScript (bug 592973, r=brendan+dmandelin).
David Anderson <danderson@mozilla.com> - Mon, 13 Sep 2010 22:33:44 -0700 - rev 75353
Add local and argument closure information to JSScript (bug 592973, r=brendan+dmandelin).
3d11e994ad09447b115ea1f57f354f1bfa521f5c: Add local and argument closure information to JSScript (bug 592973, r=brendan+dmandelin).
David Anderson <danderson@mozilla.com> - Mon, 13 Sep 2010 22:33:44 -0700 - rev 75347
Add local and argument closure information to JSScript (bug 592973, r=brendan+dmandelin).
13c14153bd63ae9421ebaeb8ca4c62cfc148acb6: Bug 667925 - Line number is bogus on JSOP_TRACE opcodes. r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 28 Jun 2011 12:15:32 -0500 - rev 75256
Bug 667925 - Line number is bogus on JSOP_TRACE opcodes. r=brendan.
a73864715b24a901f2ce8b5535ca791bce847a60: Bug 673070 - Fix name lookups in let scopes a bit more ("Assertion failure: sharedBlock" with e4x after fixing bug 646968). r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 03 Aug 2011 20:13:56 -0500 - rev 74586
Bug 673070 - Fix name lookups in let scopes a bit more ("Assertion failure: sharedBlock" with e4x after fixing bug 646968). r=brendan.
2d63d7fd35a010e9c4e63762eee4fd9d51921a4e: Bug 671150 - Add memory reporter for the JS PropertyTable. r=brendan.
Nicholas Nethercote <nnethercote@mozilla.com> - Sun, 24 Jul 2011 17:00:56 -0700 - rev 74054
Bug 671150 - Add memory reporter for the JS PropertyTable. r=brendan.
a8224422f7c6f48be324d7ce2e0603a00519edc5: Bug 669434 - Fix obscure bugs in CompileFileHelper. r=brendan.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 14 Jul 2011 19:40:23 -0700 - rev 73660
Bug 669434 - Fix obscure bugs in CompileFileHelper. r=brendan. H:Bug 669434 - Fix obscure bugs in CompileFileHelper. r=brendan. ubranch 'default'
69dfa4008531b4ca2fb68d60a820ae639adbe292: Bug 646968 - Fix name lookups in let scopes. r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 14 Jul 2011 08:54:17 -0500 - rev 73627
Bug 646968 - Fix name lookups in let scopes. r=brendan.
9c4e42005bffeca72dd009adbf5d06488f50b65d: Bug 620316 - Remove WrapEscapingClosure. r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 13 Jul 2011 07:15:59 -0500 - rev 73533
Bug 620316 - Remove WrapEscapingClosure. r=brendan.
9bc361598877f9478c0c78998332287d91d965d2: Bug 670487 - Fix prototype to eliminate a compiler warning in js/src/editline. r=brendan.
Cyril Roelandt <tipecaml@gmail.com> - Tue, 12 Jul 2011 13:14:37 -0500 - rev 73517
Bug 670487 - Fix prototype to eliminate a compiler warning in js/src/editline. r=brendan.
2d5bc18fdf9c40ee4d86411fb2713c8094814092: Fix prototype to eliminate a compiler warning in js/src/editline. r=brendan.
Cyril Roelandt <tipecaml@gmail.com> - Tue, 12 Jul 2011 13:14:37 -0500 - rev 73514
Fix prototype to eliminate a compiler warning in js/src/editline. r=brendan.
756abc094eb18c5bd5c6645225d6108691392a27: Bug 627859: Use the standard placeholder-making function when re-scoping variable references in generator 'yield' expressions. r=brendan
Jim Blandy <jimb@mozilla.com> - Wed, 29 Jun 2011 02:11:08 -0700 - rev 72871
Bug 627859: Use the standard placeholder-making function when re-scoping variable references in generator 'yield' expressions. r=brendan CompExprTransplanter::transplant did a bunch of bespoke pointer-fiddling to take the free variable references in the 'yield' expression and re-scope them within the comprehension tail clauses. That code incorrectly constructed placeholders for function references; this was fixed in bug 576847. However, it would also work to simply use the same placeholder construction function everybody else does. This patch makes it so.
0908448636c50191cd6063cd1cbc126a864b3d16: Bug 645922 - Remove nsIJSON.encode/decode, because their functionality is subsumed by JSON.parse and JSON.stringify, and their idiosyncrasies are hindering code improvements. Also remove js_TryJSON and JS_TryJSON, which are no longer used after these changes and have no clear use cases. r=brendan, r=jst
Jeff Walden <jwalden@mit.edu> - Mon, 28 Mar 2011 19:27:15 -0700 - rev 72865
Bug 645922 - Remove nsIJSON.encode/decode, because their functionality is subsumed by JSON.parse and JSON.stringify, and their idiosyncrasies are hindering code improvements. Also remove js_TryJSON and JS_TryJSON, which are no longer used after these changes and have no clear use cases. r=brendan, r=jst
fbd4e4a84bb923b32cad64ba2cce2317c89d437f: Fix for bug 659581 (Clear debugger activation callback after calling it). r=brendan.
Peter Van der Beken <peterv@propagandism.org> - Wed, 25 May 2011 10:46:51 +0200 - rev 72337
Fix for bug 659581 (Clear debugger activation callback after calling it). r=brendan.
56b2068a28ea86a7477fc08d858c44f4989fb491: Bug 15529 - Add missing copyright boilerplate to files in js/src, remove dead files (r=brendan,graydon,jimb)
Luke Wagner <luke@mozilla.com> - Tue, 21 Jun 2011 10:26:22 -0700 - rev 72001
Bug 15529 - Add missing copyright boilerplate to files in js/src, remove dead files (r=brendan,graydon,jimb)
5fe20ec0229c0f3db3b49f53c07896944fb8b42d: Bug 15529 - Add missing copyright boilerplate to files in js/src, remove dead files (r=brendan,graydon,jimb)
Luke Wagner <luke@mozilla.com> - Tue, 21 Jun 2011 10:26:22 -0700 - rev 71969
Bug 15529 - Add missing copyright boilerplate to files in js/src, remove dead files (r=brendan,graydon,jimb)
38f994208a4698546db7b9ea6bb49a96b0587211: Bug 316661 - Remove null-checks before delete: Part B; r=pbiggar,brendan,bzbarsky
Ed Morley <bmo@edmorley.co.uk> - Wed, 01 Jun 2011 03:07:00 -0700 - rev 71179
Bug 316661 - Remove null-checks before delete: Part B; r=pbiggar,brendan,bzbarsky
54097e09fa359de7fc4851e5ba175612760e64e9: Bug 556214, part 2: Create non-reentrant Monitor. r=roc sr=brendan
Chris Jones <jones.chris.g@gmail.com> - Fri, 29 Apr 2011 14:21:57 -0500 - rev 69028
Bug 556214, part 2: Create non-reentrant Monitor. r=roc sr=brendan
a78968ac5bbbc912fd1b933ceb085f08510ac388: Bug 650379. Add a new XPCOM timer type that is like TYPE_REPEATING_PRECISE but does not swamp the event queue if the callback takes longer than the timer interval to run. r=cjones, sr=brendan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 28 Apr 2011 19:33:52 -0400 - rev 68980
Bug 650379. Add a new XPCOM timer type that is like TYPE_REPEATING_PRECISE but does not swamp the event queue if the callback takes longer than the timer interval to run. r=cjones, sr=brendan This implements proposal 3 from bug 650379 comment 13. The main difference between TYPE_REPEATING_PRECISE and TYPE_REPEATING_PRECISE_CAN_SKIP is to not AddTimer the REPEATING_PRECISE_CAN_SKIP timer until after the callback has run; this guarantees that no more timer events will be posted until after the callback finishes executing. A secondary change is to make REPEATING_PRECISE_CAN_SKIP timers advance their firing time to mDelay from when PostTimerEvent is called, not mDelay from the old mTimeout. While this arguably makes them less precise, the alternative is that if a timer is significantly delayed for some reason (e.g. because the user puts the computer to sleep for a while) it will then fire a whole bunch of times to "catch up" to where it's supposed to be, advancing its firing time by mDelay at a time. That seems undesirable. An alternate approach would have been to readd the timer from inside PostTimerEvent, but only if we're not in the middle of firing the timer. That would allow more precise timers in the case when the callback is not taking too long, but still handle gracefully the case when the callback is slow. Unfortunately this falls down if something _else_ is hogging the main thread event loop (e.g. some other timer has a slow callback, or whatever); in that case we would post multiple events for the one precise timer while the event-loop-hogging operation is running. So I don't think we should do that.
bc0e295346e75972cd31d0c26b2bf674d1f541db: Bug 646820 - Function in destructuring assignment can't see up to other variables in the assignment. r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 18 Apr 2011 12:49:57 -0500 - rev 68808
Bug 646820 - Function in destructuring assignment can't see up to other variables in the assignment. r=brendan.
87fc73e2264fbc9ab246069ca1888af585d2ea6b: Bug 646807 - Remove extra RHS checking in CheckDestructuring. r=brendan.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 18 Apr 2011 12:47:55 -0500 - rev 68807
Bug 646807 - Remove extra RHS checking in CheckDestructuring. r=brendan.
556ec2a89192a590b77c62064e97a02e22d4dbbe: for-in loop on proxy does not suppress properties deleted during enumeration (bug 600702, r=brendan)
Andreas Gal <gal@mozilla.com> - Sat, 16 Apr 2011 14:51:18 -0700 - rev 68795
for-in loop on proxy does not suppress properties deleted during enumeration (bug 600702, r=brendan)
f7eaddcc2abfa236611234b56e9149492611eb3c: Bug 649819 - Remove JS_BeginJSONParse/JS_ConsumeJSONText/JS_EndJSONParse now that these APIs are no longer used and the cleaner API is available and works. r=brendan
Jeff Walden <jwalden@mit.edu> - Mon, 21 Mar 2011 11:42:14 -0700 - rev 68786
Bug 649819 - Remove JS_BeginJSONParse/JS_ConsumeJSONText/JS_EndJSONParse now that these APIs are no longer used and the cleaner API is available and works. r=brendan
d50f943c21e3546eb8e38f3024a78cdeed48304a: Fix bug 643839. r=brendan, a=clegnitto
Brian Hackett <bhackett1024@gmail.com> - Fri, 22 Apr 2011 12:32:44 -0700 - rev 68678
Fix bug 643839. r=brendan, a=clegnitto
916afbf329b71d84eb9ad47995482251c1ad0b0c: Bug 650379. Add a new XPCOM timer type that is like TYPE_REPEATING_PRECISE but does not swamp the event queue if the callback takes longer than the timer interval to run. r=cjones, sr=brendan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 28 Apr 2011 19:33:52 -0400 - rev 68083
Bug 650379. Add a new XPCOM timer type that is like TYPE_REPEATING_PRECISE but does not swamp the event queue if the callback takes longer than the timer interval to run. r=cjones, sr=brendan This implements proposal 3 from bug 650379 comment 13. The main difference between TYPE_REPEATING_PRECISE and TYPE_REPEATING_PRECISE_CAN_SKIP is to not AddTimer the REPEATING_PRECISE_CAN_SKIP timer until after the callback has run; this guarantees that no more timer events will be posted until after the callback finishes executing. A secondary change is to make REPEATING_PRECISE_CAN_SKIP timers advance their firing time to mDelay from when PostTimerEvent is called, not mDelay from the old mTimeout. While this arguably makes them less precise, the alternative is that if a timer is significantly delayed for some reason (e.g. because the user puts the computer to sleep for a while) it will then fire a whole bunch of times to "catch up" to where it's supposed to be, advancing its firing time by mDelay at a time. That seems undesirable. An alternate approach would have been to readd the timer from inside PostTimerEvent, but only if we're not in the middle of firing the timer. That would allow more precise timers in the case when the callback is not taking too long, but still handle gracefully the case when the callback is slow. Unfortunately this falls down if something _else_ is hogging the main thread event loop (e.g. some other timer has a slow callback, or whatever); in that case we would post multiple events for the one precise timer while the event-loop-hogging operation is running. So I don't think we should do that.
bfdb6e623a36158abce0cbae1d89713236acd0d6: Fix bug 643839. r=brendan, a=clegnitto
Brian Hackett <bhackett1024@gmail.com> - Fri, 22 Apr 2011 12:29:30 -0700 - rev 68054
Fix bug 643839. r=brendan, a=clegnitto
90fa43dcb844d2f2051a3cdfe9ad00d3268d0ff9: Function.isGenerator (bug 648355, r=brendan)
Dave Herman <dherman@mozilla.com> - Fri, 08 Apr 2011 13:31:14 -0700 - rev 67935
Function.isGenerator (bug 648355, r=brendan)
37e5a7fe49efa374d2259280cee36b7851aedda7: Bug 636654 - Extract large cold chunks (e4x, @lines) from getTokenInternal(). r=brendan.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 04 Apr 2011 18:54:48 -0700 - rev 67917
Bug 636654 - Extract large cold chunks (e4x, @lines) from getTokenInternal(). r=brendan.
bd821ea0ad41b971740e687206c1ed4305b401e0: Maintain a list of IdArrays as we hand them out via JS API (638324, r=brendan).
Andreas Gal <gal@mozilla.com> - Thu, 31 Mar 2011 14:42:33 -0700 - rev 67896
Maintain a list of IdArrays as we hand them out via JS API (638324, r=brendan).
91a8d742c50969c39ff61709039f9670a9c5f9ce: Bug 577899, part 1: Add mfbt, to contain code shared between SpiderMonkey and Gecko. r=luke,ted sr=brendan,bsmedberg,roc
Chris Jones <jones.chris.g@gmail.com> - Thu, 31 Mar 2011 20:46:35 -0500 - rev 64572
Bug 577899, part 1: Add mfbt, to contain code shared between SpiderMonkey and Gecko. r=luke,ted sr=brendan,bsmedberg,roc
d796fb18f555b76abfa6ac287e8c3f3760c6346e: Bug 643548: Remove mozalloc_undef_macro_wrappers hack from JS engine. (r=luke,rs=brendan)
Paul Biggar <pbiggar@mozilla.com> - Thu, 31 Mar 2011 01:14:12 -0700 - rev 64560
Bug 643548: Remove mozalloc_undef_macro_wrappers hack from JS engine. (r=luke,rs=brendan) mozalloc_undef_macro_wrappers are brittle and have side-effects that are hard to debug and fix. The alternative is the just stick an underscore on the end of malloc, free, etc, which is a comparatively small burden.
4629abbde2f742fd930941bf1208da172157f2f9: Bug 636224 - rm cx->interpLevel and TSF_ERROR (r=brendan)
Luke Wagner <lw@mozilla.com> - Wed, 23 Mar 2011 14:33:02 -0700 - rev 64386
Bug 636224 - rm cx->interpLevel and TSF_ERROR (r=brendan)
0ffe53f7606aca45d4cedcc880afff2feeadccd9: Bug 637549 - Speed up expression parsing, part 2: inline more aggressively. r=brendan,jimb.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 23 Mar 2011 18:00:20 -0700 - rev 64367
Bug 637549 - Speed up expression parsing, part 2: inline more aggressively. r=brendan,jimb.