Bug 1814656 - Fix typo. r=adw, a=dmeehan default tip
authorDão Gottwald <dao@mozilla.com>
Fri, 03 Feb 2023 03:15:38 +0000
changeset 721208 733a825d7a4496aa8012f38a445ea3be441dccd0
parent 721207 6354716b245b831082dd3ecea4091327f9998e58
push id17531
push userdmeehan@mozilla.com
push dateFri, 03 Feb 2023 20:35:07 +0000
treeherdermozilla-beta@733a825d7a44 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersadw, dmeehan
bugs1814656
milestone110.0
Bug 1814656 - Fix typo. r=adw, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D168701
browser/components/urlbar/UrlbarView.sys.mjs
--- a/browser/components/urlbar/UrlbarView.sys.mjs
+++ b/browser/components/urlbar/UrlbarView.sys.mjs
@@ -1374,17 +1374,17 @@ export class UrlbarView {
       (oldResultType == lazy.UrlbarUtils.RESULT_TYPE.DYNAMIC &&
         result.type == lazy.UrlbarUtils.RESULT_TYPE.DYNAMIC &&
         oldResult.payload.dynamicType != result.payload.dynamicType) ||
       // Dynamic results that implement getViewTemplate will
       // always need updating.
       provider.getViewTemplate ||
       oldResult.isBestMatch != result.isBestMatch ||
       (!lazy.UrlbarPrefs.get("resultMenu") &&
-        (!!result.payload.helpUrl != item._buttons.has("block") ||
+        (!!result.payload.helpUrl != item._buttons.has("help") ||
           !!result.payload.isBlockable != item._buttons.has("block"))) ||
       !!this.#getResultMenuCommands(result) != item._buttons.has("menu") ||
       !lazy.ObjectUtils.deepEqual(
         oldResult.payload.buttons,
         result.payload.buttons
       );
 
     if (needsNewContent) {