Bug 1636511 - Disable the OS auth feature in about:logins on Release and Beta. r=MattN a=pascalc
authorJared Wein <jwein@mozilla.com>
Tue, 12 May 2020 02:00:19 +0000
changeset 591447 ffcc347d3059b0ede9d1a63e341f3302c22df5b7
parent 591446 9da87bb136d5dfcee2475925916c67c993c2a1b7
child 591448 91b0701266a78a946ff055c3f73552bda433e43a
push id13129
push userarchaeopteryx@coole-files.de
push dateThu, 14 May 2020 09:34:28 +0000
treeherdermozilla-beta@ffcc347d3059 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN, pascalc
bugs1636511
milestone77.0
Bug 1636511 - Disable the OS auth feature in about:logins on Release and Beta. r=MattN a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D74676
browser/app/profile/firefox.js
browser/components/aboutlogins/tests/browser/browser.ini
browser/components/preferences/tests/browser.ini
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1715,17 +1715,17 @@ pref("browser.migrate.chrome.history.max
 pref("extensions.pocket.api", "api.getpocket.com");
 pref("extensions.pocket.enabled", true);
 pref("extensions.pocket.oAuthConsumerKey", "40249-e88c401e1b1f2242d9e441c4");
 pref("extensions.pocket.site", "getpocket.com");
 
 // Can be removed once Bug 1618058 is resolved.
 pref("signon.generation.confidenceThreshold", "0.75");
 
-pref("signon.management.page.os-auth.enabled", true);
+pref("signon.management.page.os-auth.enabled", false);
 pref("signon.management.page.breach-alerts.enabled", true);
 pref("signon.management.page.vulnerable-passwords.enabled", true);
 pref("signon.management.page.sort", "name");
 // The utm_creative value is appended within the code (specific to the location on
 // where it is clicked). Be sure that if these two prefs are updated, that
 // the utm_creative param be last.
 pref("signon.management.page.mobileAndroidURL", "https://app.adjust.com/6tteyjo?redirect=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dmozilla.lockbox&utm_campaign=Desktop&utm_adgroup=InProduct&utm_creative=");
 pref("signon.management.page.mobileAppleURL", "https://app.adjust.com/6tteyjo?redirect=https%3A%2F%2Fitunes.apple.com%2Fapp%2Fid1314000270%3Fmt%3D8&utm_campaign=Desktop&utm_adgroup=InProduct&utm_creative=");
--- a/browser/components/aboutlogins/tests/browser/browser.ini
+++ b/browser/components/aboutlogins/tests/browser/browser.ini
@@ -1,13 +1,14 @@
 [DEFAULT]
 support-files =
   head.js
 prefs =
   signon.management.page.vulnerable-passwords.enabled=true
+  signon.management.page.os-auth.enabled=true
 
 # Run first so content events from previous tests won't trickle in.
 # Skip ASAN and debug since waiting for content events is already slow.
 [browser_aaa_eventTelemetry_run_first.js]
 skip-if = asan || ccov || debug || (os == "win" && !debug) # bug 1605494 is more prevalent on linux, Bug 1627419
 [browser_alertDismissedAfterChangingPassword.js]
 [browser_breachAlertShowingForAddedLogin.js]
 [browser_confirmDeleteDialog.js]
--- a/browser/components/preferences/tests/browser.ini
+++ b/browser/components/preferences/tests/browser.ini
@@ -1,12 +1,13 @@
 [DEFAULT]
 prefs =
   extensions.formautofill.available='on'
   extensions.formautofill.creditCards.available=true
+  signon.management.page.os-auth.enabled=true
 support-files =
   head.js
   privacypane_tests_perwindow.js
   addons/pl-dictionary.xpi
   addons/set_homepage.xpi
   addons/set_newtab.xpi
 
 [browser_applications_selection.js]