Bug 853707 - Fix bogus assert in StaticBehaviour::SetOwner. r=joedrew
authorAndrew McCreight <amccreight@mozilla.com>
Tue, 02 Apr 2013 17:48:42 -0700
changeset 139638 ffa16f20870a3cb2bc27f2c089022fcbbe4d061e
parent 139637 fd6c7792b0489a2f73a3bd28004d6bbb3fb166ad
child 139639 0867fa1dfe4bc9ed03e36f50d7df26d370782fea
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjoedrew
bugs853707
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 853707 - Fix bogus assert in StaticBehaviour::SetOwner. r=joedrew
image/src/imgRequestProxy.cpp
--- a/image/src/imgRequestProxy.cpp
+++ b/image/src/imgRequestProxy.cpp
@@ -1009,17 +1009,17 @@ public:
     return mImage->GetStatusTracker();
   }
 
   virtual imgRequest* GetOwner() const MOZ_OVERRIDE {
     return nullptr;
   }
 
   virtual void SetOwner(imgRequest* aOwner) MOZ_OVERRIDE {
-    MOZ_ASSERT_IF(aOwner, "We shouldn't be giving static requests a non-null owner.");
+    MOZ_ASSERT(!aOwner, "We shouldn't be giving static requests a non-null owner.");
   }
 
 private:
   // Our image. We have to hold a strong reference here, because that's normally
   // the job of the underlying request.
   nsRefPtr<mozilla::image::Image> mImage;
 };