Backed out changeset 0a5a34ef66d1 (bug 1388998) for mass test failures during shutdown. r=backout on a CLOSED TREE
authorSebastian Hengst <archaeopteryx@coole-files.de>
Mon, 02 Oct 2017 17:25:14 +0200
changeset 434763 ff5340cbaef07b5e3fa8b53e386467dd7f044145
parent 434762 0ad5ea4a3f1cda04e949cdae7e2c22f54d44d476
child 434764 507feca45d0b0282747a2782d1bf9741bd1412e0
push id8114
push userjlorenzo@mozilla.com
push dateThu, 02 Nov 2017 16:33:21 +0000
treeherdermozilla-beta@73e0d89a540f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1388998
milestone58.0a1
backs out0a5a34ef66d11be4c0b64e873e05d84896f3a994
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 0a5a34ef66d1 (bug 1388998) for mass test failures during shutdown. r=backout on a CLOSED TREE
storage/mozStorageService.cpp
--- a/storage/mozStorageService.cpp
+++ b/storage/mozStorageService.cpp
@@ -304,25 +304,18 @@ Service::unregisterConnection(Connection
 
     for (uint32_t i = 0 ; i < mConnections.Length(); ++i) {
       if (mConnections[i] == aConnection) {
         nsCOMPtr<nsIThread> thread = mConnections[i]->threadOpenedOn;
 
         // Ensure the connection is released on its opening thread.  Note, we
         // must use .forget().take() so that we can manually cast to an
         // unambiguous nsISupports type.
-        //
-        // We specify aAlwaysProxy=true because if we don't, the destructor for
-        // the connection will be invoked if the connection is owned by the
-        // main thread.  And since the Connection destructor calls Close() and
-        // that may in turn call SpinningSynchronousClose() if the connection
-        // was not properly shutdown, that can lead to re-entrancy problems.
         NS_ProxyRelease(
-          "storage::Service::mConnections", thread, mConnections[i].forget(),
-          true);
+          "storage::Service::mConnections", thread, mConnections[i].forget());
 
         mConnections.RemoveElementAt(i);
         return;
       }
     }
 
     MOZ_ASSERT_UNREACHABLE("Attempt to unregister unknown storage connection!");
   }