Bug 926323 - Tilt tests should unregister observers to prevent errors later on when scopes are dead, r=vporof
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 14 Oct 2013 11:54:46 +0200
changeset 164444 ff0cb6c1f106c3a5419bd0f7a9463d39421f7959
parent 164443 a4c2df11b142bbca37f7fd5e878347a00fce8b3e
child 164445 b6dfeb4a34c89a3c6409f62d4babd1b515dbce33
push id3066
push userakeybl@mozilla.com
push dateMon, 09 Dec 2013 19:58:46 +0000
treeherdermozilla-beta@a31a0dce83aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvporof
bugs926323
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 926323 - Tilt tests should unregister observers to prevent errors later on when scopes are dead, r=vporof
browser/devtools/tilt/test/browser_tilt_02_notifications-seq.js
browser/devtools/tilt/test/browser_tilt_02_notifications.js
--- a/browser/devtools/tilt/test/browser_tilt_02_notifications-seq.js
+++ b/browser/devtools/tilt/test/browser_tilt_02_notifications-seq.js
@@ -89,12 +89,13 @@ function cleanup() {
   info("Cleaning up the notifications test.");
 
   Services.obs.removeObserver(finalize, DESTROYED);
   Services.obs.removeObserver(obs_INITIALIZING, INITIALIZING);
   Services.obs.removeObserver(obs_INITIALIZED, INITIALIZED);
   Services.obs.removeObserver(obs_DESTROYING, DESTROYING);
   Services.obs.removeObserver(obs_BEFORE_DESTROYED, BEFORE_DESTROYED);
   Services.obs.removeObserver(obs_DESTROYED, DESTROYED);
+  Services.obs.removeObserver(obs_STARTUP, STARTUP);
 
   gBrowser.removeCurrentTab();
   finish();
 }
--- a/browser/devtools/tilt/test/browser_tilt_02_notifications.js
+++ b/browser/devtools/tilt/test/browser_tilt_02_notifications.js
@@ -113,16 +113,17 @@ function cleanup() {
   tab0 = null;
   tab1 = null;
 
   Services.obs.removeObserver(finalize, DESTROYED);
   Services.obs.removeObserver(tab_INITIALIZING, INITIALIZING);
   Services.obs.removeObserver(tab_DESTROYING, DESTROYING);
   Services.obs.removeObserver(tab_SHOWN, SHOWN);
   Services.obs.removeObserver(tab_HIDDEN, HIDDEN);
+  Services.obs.removeObserver(tab_STARTUP, STARTUP);
 
   gBrowser.tabContainer.removeEventListener("TabSelect", tabSelect);
   gBrowser.removeCurrentTab();
   finish();
 }
 
 function tabSelect() {
   if (testStep !== -1) {