Bug 1130203 - Add @dimen/button_corner_radius and replace corner radius use in code. r=mhaigh a=sylvestre
authorMichael Comella <michael.l.comella@gmail.com>
Fri, 27 Feb 2015 14:55:32 -0800
changeset 258339 feb7a6808bfb
parent 258338 9a5a28809525
child 258340 5dd03a21c376
push id4648
push usermichael.l.comella@gmail.com
push date2015-04-08 16:26 +0000
treeherdermozilla-beta@e399294c9df3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh, sylvestre
bugs1130203
milestone38.0
Bug 1130203 - Add @dimen/button_corner_radius and replace corner radius use in code. r=mhaigh a=sylvestre Note that this does not include fxaccount_* which needs to exist in fxaccount_dimens so it can be used in the detached sync repo.
mobile/android/base/resources/drawable/firstrun_button_enabled.xml
mobile/android/base/resources/drawable/firstrun_button_pressed.xml
mobile/android/base/resources/drawable/remote_tabs_setup_button_background.xml
mobile/android/base/resources/values/dimens.xml
--- a/mobile/android/base/resources/drawable/firstrun_button_enabled.xml
+++ b/mobile/android/base/resources/drawable/firstrun_button_enabled.xml
@@ -2,10 +2,10 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
        android:shape="rectangle" >
   <solid android:color="@color/firstrun_pager_button" />
   <corners
-      android:radius="@dimen/fxaccount_corner_radius" />
+      android:radius="@dimen/button_corner_radius" />
 </shape>
--- a/mobile/android/base/resources/drawable/firstrun_button_pressed.xml
+++ b/mobile/android/base/resources/drawable/firstrun_button_pressed.xml
@@ -2,10 +2,10 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
        android:shape="rectangle" >
   <solid android:color="@color/firstrun_pager_button_pressed" />
   <corners
-      android:radius="@dimen/fxaccount_corner_radius" />
+      android:radius="@dimen/button_corner_radius" />
 </shape>
--- a/mobile/android/base/resources/drawable/remote_tabs_setup_button_background.xml
+++ b/mobile/android/base/resources/drawable/remote_tabs_setup_button_background.xml
@@ -2,19 +2,19 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
     <item android:state_pressed="true">
         <shape android:shape="rectangle">
             <solid android:color="@color/remote_tabs_setup_button_background_hit"/>
-            <corners android:radius="@dimen/fxaccount_corner_radius"/>
+            <corners android:radius="@dimen/button_corner_radius"/>
         </shape>
     </item>
 
     <item>
         <shape android:shape="rectangle">
             <solid android:color="@color/remote_tabs_setup_button_background"/>
-            <corners android:radius="@dimen/fxaccount_corner_radius"/>
+            <corners android:radius="@dimen/button_corner_radius"/>
         </shape>
     </item>
 </selector>
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -1,15 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <resources>
 
+    <dimen name="button_corner_radius">3dp</dimen>
+
     <dimen name="autocomplete_min_width">200dp</dimen>
     <dimen name="autocomplete_row_height">32dp</dimen>
 
     <dimen name="browser_toolbar_height">48dp</dimen>
     <dimen name="browser_toolbar_button_padding">12dp</dimen>
     <dimen name="browser_toolbar_icon_width">48dp</dimen>
     <dimen name="browser_toolbar_site_security_width">12dp</dimen>
     <!-- favicon_size includes 4dp of right padding. We can't use margin (which would allow us to