Backed out changeset 5bb0b8d757f4 (bug 974710) for m-3 test failure
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Wed, 16 Apr 2014 12:44:12 +0200
changeset 197304 fea1517890061a66ea5b73f5c053e086497b65e3
parent 197303 5bb0b8d757f4f7cb2571ece0c342c2ba7070da11
child 197305 00e9070e38e66a05fafeb31b88b960ea3d2e3e29
push id3624
push userasasaki@mozilla.com
push dateMon, 09 Jun 2014 21:49:01 +0000
treeherdermozilla-beta@b1a5da15899a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs974710
milestone31.0a1
backs out5bb0b8d757f4f7cb2571ece0c342c2ba7070da11
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 5bb0b8d757f4 (bug 974710) for m-3 test failure
content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
--- a/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
+++ b/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
@@ -67,28 +67,25 @@ SVGMotionSMILAnimationFunction::SetAttr(
     }
   } else if (aAttribute == nsGkAtoms::rotate) {
     nsresult rv = SetRotate(aValue, aResult);
     if (aParseResult) {
       *aParseResult = rv;
     }
   } else if (aAttribute == nsGkAtoms::path) {
     aResult.SetTo(aValue);
-    MarkStaleIfAttributeAffectsPath(aAttribute);
     if (aParseResult) {
       *aParseResult = NS_OK;
     }
+    MarkStaleIfAttributeAffectsPath(aAttribute);
   } else if (aAttribute == nsGkAtoms::by ||
              aAttribute == nsGkAtoms::from ||
              aAttribute == nsGkAtoms::to ||
              aAttribute == nsGkAtoms::values) {
     MarkStaleIfAttributeAffectsPath(aAttribute);
-    if (aParseResult) {
-      *aParseResult = NS_OK;
-    }
   } else {
     // Defer to superclass method
     return nsSMILAnimationFunction::SetAttr(aAttribute, aValue,
                                             aResult, aParseResult);
   }
 
   return true;
 }