Bug 1470280 - Part 2: Just use osPid to check for new process. r=mconley
☠☠ backed out by 2d2dee08739f ☠ ☠
authorEric Rahm <erahm@mozilla.com>
Fri, 05 Oct 2018 18:24:17 -0700
changeset 496104 fe7ccd9fee7621782676d9bd841c144126e24c04
parent 496103 60699c2387f6e51398c345996a97551a867bd2d7
child 496105 403c3d0daf6a24a7bb21e9f8ca2493cb4956fb4c
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1470280
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1470280 - Part 2: Just use osPid to check for new process. r=mconley The 'ipc:content-created' topic doesn't always seem to be propagated to the browser_force_process_selector.js test. It appears it's not necessary to actually wait for it, so lets just remove that.
dom/base/test/browser_force_process_selector.js
--- a/dom/base/test/browser_force_process_selector.js
+++ b/dom/base/test/browser_force_process_selector.js
@@ -1,23 +1,20 @@
 "use strict";
 
 const CONTENT_CREATED = "ipc:content-created";
 
 // Make sure that BTU.withNewTab({ ..., forceNewProcess: true }) loads
 // new tabs in their own process.
 async function spawnNewAndTest(recur, pids) {
-  let processCreated = TestUtils.topicObserved(CONTENT_CREATED);
   await BrowserTestUtils.withNewTab({ gBrowser, url: "about:blank", forceNewProcess: true },
                                     async function(browser) {
-      // Make sure our new browser is in its own process. The processCreated
-      // promise should have already resolved by this point.
-      await processCreated;
+      // Make sure our new browser is in its own process.
       let newPid = browser.frameLoader.tabParent.osPid;
-      ok(!pids.has(newPid), "new tab is in its own process");
+      ok(!pids.has(newPid), "new tab is in its own process: " + recur);
       pids.add(newPid);
 
       if (recur) {
         await spawnNewAndTest(recur - 1, pids);
       } else {
         let observer = () => {
           ok(false, "shouldn't have created a new process");
         };