Bug 523708: Move to 32px size for bookmarks, awesomebar, urlbar and search provider buttons [r=mark.finkle]
authorVivien Nicolas <21@vingtetun.org>
Wed, 28 Oct 2009 15:23:40 -0400
changeset 65730 fe1e7c76e41717a1992a3193ce6368b824b9944a
parent 65729 61ae88ad269f331b77c848e0ce68a5f573818f73
child 65731 0d337b9c94ae3438033a7eb15bb86cea6c7639b7
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmark
bugs523708
Bug 523708: Move to 32px size for bookmarks, awesomebar, urlbar and search provider buttons [r=mark.finkle]
mobile/themes/hildon/browser.css
mobile/themes/hildon/images/folder-30.png
mobile/themes/hildon/images/folder-32.png
mobile/themes/hildon/jar.mn
mobile/themes/wince/browser-high.css
mobile/themes/wince/browser-low.css
mobile/themes/wince/browser.css
mobile/themes/wince/images/folder-24.png
mobile/themes/wince/images/folder-30.png
mobile/themes/wince/images/folder-32.png
mobile/themes/wince/jar.mn
--- a/mobile/themes/hildon/browser.css
+++ b/mobile/themes/hildon/browser.css
@@ -160,18 +160,18 @@ toolbarbutton.urlbar-cap-button {
   background: url("images/leftcapSSL-active-64.png");
 }
 
 #urlbar-throbber[loading] {
   list-style-image: url("chrome://browser/skin/images/throbber.png");
 }
 
 #urlbar-favicon {
-  width: 30px;
-  height: 30px;
+  width: 32px;
+  height: 32px;
 }
 
 #urlbar-favicon[src=""] {
   list-style-image: url("chrome://browser/skin/images/favicon-default-30.png");
 }
 
 #urlbar-editarea {
   min-height: 64px;
@@ -473,32 +473,24 @@ placeitem[type="folder"] {
 }
 
 placelist[ui="manage"] placeitem[type="folder"] {
   background-image: none;
 }
 
 placeitem[type="folder"] > .bookmark-item-label > image,
 placeitem[type="folder"] > .bookmark-manage > image {
-  list-style-image: url(images/folder-30.png);
+  list-style-image: url(images/folder-32.png);
 }
   
 placeitem[type="folder"] .bookmark-item-url {
   display: none;
 }
 
 /* bookmark manage controls */
-placeitem > .bookmark-manage > image {
-  width: 24px;
-  height: 24px;
-  max-width: 24px;
-  max-height: 24px;
-  margin: 0.5mm 2.5mm 0mm 1mm;
-}
-  
 placeitem > .bookmark-manage .bookmark-controls {
   padding-top: 1.1mm;
 }
 
 /* bookmark popup for star button */
 placeitem[ui="manage"] {
   border-bottom: 0;
 }
@@ -522,18 +514,18 @@ placeitem[ui="manage"] > .bookmark-manag
 
 .searchengine {
   -moz-box-orient: horizontal;
   min-width: 8mm;
 }
 
 .searchengine .radio-icon {
   display: block;
-  width: 24px;
-  height: 24px;
+  width: 32px;
+  height: 32px;
   -moz-margin-end: 1mm;
 }
 
 #autocomplete_navbuttons {
   padding: 0.5mm 0; /* half core spacing & none (autorepeat arrows compensate) */
   min-height: 6mm; /* row size */
   -moz-user-focus: ignore;
 }
@@ -576,19 +568,21 @@ placeitem:active,
   margin: 0;
   padding: 0;
   font-size: 2.4mm !important;
   font-weight: normal;
   margin-right: 1mm;
 }
 
 .autocomplete-item-label > image,
-.bookmark-item-label > image {
-  width: 24px;
-  height: 24px;
+.bookmark-item-label > image,
+placeitem > .bookmark-manage > image {
+  width: 32px;
+  height: 32px;
+  max-height: 32px;
   margin: 0mm 2.5mm 0mm 1mm;
 }
 
 .autocomplete-item-label > label,
 .bookmark-item-label > label {
   -moz-margin-start: 1px;
 }
 
@@ -604,23 +598,21 @@ placeitem:active,
   font-size: 1.8mm !important;
   font-weight: lighter;
   padding-top: 0.5mm;
   margin-left: 1mm;
 }
 
 .autocomplete-item-url,
 .bookmark-item-url {
-  margin: 0;
-  padding: 0;
   color: blue;
   font-size: 1.8mm !important;
-  margin-left: 3.5mm;
+  margin-left: 34px;
   margin-right: 2mm;
-  padding-left: 26px;
+  padding-left: 3.5mm;
 }
 
 /* special "no results" and "all bookmarks" items */
 autocompleteresult.noresults {
   font-style: italic;
   border-bottom: none;
 }
 
@@ -809,18 +801,18 @@ box[type="documenttab"]:only-child .docu
 }
 
 #search-buttons,
 .search-engine-button {
   -moz-user-focus: ignore;
 }
 
 .search-engine-button .button-icon {
-  width: 24px;
-  height: 24px;
+  width: 32px;
+  height: 32px;
   -moz-margin-end: 1mm;
 }
 
 /* Preferences window   ---------------------------------------------------- */
 /* XXX should be a richlistitem */
 setting {
   background-color: white;
   color: black;
deleted file mode 100644
index 81de719ed307f376656e8809d99f25d208a2fb37..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
new file mode 100644
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..769c1249fc0a6970089a59f93b020a7064726342
GIT binary patch
literal 457
zc$@*r0XF`LP)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F80000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUzYe_^wRCwBA{Qv(y!$1O-RZS-N<c)#&
z3<>6e3_DAb0|>~Uk=M3i5S7s&Xwd5?Hy9pXJpytpBPkAGBBVf6Mjc50Cx{{H$cO?$
zL49WDTwHpW7`r9LP@D!}_BhAXGYE<+5T)t;%Lfd5mo&z_etd&LL`Dr=`afA|Ku}bc
zf#Kg@qBMck!t6rIMMf@hB>Dc_o<(2>7=w-a_lNZG16uy($xVu*037%K|B~*2M>kHA
zZLyrXDIy9SLyJicfxxT@WLf;-^<#$pt9uz>1t8b~{6Z4I5co}(k`H7TB>Mg#96(n5
zQwoqnfL^{wwI3-2{tdJP1|kF)2A2Z{AQAo_=tPJX1p}Q82O<g>kV1fAzzZTGtKs46
z0AMN{fCf2o2tcz0eXU0cf&T*)00Za%<PhMMGN7~N>ls)%g@E*9hy%WU`%ZWNGqJFP
zX~va}#-#TDs0mD1pq)vR0dl}u#)0mh0|XcVnjNWZnB8eJ00000NkvXXu0mjfgE+Yo
--- a/mobile/themes/hildon/jar.mn
+++ b/mobile/themes/hildon/jar.mn
@@ -20,17 +20,17 @@ chrome.jar:
   images/arrowleftdark-16.png          (images/arrowleftdark-16.png)
   images/arrowrightdark-16.png         (images/arrowrightdark-16.png)
   images/ratings-18.png                (images/ratings-18.png)
   images/favicon-default-30.png        (images/favicon-default-30.png)
   images/star-40.png                   (images/star-40.png)
   images/star-24.png                   (images/star-24.png)
   images/throbber.png                  (images/throbber.png)
   images/navigation-magnifier-30.png   (images/navigation-magnifier-30.png)
-  images/folder-30.png                 (images/folder-30.png)
+  images/folder-32.png                 (images/folder-32.png)
   images/stop-30.png                   (images/stop-30.png)
   images/reload-30.png                 (images/reload-30.png)
   images/go-30.png                     (images/go-30.png)
   images/alert-addons-30.png           (images/alert-addons-30.png)
   images/alert-downloads-30.png        (images/alert-downloads-30.png)
   images/addons-default-64.png         (images/addons-default-64.png)
   images/addons-active-64.png          (images/addons-active-64.png)
   images/back-default-64.png           (images/back-default-64.png)
--- a/mobile/themes/wince/browser-high.css
+++ b/mobile/themes/wince/browser-high.css
@@ -101,27 +101,27 @@
 }
 
 #identity-box[mode="verifiedDomain"]:hover:active,
 #identity-box[mode="verifiedDomain"][open] {
   background: url("images/leftcapSSL-active-64.png");
 }
 
 .search-engine-button .button-icon {
-  width: 16px;
-  height: 16px;
+  width: 32px;
+  height: 32px;
 }
 
 #urlbar-throbber[loading] {
   list-style-image: url("chrome://browser/skin/images/throbber.png");
 }
 
 #urlbar-favicon {
-  width: 30px;
-  height: 30px;
+  width: 32px;
+  height: 32px;
 }
 
 #urlbar-favicon[src=""] {
   list-style-image: url("chrome://browser/skin/images/favicon-default-30.png");
 }
 
 #urlbar-editarea {
   min-height: 64px;
@@ -246,31 +246,44 @@
   min-width: 0 !important;
   margin-top: -40px; /* keep pixels */
   list-style-image: url(images/fullscreen-up-40.png);
 }
 
 /* folders have a fixed image */
 placeitem[type="folder"] .bookmark-item-label > image,
 placeitem[type="folder"] > .bookmark-manage > image {
-  list-style-image: url(images/folder-30.png);
+  list-style-image: url(images/folder-32.png);
 }
 
 .close-button {
   -moz-appearance: none;
   border: none;
   margin: 0;
   padding: 0;
   list-style-image: url("chrome://browser/skin/images/close-40.png");
 }
 
 .tool-search {
   list-style-image: url("chrome://browser/skin/images/navigation-magnifier-30.png");
 }
 
+.autocomplete-item-label > image,
+.bookmark-item-label > image,
+placeitem > .bookmark-manage > image {
+  width: 32px;
+  height: 32px;
+  max-height: 32px;
+}
+
+.autocomplete-item-url,
+.bookmark-item-url {
+  margin-left: 34px;
+}
+
 autocompleteresult.allbookmarks > .autocomplete-item-image {
   width: 44px;
   height: 30px;
   list-style-image: url(images/bookmarks-30.png);
 }
 
 box[type="documenttab"] .documenttab-close {
   width: 40px;
--- a/mobile/themes/wince/browser-low.css
+++ b/mobile/themes/wince/browser-low.css
@@ -260,16 +260,29 @@ placeitem[type="folder"] > .bookmark-man
   padding: 0;
   list-style-image: url("chrome://browser/skin/images/close-16.png");
 }
 
 .tool-search {
   list-style-image: url("chrome://browser/skin/images/navigation-magnifier-16.png");
 }
 
+.autocomplete-item-label > image,
+.bookmark-item-label > image,
+placeitem > .bookmark-manage > image {
+  width: 24px;
+  height: 24px;
+  max-height: 24px;
+}
+
+.autocomplete-item-url,
+.bookmark-item-url {
+  margin-left: 26px;
+}
+
 autocompleteresult.allbookmarks > .autocomplete-item-image {
   width: 35px;
   height: 24px;
   list-style-image: url(images/bookmarks-24.png);
 }
 
 /* Left sidebar (tabs)  ---------------------------------------------------- */
 box[type="documenttab"] .documenttab-close {
--- a/mobile/themes/wince/browser.css
+++ b/mobile/themes/wince/browser.css
@@ -255,30 +255,22 @@ placeitem[type="folder"] {
 placelist[ui="manage"] placeitem[type="folder"] {
   background-image: none;
 }
 
 placeitem[type="folder"] .bookmark-item-url {
   display: none;
 }
 
-/* bookmark manage controls */
-placeitem > .bookmark-manage > image {
-  width: 24px;
-  height: 24px;
-  max-width: 24px;
-  max-height: 24px;
-  margin: 1.5mm 2.5mm 0mm 2mm;
-}
-
 /* use a smaller font size for the manage buttons */
-+placeitem > .bookmark-manage .button-text {
+placeitem > .bookmark-manage .button-text {
   font-size: 9pt !important;
 }
 
+/* bookmark manage controls */
 placeitem > .bookmark-manage .bookmark-controls {
   padding-top: 0.55mm;
 }
 
 /* bookmark popup for star button */
 placeitem[ui="manage"] {
   border-bottom: 0;
 }
@@ -338,18 +330,16 @@ placeitem:active,
   padding: 0;
   font-size: 9pt !important;
   font-weight: normal;
   margin-right: 2mm;
 }
 
 .autocomplete-item-label > image,
 .bookmark-item-label > image {
-  width: 24px;
-  height: 24px;
   margin: 0mm 2.5mm 0mm 2mm;
 }
 
 .autocomplete-item-label > label,
 .bookmark-item-label > label {
   -moz-margin-start: 1px;
 }
 
@@ -369,18 +359,19 @@ placeitem:active,
 }
 
 .autocomplete-item-url,
 .bookmark-item-url {
   margin: 0;
   padding: 0;
   color: blue;
   font-size: 8pt !important;
-  margin-left: 11.5mm;
   margin-right: 2mm;
+  margin-left: inherit;
+  padding-left: 4.5mm; /* left padding is equal to left+right margin of the autocomplete-item-label > image */
 }
 
 /* special "no results" and "all bookmarks" items */
 autocompleteresult.noresults {
   font-style: italic;
   border-bottom: none;
 }
 
index 4a3dffaf7eca62e21ddd49cdf41a360373dde172..e1d78c5ad0f1f65d798652f6a2455d3a5b0f9d03
GIT binary patch
literal 434
zc$@*U0ZsmiP)<h;3K|Lk000e1NJLTq000;O000;W1^@s6;CDUv0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUzR7pfZRCwBA{Qv(y11$l|swNYB^2R`X
zh6r;^!s^bP#cBZojc4SwZ5TvlG;k_-{p1G2!>dO?j$p(l&qT;+A~I?W{~7+_#2|UR
zK}0Ah&hDIt!k5#uB4{W!3(h!2)i4N($>UZ0{?$W<eal)H82$rYF0G0p2aL=Ac;i4o
zSd!uY-(Pqw0I2~3pauW`{eg=cI!0nue}4aRum#3oJp>F#2LFK;ym@+?=pX`z{l7oN
zTk!Z6;gl<@YKRCTJHHHu|9^fGWw>8b6JGfbZ=Nw6+B5?gg#Qp0@CgV5eejbiITvIW
zBpCl9Ecj0)!%+aT4@e1rQW64feSjQ9|Nj1_u@C<KqHP@f|NDmqLG&M~sQCAn22~A`
z1+X+rT@N7pfF{)@k_Aix>QpzLofla0K7Y)>xU$ih*m{>7U;^?1sIoSph3TM%03)rN
cEdT)q06*E1;bXh*2><{907*qoM6N<$f|jkdbpQYW
deleted file mode 100644
index 81de719ed307f376656e8809d99f25d208a2fb37..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
new file mode 100644
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..769c1249fc0a6970089a59f93b020a7064726342
GIT binary patch
literal 457
zc$@*r0XF`LP)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F80000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUzYe_^wRCwBA{Qv(y!$1O-RZS-N<c)#&
z3<>6e3_DAb0|>~Uk=M3i5S7s&Xwd5?Hy9pXJpytpBPkAGBBVf6Mjc50Cx{{H$cO?$
zL49WDTwHpW7`r9LP@D!}_BhAXGYE<+5T)t;%Lfd5mo&z_etd&LL`Dr=`afA|Ku}bc
zf#Kg@qBMck!t6rIMMf@hB>Dc_o<(2>7=w-a_lNZG16uy($xVu*037%K|B~*2M>kHA
zZLyrXDIy9SLyJicfxxT@WLf;-^<#$pt9uz>1t8b~{6Z4I5co}(k`H7TB>Mg#96(n5
zQwoqnfL^{wwI3-2{tdJP1|kF)2A2Z{AQAo_=tPJX1p}Q82O<g>kV1fAzzZTGtKs46
z0AMN{fCf2o2tcz0eXU0cf&T*)00Za%<PhMMGN7~N>ls)%g@E*9hy%WU`%ZWNGqJFP
zX~va}#-#TDs0mD1pq)vR0dl}u#)0mh0|XcVnjNWZnB8eJ00000NkvXXu0mjfgE+Yo
--- a/mobile/themes/wince/jar.mn
+++ b/mobile/themes/wince/jar.mn
@@ -19,17 +19,17 @@ chrome.jar:
   images/arrowup-16.png                (images/arrowup-16.png)
   images/arrowleftdark-16.png          (images/arrowleftdark-16.png)
   images/arrowrightdark-16.png         (images/arrowrightdark-16.png)
   images/ratings-18.png                (images/ratings-18.png)
   images/favicon-default-30.png        (images/favicon-default-30.png)
   images/star-40.png                   (images/star-40.png)
   images/throbber.png                  (images/throbber.png)
   images/navigation-magnifier-30.png   (images/navigation-magnifier-30.png)
-  images/folder-30.png                 (images/folder-30.png)
+  images/folder-32.png                 (images/folder-32.png)
   images/stop-30.png                   (images/stop-30.png)
   images/reload-30.png                 (images/reload-30.png)
   images/go-30.png                     (images/go-30.png)
   images/bookmarks-30.png              (images/bookmarks-30.png)
   images/alert-addons-30.png           (images/alert-addons-30.png)
   images/alert-downloads-30.png        (images/alert-downloads-30.png)
   images/addons-default-64.png         (images/addons-default-64.png)
   images/addons-active-64.png          (images/addons-active-64.png)