Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob. r=jimm
authorBob Owen <bobowencode@gmail.com>
Sun, 29 May 2016 19:53:28 +0100
changeset 338544 fd97954bd82a4272b1863638c2de356b489954a6
parent 338543 34fa89cabbdb2e2fa50719b2ca5f6fb9d6c34404
child 338545 1531cd2fb7e6dbaa18998b8933dfe596750c25d0
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimm
bugs1270447
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob. r=jimm MozReview-Commit-ID: 3xzoiYV153L
embedding/components/printingui/ipc/PrintingParent.cpp
--- a/embedding/components/printingui/ipc/PrintingParent.cpp
+++ b/embedding/components/printingui/ipc/PrintingParent.cpp
@@ -258,17 +258,17 @@ PrintingParent::SerializeAndEnsureRemote
     printSettings = aPrintSettings;
   } else {
     rv = mPrintSettingsSvc->GetNewPrintSettings(getter_AddRefs(printSettings));
     if (NS_WARN_IF(NS_FAILED(rv))) {
       return rv;
     }
   }
 
-  rv = mPrintSettingsSvc->SerializeToPrintData(aPrintSettings, nullptr,
+  rv = mPrintSettingsSvc->SerializeToPrintData(printSettings, nullptr,
                                                aPrintData);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     return rv;
   }
 
   RemotePrintJobParent* remotePrintJob;
   if (aRemotePrintJob) {
     remotePrintJob = aRemotePrintJob;