Bug 1581747 - Remove XUL grid usage from browser/components/preferences/browserLanguages.xul. r=jaws a=reland-for-correct-backout-commit-message
authorTim Nguyen <ntim.bugs@gmail.com>
Fri, 08 Nov 2019 12:18:58 +0200
changeset 559946 fd86ac5d950cde5232d6427c7eadf2a64e7a9908
parent 559945 e5b7389c999860e0f09f0c2dca1f8d466bed3380
child 559947 b173ec666522c4b8c697afed0532422a6b681832
push id12277
push usernbeleuzu@mozilla.com
push dateFri, 08 Nov 2019 10:23:59 +0000
treeherdermozilla-beta@b173ec666522 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws, reland-for-correct-backout-commit-message
bugs1581747
milestone71.0
Bug 1581747 - Remove XUL grid usage from browser/components/preferences/browserLanguages.xul. r=jaws a=reland-for-correct-backout-commit-message Differential Revision: https://phabricator.services.mozilla.com/D47022
browser/components/preferences/browserLanguages.xul
browser/themes/shared/incontentprefs/preferences.inc.css
--- a/browser/components/preferences/browserLanguages.xul
+++ b/browser/components/preferences/browserLanguages.xul
@@ -24,41 +24,32 @@
   </linkset>
 
   <script src="chrome://browser/content/utilityOverlay.js"/>
   <script src="chrome://global/content/preferencesBindings.js"/>
   <script src="chrome://browser/content/preferences/browserLanguages.js"/>
 
   <description data-l10n-id="browser-languages-description"/>
 
-  <grid flex="1">
-    <columns>
-      <column flex="1"/>
-      <column/>
-    </columns>
-    <rows>
-      <row>
-        <richlistbox id="selectedLocales"/>
-        <vbox>
-          <button id="up" class="action-button" disabled="true" data-l10n-id="languages-customize-moveup"/>
-          <button id="down" class="action-button" disabled="true" data-l10n-id="languages-customize-movedown"/>
-          <button id="remove" class="action-button" disabled="true" data-l10n-id="languages-customize-remove"/>
-        </vbox>
-      </row>
-      <row>
-        <menulist id="availableLocales"
-                  class="available-locales-list"
-                  data-l10n-id="browser-languages-select-language"
-                  data-l10n-attrs="placeholder,label">
-          <menupopup/>
-        </menulist>
-        <button id="add"
-                class="add-browser-language action-button"
-                data-l10n-id="languages-customize-add"
-                disabled="true"/>
-      </row>
-    </rows>
-  </grid>
+  <box flex="1" style="display: grid; grid-template-rows: 1fr auto; grid-template-columns: 1fr auto;">
+    <richlistbox id="selectedLocales"/>
+    <vbox>
+      <button id="up" class="action-button" disabled="true" data-l10n-id="languages-customize-moveup"/>
+      <button id="down" class="action-button" disabled="true" data-l10n-id="languages-customize-movedown"/>
+      <button id="remove" class="action-button" disabled="true" data-l10n-id="languages-customize-remove"/>
+    </vbox>
+
+    <menulist id="availableLocales"
+              class="available-locales-list"
+              data-l10n-id="browser-languages-select-language"
+              data-l10n-attrs="placeholder,label">
+      <menupopup/>
+    </menulist>
+    <button id="add"
+            class="add-browser-language action-button"
+            data-l10n-id="languages-customize-add"
+            disabled="true"/>
+  </box>
   <hbox id="warning-message" class="message-bar message-bar-warning" hidden="true">
     <image class="message-bar-icon"/>
     <description class="message-bar-description" data-l10n-id="browser-languages-error"/>
   </hbox>
 </dialog>
--- a/browser/themes/shared/incontentprefs/preferences.inc.css
+++ b/browser/themes/shared/incontentprefs/preferences.inc.css
@@ -980,20 +980,16 @@ menulist[indicator=true] > menupopup men
   margin-inline-start: 4px;
 }
 
 #defaultBrowserLanguage {
   margin-inline-start: 0;
   min-width: 20em;
 }
 
-#selectedLocales {
-  height: 150px;
-}
-
 #selectedLocales > richlistitem {
   padding-inline-start: 13px;
 }
 
 #availableLanguages,
 #availableLocales {
   margin: 0;
   margin-inline-end: 4px;