bug 1455177 do not resize but only hide window when bounds make the window empty r=bradwerth
authorKarl Tomlinson <karlt+@karlt.net>
Thu, 19 Apr 2018 13:37:50 +1200
changeset 468771 fd4e874f6c6fd0a64d3119e1d5949f88a6d0c411
parent 468770 eb34acceb9dcba6faff9eee5e8c9183755ddd37a
child 468772 b3ef06fe604ddf0e0d183f22daf612033783fa11
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbradwerth
bugs1455177
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1455177 do not resize but only hide window when bounds make the window empty r=bradwerth This restores behavior to that prior to https://hg.mozilla.org/mozilla-central/rev/cb0eda54dfab#l1.139 MozReview-Commit-ID: Kf8TCl7Xsg3
widget/gtk/nsWindow.cpp
--- a/widget/gtk/nsWindow.cpp
+++ b/widget/gtk/nsWindow.cpp
@@ -4202,16 +4202,18 @@ nsWindow::NativeMoveResize()
         // hides the window or shows it.  It also prevents us from
         // calling NativeShow(false) excessively on the window which
         // causes unneeded X traffic.
         if (!mNeedsShow && mIsShown) {
             mNeedsShow = true;
             NativeShow(false);
         }
         NativeMove();
+
+        return;
     }
 
     GdkRectangle size = DevicePixelsToGdkSizeRoundUp(mBounds.Size());
     GdkPoint topLeft = DevicePixelsToGdkPointRoundDown(mBounds.TopLeft());
 
     LOG(("nsWindow::NativeMoveResize [%p] %d %d %d %d\n", (void *)this,
          topLeft.x, topLeft.y, size.width, size.height));