Bug 1207576 - crash in android.content.res.Resources$NotFoundException: Resource ID #0x7f0c0197 at android.content.res.Resources.getValue(Resources.java) when opening tab tray in landscape; r=margaret, a=lizzard
authorMartyn Haigh <mhaigh@mozilla.org>
Wed, 30 Sep 2015 15:41:58 +0100
changeset 296352 fc9c55d72e834f89cddd8ff07a307770f5a1be45
parent 296351 62ffae819bfb4244b776bcb3a58aaae6d30c5810
child 296353 ea5e14f1c519034119d8c7e85e31870048a15e08
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret, lizzard
bugs1207576
milestone43.0a2
Bug 1207576 - crash in android.content.res.Resources$NotFoundException: Resource ID #0x7f0c0197 at android.content.res.Resources.getValue(Resources.java) when opening tab tray in landscape; r=margaret, a=lizzard
mobile/android/base/tabs/TabsPanel.java
--- a/mobile/android/base/tabs/TabsPanel.java
+++ b/mobile/android/base/tabs/TabsPanel.java
@@ -257,22 +257,22 @@ public class TabsPanel extends LinearLay
             return screenHeight - actionBarHeight;
         }
 
         PanelView panelView = tabsContainer.getCurrentPanelView();
         if (panelView != null && !panelView.shouldExpand()) {
 
             // This allows us to accommodate varying height tab previews across different devices.
             // We should be able to remove once we remove the list view and remove the chrome again
-            return  resources.getDimensionPixelSize(R.dimen.tab_thumbnail_height
-                  + resources.getDimensionPixelSize(R.dimen.tab_title_height)
-                  + 2 * (resources.getDimensionPixelSize(R.dimen.tab_highlight_stroke_width)
-                         + resources.getDimensionPixelSize(R.dimen.tab_vertical_padding)
-                         + resources.getDimensionPixelSize(R.dimen.tab_thumbnail_padding)
-                         + resources.getDimensionPixelSize(R.dimen.tab_thumbnail_margin)));
+            return resources.getDimensionPixelSize(R.dimen.tab_thumbnail_height)
+                 + resources.getDimensionPixelSize(R.dimen.tab_title_height)
+                 + 2 * (resources.getDimensionPixelSize(R.dimen.tab_highlight_stroke_width)
+                      + resources.getDimensionPixelSize(R.dimen.tab_vertical_padding)
+                      + resources.getDimensionPixelSize(R.dimen.tab_thumbnail_padding)
+                      + resources.getDimensionPixelSize(R.dimen.tab_thumbnail_margin));
         }
 
         Rect windowRect = new Rect();
         tabsContainer.getWindowVisibleDisplayFrame(windowRect);
         int windowHeight = windowRect.bottom - windowRect.top;
 
         // The web content area should have at least 1.5x the height of the action bar.
         // The tabs panel shouldn't take less than 50% of the screen height and can take