Bug 1502054 - Remove the header-button class. r=mstriemer
authorDão Gottwald <dao@mozilla.com>
Fri, 26 Oct 2018 18:01:06 +0000
changeset 499649 fbecb004514ccad4e7ca03dbf43bcc53f9cd00b1
parent 499648 8b72cee028cdd72074cc78870c21d145d954fac1
child 499650 8af56b8790336d4f8387aa7b0050b807f97723d4
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstriemer
bugs1502054
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1502054 - Remove the header-button class. r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D9788
toolkit/mozapps/extensions/content/extensions.xul
toolkit/themes/shared/extensions/extensions.inc.css
--- a/toolkit/mozapps/extensions/content/extensions.xul
+++ b/toolkit/mozapps/extensions/content/extensions.xul
@@ -238,17 +238,17 @@
                            value="&updates.installed.label;"/>
                     <label id="updates-downloaded" hidden="true"
                            value="&updates.downloaded.label;"/>
                     <button id="updates-restart-btn" class="button-link" hidden="true"
                             label="&updates.restart.label;"
                             command="cmd_restartApp"/>
                   </hbox>
 
-                  <toolbarbutton id="header-utils-btn" class="header-button" type="menu"
+                  <toolbarbutton id="header-utils-btn" type="menu"
                            data-l10n-id="tools-menu">
                     <menupopup id="utils-menu">
                       <menuitem id="utils-updateNow"
                                 label="&updates.checkForUpdates.label;"
                                 accesskey="&updates.checkForUpdates.accesskey;"
                                 command="cmd_findAllUpdates"/>
                       <menuitem id="utils-viewUpdates"
                                 label="&updates.viewUpdates.label;"
--- a/toolkit/themes/shared/extensions/extensions.inc.css
+++ b/toolkit/themes/shared/extensions/extensions.inc.css
@@ -249,49 +249,38 @@ button.warning {
   }
 }
 
 .list-view-heading-inner {
   width: 664px;
 }
 
 #header-utils-btn {
+  -moz-appearance: none;
+  border: 1px solid var(--in-content-box-border-color);
+  border-radius: 2px;
   line-height: 20px;
-  border-color: var(--in-content-box-border-color);
   background-color: var(--in-content-page-background);
   padding-right: 10px;
   padding-left: 10px;
   /* This button is too tall, adding margin-bottom shrinks it. */
   margin-bottom: 2px;
 }
 
-#header-utils-btn:not([disabled="true"]):active:hover,
+#header-utils-btn:hover {
+  background-color: var(--in-content-box-background-hover);
+  cursor: pointer;
+}
+
+#header-utils-btn:active:hover,
 #header-utils-btn[open="true"] {
-  padding-bottom: 0px;
-  padding-top: 0px;
   background-color: var(--in-content-box-background-active);
 }
 
-.header-button {
-  -moz-appearance: none;
-  border: 1px solid;
-  border-radius: 2px;
-}
-
-.header-button[disabled="true"] > .toolbarbutton-icon {
-  opacity: 0.4;
-}
-
-.header-button:not([disabled="true"]):hover,
-#header-utils-btn:not([disabled="true"]):hover {
-  background-color: #ebebeb;
-  cursor: pointer;
-}
-
-.header-button > .toolbarbutton-text {
+#header-utils-btn > .toolbarbutton-text {
   display: none;
 }
 
 #list-view-heading {
   margin-top: 24px;
   margin-bottom: 16px;
   margin-inline-start: 28px;
 }