Bug 1251418 - Make test_sessionStorageBase.html work in e10s. r=smaug
authorBlake Kaplan <mrbkap@gmail.com>
Fri, 26 Feb 2016 10:00:01 -0800
changeset 322183 fbcaba9e6b76349a6cd504c9762e7ed7e4b36397
parent 322182 b88648a41ed26abcc1a9184d6c583f60c600014b
child 322184 29095b39290bfbff0031fcfb6001e962e9ce0fa2
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1251418
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1251418 - Make test_sessionStorageBase.html work in e10s. r=smaug
dom/tests/mochitest/sessionstorage/mochitest.ini
dom/tests/mochitest/sessionstorage/test_sessionStorageBase.html
--- a/dom/tests/mochitest/sessionstorage/mochitest.ini
+++ b/dom/tests/mochitest/sessionstorage/mochitest.ini
@@ -6,17 +6,17 @@ support-files =
   frameNotEqual.html
   frameReplace.html
   interOriginSlave.js
   interOriginTest.js
 
 [test_cookieSession.html]
 skip-if = buildapp == 'b2g' # b2g(4 failures)
 [test_sessionStorageBase.html]
-skip-if = buildapp == 'b2g' || e10s # b2g(no storage chrome event received)
+skip-if = buildapp == 'b2g' # b2g(no storage chrome event received)
 [test_sessionStorageBaseSessionOnly.html]
 skip-if = buildapp == 'b2g' # b2g(bug 967737)
 [test_sessionStorageClone.html]
 skip-if = buildapp == 'b2g' || toolkit == 'android' # b2g(bug 968051) b2g-debug(bug 968051) b2g-desktop(Bug 931116, b2g desktop specific, initial triage)
 [test_sessionStorageHttpHttps.html]
 skip-if = buildapp == 'b2g' || toolkit == 'android' #TIMED_OUT # b2g(needs https to work) b2g-debug(needs https to work) b2g-desktop(needs https to work)
 [test_sessionStorageReplace.html]
 skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage
--- a/dom/tests/mochitest/sessionstorage/test_sessionStorageBase.html
+++ b/dom/tests/mochitest/sessionstorage/test_sessionStorageBase.html
@@ -50,17 +50,17 @@ function startTest()
     if (e.storageArea == sessionStorageCopy) {
       ok(expectedEvents.length > 0, "Not more then expected events encountered");
       var receivedEvent = e.key + "," + e.oldValue + "," + e.newValue;
       is(receivedEvent, expectedEvents.shift(), "Expected event data: " + receivedEvent);
     }
   }
 
   // Listen for MozSessionStorageChanged
-  SpecialPowers.addChromeEventListener("MozSessionStorageChanged", onStorageChanged, false);
+  SpecialPowers.addChromeEventListener("MozSessionStorageChanged", onStorageChanged, true);
 
   // add an empty-value key
   sessionStorage.setItem("empty", "");
   is(sessionStorage.getItem("empty"), "", "Empty value (getItem())");
   is(sessionStorage["empty"], "", "Empty value (array access)");
   is(sessionStorage.empty, "", "Empty value (property access)");
   is(typeof sessionStorage.getItem("empty"), "string", "getItem('empty') is string");
   is(typeof sessionStorage["empty"], "string", "['empty'] is string");
@@ -155,17 +155,17 @@ function startTest()
   is(sessionStorage.getItem("nonexisting"), null, "Nonexisting item is null");
   is(sessionStorage.getItem("key1"), null, "key1 removed");
   is(sessionStorage.getItem("key2"), null, "key2 removed");
   sessionStorage.removeItem("nonexisting"); // Just check there is no exception
   sessionStorage.removeItem("key1"); // Just check there is no exception
   sessionStorage.removeItem("key2"); // Just check there is no exception
 
   SimpleTest.executeSoon(function () {
-    SpecialPowers.removeChromeEventListener("MozSessionStorageChanged", onStorageChanged, false);
+    SpecialPowers.removeChromeEventListener("MozSessionStorageChanged", onStorageChanged, true);
     is(expectedEvents.length, 0, "received the correct number of events");
 
     sessionStorage.clear();
     SimpleTest.finish();
   });
 }
 
 SimpleTest.waitForExplicitFinish();