Bug 966640 - The right margin of the side menu widget should match the new splitter color on the dark theme, r=bgrins
authorVictor Porof <vporof@mozilla.com>
Sat, 01 Feb 2014 18:04:11 +0200
changeset 182465 fb7a29f77890d9dea86f7069776fd5dfed4c65f6
parent 182464 9f1c9cf5040f917d2c2f866f3f743ab10edfd5a3
child 182466 16dfbbf8a15947644302ecdae6d3ceb07936e5d0
push id3343
push userffxbld
push dateMon, 17 Mar 2014 21:55:32 +0000
treeherdermozilla-beta@2f7d3415f79f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs966640
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 966640 - The right margin of the side menu widget should match the new splitter color on the dark theme, r=bgrins
browser/themes/shared/devtools/shadereditor.inc.css
browser/themes/shared/devtools/widgets.inc.css
--- a/browser/themes/shared/devtools/shadereditor.inc.css
+++ b/browser/themes/shared/devtools/shadereditor.inc.css
@@ -88,17 +88,17 @@
 
 .editor-label {
   padding: 1px 12px;
   border-top: 1px solid;
 }
 
 .theme-dark .editor-label {
   background: #343c45; /* Dark toolbars */
-  border-color: #222426; /* Match the splitter color. */
+  border-color: #000; /* Match the splitter color. */
   color: #f5f7fa; /* Light foreground text */
 }
 
 .theme-light .editor-label {
   background: #f0f1f2; /* Light toolbars */
   border-color: #aaa; /* Match the splitter color. */
   color: #585959; /* Grey foreground text */
 }
--- a/browser/themes/shared/devtools/widgets.inc.css
+++ b/browser/themes/shared/devtools/widgets.inc.css
@@ -317,18 +317,17 @@
 
 .theme-light .fast-list-widget-empty-text {
   color: #585959; /* Grey foreground text */
 }
 
 /* SideMenuWidget */
 
 %filter substitution
-%define smw_selectionTextColor #f5f7fa
-%define smw_marginDark #222426
+%define smw_marginDark #000
 %define smw_marginLight #aaa
 %define smw_itemDarkTopBorder rgba(0,0,0,0.2)
 %define smw_itemDarkBottomBorder rgba(128,128,128,0.15)
 %define smw_itemLightTopBorder rgba(128,128,128,0.15)
 %define smw_itemLightBottomBorder transparent
 
 .side-menu-widget-container {
   /* Hack: force hardware acceleration */
@@ -414,22 +413,22 @@
 }
 
 .theme-light .side-menu-widget-item:last-of-type {
   box-shadow: inset 0 -1px 0 @smw_itemLightTopBorder@;
 }
 
 .theme-dark .side-menu-widget-item.selected {
   background-color: #1d4f73; /* Select Highlight Blue */
-  color: @smw_selectionTextColor@;
+  color: #f5f7fa; /* Light foreground text */
 }
 
 .theme-light .side-menu-widget-item.selected {
   background-color: #4c9ed9; /* Select Highlight Blue */
-  color: @smw_selectionTextColor@;
+  color: #f5f7fa; /* Light foreground text */
 }
 
 .side-menu-widget-item-arrow {
   -moz-margin-start: -7px;
   width: 7px; /* The image's width is 7 pixels */
   /* Cover the border of the side-menu-widget-item */
   margin-top: -1px;
   margin-bottom: -1px;
@@ -503,22 +502,22 @@
 
 .theme-light .side-menu-widget-item.selected .side-menu-widget-item-other {
   background-color: rgba(255,255,255,.8); /* Lighten the selection by 20% */
   color: #18191a; /* Dark foreground text */
 }
 
 .theme-dark .side-menu-widget-item.selected .side-menu-widget-item-other.selected {
   background-color: transparent;
-  color: @smw_selectionTextColor@;
+  color: #f5f7fa; /* Light foreground text */
 }
 
 .theme-light .side-menu-widget-item.selected .side-menu-widget-item-other.selected {
   background-color: transparent;
-  color: @smw_selectionTextColor@;
+  color: #f5f7fa; /* Light foreground text */
 }
 
 /* SideMenuWidget checkboxes */
 
 .side-menu-widget-group-checkbox {
   margin: 0;
   -moz-margin-end: 4px;
 }