Bug 756851 - add missing call to object->markIfUnmarked before GCMarker::pushObject. r=billm
authorTill Schneidereit <tschneidereit@gmail.com>
Sun, 20 May 2012 14:34:21 -0700
changeset 98511 fb3036d9b9e6a0c493d0bec20b67d57c539100f1
parent 98510 6e9d62160729562b976703233fba10e12f6a4b45
child 98521 022dfc84028c87dda82496c82f471ec059082315
push id1116
push userlsblakk@mozilla.com
push dateMon, 16 Jul 2012 19:38:18 +0000
treeherdermozilla-beta@95f959a8b4dc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbillm
bugs756851
milestone15.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 756851 - add missing call to object->markIfUnmarked before GCMarker::pushObject. r=billm
js/src/gc/Marking.cpp
--- a/js/src/gc/Marking.cpp
+++ b/js/src/gc/Marking.cpp
@@ -1014,17 +1014,17 @@ GCMarker::processMarkStackOther(SliceBud
                 JS_ASSERT(thing <= arena->thingsEnd());
                 if (thing == span->first) {
                     if (!span->hasNext())
                         break;
                     thing = span->last;
                     span = span->nextSpan();
                 } else {
                     JSObject *object = reinterpret_cast<JSObject *>(thing);
-                    if (object->hasSingletonType())
+                    if (object->hasSingletonType() && object->markIfUnmarked(getMarkColor()))
                         pushObject(object);
                     budget.step();
                 }
             }
             if (budget.isOverBudget()) {
                 pushArenaList(aheader);
                 return;
             }