Bug 1530353 - Temporarily stop measuring hero element in tp6-1 to prevent intermittent failures; r=acreskey,davehunt
authorRob Wood <rwood@mozilla.com>
Mon, 04 Mar 2019 21:43:21 +0000
changeset 520161 faa8822a034d76e920b9c4670795fd6b100836f4
parent 520160 7f3e254c982c86371a0dc92a78c929b9cabbc3c1
child 520162 33a6f98be59c81ef5ebf53c3853a76b340ede88c
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersacreskey, davehunt
bugs1530353
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1530353 - Temporarily stop measuring hero element in tp6-1 to prevent intermittent failures; r=acreskey,davehunt Differential Revision: https://phabricator.services.mozilla.com/D21802
testing/raptor/raptor/tests/raptor-tp6-1.ini
testing/raptor/test/test_manifest.py
--- a/testing/raptor/raptor/tests/raptor-tp6-1.ini
+++ b/testing/raptor/raptor/tests/raptor-tp6-1.ini
@@ -10,35 +10,32 @@ playback = mitmproxy
 playback_binary_manifest = mitmproxy-rel-bin-{platform}.manifest
 playback_pageset_manifest = mitmproxy-recordings-raptor-tp6-1.manifest
 page_cycles = 25
 unit = ms
 lower_is_better = true
 alert_threshold = 2.0
 # TTI/TTFI can take a while on some pages, and requires at least 5 seconds
 # beyond typical pageload time
-page_timeout = 30000
+page_timeout = 60000
 gecko_profile_interval = 1
 gecko_profile_entries = 14000000
 alert_on = fcp, loadtime
 
 [raptor-tp6-amazon-firefox]
 apps = firefox
 test_url = https://www.amazon.com/s/url=search-alias%3Daps&field-keywords=laptop
 playback_recordings = amazon.mp
-measure = fnbpaint, fcp, hero, dcf, ttfi, loadtime
-hero = hero1
+measure = fnbpaint, fcp, dcf, ttfi, loadtime
 
 [raptor-tp6-facebook-firefox]
-disabled = Bug 1506936
 apps = firefox
 test_url = https://www.facebook.com
 playback_recordings = facebook.mp
-measure = fnbpaint, fcp, hero, dcf, ttfi, loadtime
-hero = hero1
+measure = fnbpaint, fcp, dcf, ttfi, loadtime
 
 [raptor-tp6-google-firefox]
 apps = firefox
 # note: use the full url as the first part (without '&cad=h') redirects
 # to the url + '&cad=h'; that redirection causes measure.js content
 # to be loaded into that page also; resulting in 2 fnbpaint values etc.
 test_url = https://www.google.com/search?hl=en&q=barack+obama&cad=h
 playback_recordings = google-search.mp
--- a/testing/raptor/test/test_manifest.py
+++ b/testing/raptor/test/test_manifest.py
@@ -103,17 +103,17 @@ def test_validate_test_ini_valid(test_de
 def test_validate_test_ini_invalid(test_details):
     assert not (validate_test_ini(test_details))
 
 
 def test_get_raptor_test_list_firefox(create_args):
     args = create_args()
 
     test_list = get_raptor_test_list(args, mozinfo.os)
-    assert len(test_list) == 3
+    assert len(test_list) == 4
 
     subtests = ['raptor-tp6-google-firefox', 'raptor-tp6-amazon-firefox',
                 'raptor-tp6-facebook-firefox', 'raptor-tp6-youtube-firefox']
 
     for next_subtest in test_list:
         assert next_subtest['name'] in subtests