Bug 1508063 - Part 3: Fix typo in Binsource.yaml. r=Yoric
authorTooru Fujisawa <arai_a@mac.com>
Thu, 29 Nov 2018 01:03:45 +0900
changeset 504949 f96f280927ff0bc9340a7726d28851f884998126
parent 504948 391d7669e9b28c4475ead6f5f6771dfa1fd05deb
child 504950 02386132c1e9bfa3ef88b9ae7d967f90b6e1045e
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersYoric
bugs1508063
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1508063 - Part 3: Fix typo in Binsource.yaml. r=Yoric
js/src/frontend/BinSource.yaml
js/src/frontend/BinToken.h
--- a/js/src/frontend/BinSource.yaml
+++ b/js/src/frontend/BinSource.yaml
@@ -139,17 +139,17 @@ hpp:
                  *
                  * ```c++
                  * #define WITH_FIELD(CPP_NAME, SPEC_NAME) ...
                  * FOR_EACH_BIN_FIELD(WITH_FIELD)
                  * ```
                  *
                  * (sorted by alphabetical order)
                  */
-        field:
+        variants:
             doc: |
                 /**
                  * The different variants of Binary AST string enums, as per
                  * the specifications of Binary AST, as a single macro and
                  * `enum class`.
                  *
                  * Separate enum classes are also defined in BinSource-auto.h.
                  *
--- a/js/src/frontend/BinToken.h
+++ b/js/src/frontend/BinToken.h
@@ -270,27 +270,24 @@ enum class BinKind {
 
 // The number of distinct values of BinKind.
 const size_t BINKIND_LIMIT = 200;
 
 
 
 
 /**
- * The different variants of Binary AST string enums, as per
- * the specifications of Binary AST, as a single macro and
- * `enum class`.
- *
- * Separate enum classes are also defined in BinSource-auto.h.
+ * The different fields of Binary AST nodes, as per the specifications of
+ * Binary AST.
  *
  * Usage:
  *
  * ```c++
- * #define WITH_VARIANT(CPP_NAME, SPEC_NAME) ...
- * FOR_EACH_BIN_VARIANT(WITH_VARIANT)
+ * #define WITH_FIELD(CPP_NAME, SPEC_NAME) ...
+ * FOR_EACH_BIN_FIELD(WITH_FIELD)
  * ```
  *
  * (sorted by alphabetical order)
  */
 #define FOR_EACH_BIN_FIELD(F) \
     F(Alternate, "alternate") \
     F(Arguments, "arguments") \
     F(Binding, "binding") \
@@ -366,17 +363,32 @@ enum class BinField {
     FOR_EACH_BIN_FIELD(EMIT_ENUM)
 #undef EMIT_ENUM
 };
 
 // The number of distinct values of BinField.
 const size_t BINFIELD_LIMIT = 69;
 
 
-
+/**
+ * The different variants of Binary AST string enums, as per
+ * the specifications of Binary AST, as a single macro and
+ * `enum class`.
+ *
+ * Separate enum classes are also defined in BinSource-auto.h.
+ *
+ * Usage:
+ *
+ * ```c++
+ * #define WITH_VARIANT(CPP_NAME, SPEC_NAME) ...
+ * FOR_EACH_BIN_VARIANT(WITH_VARIANT)
+ * ```
+ *
+ * (sorted by alphabetical order)
+ */
 #define FOR_EACH_BIN_VARIANT(F) \
     F(AssertedDeclaredKindConstLexical, "const lexical") \
     F(AssertedDeclaredKindNonConstLexical, "non-const lexical") \
     F(AssertedDeclaredKindOrVariableDeclarationKindVar, "var") \
     F(BinaryOperatorBitAnd, "&") \
     F(BinaryOperatorBitOr, "|") \
     F(BinaryOperatorBitXor, "^") \
     F(BinaryOperatorComma, ",") \