Bug 555329 - 'New Tab opened' notification not shown opening first tab added to 2nd row in tab panel [r=mfinkle]
authorVivien Nicolas <21@vingtetun.org>
Wed, 14 Apr 2010 12:59:47 -0400
changeset 66142 f957689a8365fc616debd8d3dc4df68431872ad8
parent 66141 3787777eb4322e50d236ce2630b6a60621bb467f
child 66143 29b07d51eff9a88d2ad147719b1ee87253fc2d52
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs555329
Bug 555329 - 'New Tab opened' notification not shown opening first tab added to 2nd row in tab panel [r=mfinkle]
mobile/chrome/content/browser-ui.js
--- a/mobile/chrome/content/browser-ui.js
+++ b/mobile/chrome/content/browser-ui.js
@@ -683,24 +683,24 @@ var BrowserUI = {
       case "DOMWindowClose":
         this._domWindowClose(aEvent);
         break;
       case "TabSelect":
         this._tabSelect(aEvent);
         break;
       case "TabOpen":
       {
-        if (!this.isTabsVisible() && Browser.selectedTab.chromeTab != aEvent.target)
+        let [tabsVisibility,,,] = Browser.computeSidebarVisibility();
+        if (!(tabsVisibility == 1.0) && Browser.selectedTab.chromeTab != aEvent.target)
           NewTabPopup.show(aEvent.target);
 
-          // Workaround to hide the tabstrip if it is partially visible
-          // See bug 524469
-          let [tabstripV,,,] = Browser.computeSidebarVisibility();
-          if (tabstripV > 0 && tabstripV < 1)
-            Browser.hideSidebars();
+        // Workaround to hide the tabstrip if it is partially visible
+        // See bug 524469
+        if (tabsVisibility > 0.0 && tabsVisibility < 1.0)
+          Browser.hideSidebars();
 
         break;
       }
       // Window events
       case "keypress":
         if (aEvent.keyCode == aEvent.DOM_VK_ESCAPE) {
           let dialog = this.activeDialog;
           if (dialog)