Bug 1114655 - Increase robocop WaitHelper default wait time; r=mcomella
authorGeoff Brown <gbrown@mozilla.com>
Tue, 30 Dec 2014 14:27:44 -0700
changeset 247520 f93e28755637c2bc51527442375bf5f23ec4a44b
parent 247519 4912606fb9c77c120db83256224eeafabc57acc1
child 247521 0365efa5999a2a3536b598a76f2f28786b4da29b
push id4489
push userraliiev@mozilla.com
push dateMon, 23 Feb 2015 15:17:55 +0000
treeherdermozilla-beta@fd7c3dc24146 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1114655
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1114655 - Increase robocop WaitHelper default wait time; r=mcomella
mobile/android/base/tests/helpers/WaitHelper.java
--- a/mobile/android/base/tests/helpers/WaitHelper.java
+++ b/mobile/android/base/tests/helpers/WaitHelper.java
@@ -20,17 +20,19 @@ import com.jayway.android.robotium.solo.
 import com.jayway.android.robotium.solo.Solo;
 
 /**
  * Provides functionality related to waiting on certain events to happen.
  */
 public final class WaitHelper {
     // TODO: Make public for when Solo.waitForCondition is used directly (i.e. do not want
     // assertion from waitFor)?
-    private static final int DEFAULT_MAX_WAIT_MS = 5000;
+    // DEFAULT_MAX_WAIT_MS of 5000 was intermittently insufficient during
+    // initialization on Android 2.3 emulator -- bug 1114655
+    private static final int DEFAULT_MAX_WAIT_MS = 15000;
     private static final int PAGE_LOAD_WAIT_MS = 10000;
     private static final int CHANGE_WAIT_MS = 15000;
 
     // TODO: via lucasr - Add ThrobberVisibilityChangeVerifier?
     private static final ChangeVerifier[] PAGE_LOAD_VERIFIERS = new ChangeVerifier[] {
         new ToolbarTitleTextChangeVerifier()
     };