Backed out changeset ee5f61737378 (bug 1452805) for failing awsy/test_memory_usage.py on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Mon, 16 Apr 2018 17:05:13 +0300
changeset 467420 f902138acc12ddd5fd819f5bf2a9b962f4451370
parent 467419 1a7c148094ff7cd091e8bdac97153f875749d73e
child 467421 41c442ae9e6c764a18af4db8c7e9149d3e5af20c
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1452805
milestone61.0a1
backs outee5f617373788a8ed0f20b11994679cdecf9ea96
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset ee5f61737378 (bug 1452805) for failing awsy/test_memory_usage.py on a CLOSED TREE
layout/painting/RetainedDisplayListBuilder.cpp
layout/reftests/display-list/1452805-1.html
layout/reftests/display-list/1452805-ref.html
layout/reftests/display-list/reftest.list
--- a/layout/painting/RetainedDisplayListBuilder.cpp
+++ b/layout/painting/RetainedDisplayListBuilder.cpp
@@ -779,17 +779,17 @@ ProcessFrame(nsIFrame* aFrame, nsDisplay
 
       if (!aStopAtStackingContext) {
         // Continue ascending the frame tree until we reach aStopAtFrame.
         continue;
       }
 
       // Grab the visible (display list building) rect for children of this wrapper
       // item and convert into into coordinate relative to the current frame.
-      nsRect previousVisible = wrapperItem->GetChildren()->GetBounds(&aBuilder);
+      nsRect previousVisible = wrapperItem->GetVisibleRectForChildren();
       if (wrapperItem->ReferenceFrameForChildren() == wrapperItem->ReferenceFrame()) {
         previousVisible -= wrapperItem->ToReferenceFrame();
       } else {
         MOZ_ASSERT(wrapperItem->ReferenceFrameForChildren() == wrapperItem->Frame());
       }
 
       if (!previousVisible.Contains(aOverflow)) {
         // If the overflow area of the changed frame isn't contained within the old
deleted file mode 100644
--- a/layout/reftests/display-list/1452805-1.html
+++ /dev/null
@@ -1,39 +0,0 @@
-<html class="reftest-wait">
-  <head>
-    <style>
-    div {
-      width: 200px;
-      height: 200px;
-      background-color: blue;
-      opacity: 0.95;
-      position: relative;
-    }
-    #second {
-      width: 600px;
-      height: 500px;
-      display: none;
-      background-color: green;
-    }
-    </style>
-  </head>
-  <body>
-    <div id="top" style="z-index:-4;"></div>
-    <div style="top: 10px;"></div>
-    <div style="top: 20px;">
-        <div id="second" style="top: -400px;"></div>
-    </div>
-
-    <script>
-      function doTest2() {
-        document.getElementById("second").style.display = "block";
-        document.documentElement.removeAttribute("class");
-      }
-      function doTest() {
-        document.getElementById("top").style.zIndex = -5;
-        setTimeout(doTest2, 500);
-      }
-      document.addEventListener("MozReftestInvalidate", doTest);
-    </script>
-  </body>
-</html>
-
deleted file mode 100644
--- a/layout/reftests/display-list/1452805-ref.html
+++ /dev/null
@@ -1,26 +0,0 @@
-<html>
-  <head>
-    <style>
-    div {
-      width: 200px;
-      height: 200px;
-      background-color: blue;
-      opacity: 0.95;
-      position: relative;
-    }
-    #second {
-      width: 600px;
-      height: 500px;
-      background-color: green;
-    }
-    </style>
-  </head>
-  <body>
-    <div id="top" style="z-index:-4;"></div>
-    <div style="top: 10px;"></div>
-    <div style="top: 20px;">
-        <div id="second" style="top: -400px;"></div>
-    </div>
-  </body>
-</html>
-
--- a/layout/reftests/display-list/reftest.list
+++ b/layout/reftests/display-list/reftest.list
@@ -22,9 +22,8 @@ needs-focus == 1429027-1.html 1429027-1-
 == 1432553-2.html 1432553-2-ref.html
 == 1436189-1.html 1436189-1-ref.html
 skip-if(!asyncPan) == 1437374-1.html 1437374-1-ref.html
 == 1439809-1.html 1439809-1-ref.html
 == 1443027-1.html 1443027-ref.html
 == 1443027-2.html 1443027-ref.html
 == 1443027-3.html 1443027-3-ref.html
 == 1451971-1.html 1451971-ref.html
-== 1452805-1.html 1452805-ref.html