bug 686807 - Refactor checkForCrashes to make it more usable for remote automation. r=jmaher
authorTed Mielczarek <ted.mielczarek@gmail.com>
Wed, 21 Sep 2011 10:27:16 -0400
changeset 78425 f850d4a184c955003375648a659737e1359e186f
parent 78048 75b7a4cec456459e55b2d10c0c567e55dd0f8408
child 78426 cf18cd153c5e19d9beb340904eec54019546248b
push id340
push userclegnitto@mozilla.com
push dateTue, 08 Nov 2011 22:56:33 +0000
treeherdermozilla-beta@f745dc151615 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs686807
milestone9.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 686807 - Refactor checkForCrashes to make it more usable for remote automation. r=jmaher
build/automation.py.in
--- a/build/automation.py.in
+++ b/build/automation.py.in
@@ -839,16 +839,19 @@ user_pref("camino.use_system_proxy_setti
       processLogFD.close()
 
       for processPID in processList:
         self.log.info("INFO | automation.py | Checking for orphan process with PID: %d", processPID)
         if self.isPidAlive(processPID):
           self.log.info("TEST-UNEXPECTED-FAIL | automation.py | child process %d still alive after shutdown", processPID)
           self.killPid(processPID)
 
+  def checkForCrashes(self, profileDir, symbolsPath):
+    automationutils.checkForCrashes(os.path.join(profileDir, "minidumps"), symbolsPath, self.lastTestSeen)
+
   def runApp(self, testURL, env, app, profileDir, extraArgs,
              runSSLTunnel = False, utilityPath = None,
              xrePath = None, certPath = None,
              debuggerInfo = None, symbolsPath = None,
              timeout = -1, maxTime = None):
     """
     Run the app, log the duration it took to execute, return the status code.
     Kills the app if it runs for longer than |maxTime| seconds, or outputs nothing for |timeout| seconds.
@@ -905,17 +908,17 @@ user_pref("camino.use_system_proxy_setti
                  stderr = subprocess.STDOUT)
     self.log.info("INFO | automation.py | Application pid: %d", proc.pid)
 
     status = self.waitForFinish(proc, utilityPath, timeout, maxTime, startTime, debuggerInfo, symbolsPath)
     self.log.info("INFO | automation.py | Application ran for: %s", str(datetime.now() - startTime))
 
     # Do a final check for zombie child processes.
     self.checkForZombies(processLog)
-    automationutils.checkForCrashes(os.path.join(profileDir, "minidumps"), symbolsPath, self.lastTestSeen)
+    self.checkForCrashes(profileDir, symbolsPath)
 
     if os.path.exists(processLog):
       os.unlink(processLog)
 
     if self.IS_TEST_BUILD and runSSLTunnel:
       ssltunnelProcess.kill()
 
     return status