Bug 1473253 - Stop setting onerror attribute on tabs. r=dao
authorManish Kumar <1991manish.kumar@gmail.com>
Mon, 09 Jul 2018 20:03:57 +0200
changeset 480696 f823c4cfd7ce6908bc57b18a690023efdeeef6ba
parent 480674 6064eba3af0174401077c6e212be8314cc6246be
child 480697 289ff944eadceddf973ba0ae68911b26d271ea22
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1473253
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1473253 - Stop setting onerror attribute on tabs. r=dao
browser/base/content/tabbrowser.js
browser/base/content/tabbrowser.xml
--- a/browser/base/content/tabbrowser.js
+++ b/browser/base/content/tabbrowser.js
@@ -2226,18 +2226,16 @@ window._gBrowser = {
       aUserContextId = openerTab.getAttribute("usercontextid") || 0;
     }
 
     if (aUserContextId) {
       t.setAttribute("usercontextid", aUserContextId);
       ContextualIdentityService.setTabStyle(t);
     }
 
-    t.setAttribute("onerror", "this.removeAttribute('image');");
-
     if (aSkipBackgroundNotify) {
       t.setAttribute("skipbackgroundnotify", true);
     }
 
     if (aPinned) {
       t.setAttribute("pinned", "true");
     }
 
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -106,17 +106,16 @@
           this._hiddenSoundPlayingTabs = new Set();
 
           let strId = PrivateBrowsingUtils.isWindowPrivate(window) ?
               "emptyPrivateTabTitle" : "emptyTabTitle";
           this.emptyTabTitle = gTabBrowserBundle.GetStringFromName("tabs." + strId);
 
           var tab = this.firstChild;
           tab.label = this.emptyTabTitle;
-          tab.setAttribute("onerror", "this.removeAttribute('image');");
 
           window.addEventListener("resize", this);
 
           Services.prefs.addObserver("privacy.userContext", this);
           this.observe(null, "nsPref:changed", "privacy.userContext.enabled");
 
           XPCOMUtils.defineLazyPreferenceGetter(this, "_tabMinWidthPref",
             "browser.tabs.tabMinWidth", null,