Fix one bad implicit constructor in pkix, no bug, blanket-rs=bsmith
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 07 Oct 2014 09:46:59 -0400
changeset 232379 f7d5aaa3fc97a04ae155c40f3056d8b4f2890274
parent 232378 1878882312b0dbcf0144344313f05c82ac859b07
child 232380 b6cf5c560a2f6cd4c4b0ab4a2b1f70926b5d1255
push id4187
push userbhearsum@mozilla.com
push dateFri, 28 Nov 2014 15:29:12 +0000
treeherdermozilla-beta@f23cc6a30c11 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Fix one bad implicit constructor in pkix, no bug, blanket-rs=bsmith
security/pkix/test/gtest/pkixbuild_tests.cpp
--- a/security/pkix/test/gtest/pkixbuild_tests.cpp
+++ b/security/pkix/test/gtest/pkixbuild_tests.cpp
@@ -304,17 +304,17 @@ TEST_F(pkixbuild, BeyondMaxAcceptableCer
 // A TrustDomain that explicitly fails if CheckRevocation is called.
 // It is initialized with the DER encoding of a root certificate that
 // is treated as a trust anchor and is assumed to have issued all certificates
 // (i.e. FindIssuer always attempts to build the next step in the chain with
 // it).
 class ExpiredCertTrustDomain : public TrustDomain
 {
 public:
-  ExpiredCertTrustDomain(ByteString rootDER)
+  explicit ExpiredCertTrustDomain(ByteString rootDER)
     : rootDER(rootDER)
   {
   }
 
   // The CertPolicyId argument is unused because we don't care about EV.
   virtual Result GetCertTrust(EndEntityOrCA endEntityOrCA, const CertPolicyId&,
                               Input candidateCert,
                               /*out*/ TrustLevel& trustLevel)