Bug 1563701 - Removes handshake-section component from certificate viewer. r=johannh
authordleblanccyr <danielleleb12@gmail.com>
Tue, 09 Jul 2019 16:23:18 +0000
changeset 542417 f77ccfcb52339b0aa7cb82debd2f88fbc7dcf596
parent 542416 c58773dc939aab5b059fd3335b1d2513edc8224a
child 542418 468103f84111453b6b866928ae9735380e73619f
push id11848
push userffxbld-merge
push dateMon, 26 Aug 2019 19:26:25 +0000
treeherdermozilla-beta@9b31bfdfac10 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1563701
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1563701 - Removes handshake-section component from certificate viewer. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D37055
toolkit/components/certviewer/content/certviewer.html
toolkit/components/certviewer/content/components/handshake-section.css
toolkit/components/certviewer/content/components/handshake-section.js
toolkit/components/certviewer/jar.mn
--- a/toolkit/components/certviewer/content/certviewer.html
+++ b/toolkit/components/certviewer/content/certviewer.html
@@ -7,34 +7,24 @@
 <html>
   <head>
     <meta name="viewport" content="width=device-width" />
     <meta http-equiv="Content-Security-Policy" content="default-src chrome:" />
     <script defer="defer" src="chrome://global/content/certviewer/certviewer.js"></script>
     <script defer="defer" src="chrome://global/content/certviewer/components/info-item.js"></script>
     <script defer="defer" src="chrome://global/content/certviewer/components/info-group.js"></script>
     <script defer="defer" src="chrome://global/content/certviewer/components/dummy-info.js"></script>
-    <script defer="defer" src="chrome://global/content/certviewer/components/handshake-section.js"></script>
     <script defer="defer" src="chrome://global/content/certviewer/components/certificate-tab.js"></script>
     <script defer="defer" src="chrome://global/content/certviewer/components/certificate-section.js"></script>
     <link rel="stylesheet" href="chrome://global/skin/in-content/common.css">
     <link rel="stylesheet" href="chrome://global/content/certviewer/certviewer.css">
     <title>about:certificate</title>
   </head>
   <body>
-    <h1>Certificate Viewer</h1>
-
-    <handshake-section></handshake-section> 
-
     <certificate-section></certificate-section> 
-    
-    <template id="handshake-section-template" class="section">
-      <link rel="stylesheet" href="chrome://global/content/certviewer/components/handshake-section.css">
-      <h1 class="title"></h1>
-    </template>
 
     <template id="certificate-section-template" class="section">
       <link rel="stylesheet" href="chrome://global/content/certviewer/components/certificate-section.css">
       <h1 class="title"></h1>
       <div class="certificate-tabs"></div>
       <div class="info-groups"></div>
     </template>
 
deleted file mode 100644
--- a/toolkit/components/certviewer/content/components/handshake-section.css
+++ /dev/null
@@ -1,19 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
- 
-h1 {
-  text-align: center;
-  border-bottom: 1px solid rgba(0, 0, 0, 0.15);
-  padding-bottom: 16px;
-  grid-column-start: 1;
-  grid-column-end: 3;
-}
-
-:host {
-  display: grid;
-  grid-template-columns: minmax(11em, 25%) minmax(50%, 75%);
-  grid-gap: 0 15px;
-  margin: 1.75em 0;
-  align-items: center;
-}
deleted file mode 100644
--- a/toolkit/components/certviewer/content/components/handshake-section.js
+++ /dev/null
@@ -1,31 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/* globals ReflectedFluentElement, handshakeArray, InfoItem */
-
-class HandshakeSection extends HTMLElement {
-  constructor() {
-    super();
-  }
-
-  connectedCallback() {
-    let template = document.getElementById("handshake-section-template");
-    let templateHtml = template.content.cloneNode(true);
-
-    this.attachShadow({ mode: "open" }).appendChild(templateHtml);
-
-    this.render();
-  }
-
-  render() {
-    let title = this.shadowRoot.querySelector(".title");
-    // TODO: Use fluent instead.
-    title.innerContent = "Handshake";
-
-    for (let i = 0; i < handshakeArray.length; i++) {
-      this.shadowRoot.append(new InfoItem(handshakeArray[i]));
-    }
-  }
-}
-customElements.define("handshake-section", HandshakeSection);
--- a/toolkit/components/certviewer/jar.mn
+++ b/toolkit/components/certviewer/jar.mn
@@ -10,10 +10,8 @@ toolkit.jar:
   content/global/certviewer/components/certificate-section.css      (content/components/certificate-section.css)
   content/global/certviewer/components/certificate-tab.js           (content/components/certificate-tab.js)
   content/global/certviewer/components/certificate-tab.css          (content/components/certificate-tab.css)
   content/global/certviewer/components/dummy-info.js                (content/components/dummy-info.js)
   content/global/certviewer/components/info-group.js                (content/components/info-group.js)
   content/global/certviewer/components/info-group.css               (content/components/info-group.css)
   content/global/certviewer/components/info-item.js                 (content/components/info-item.js)
   content/global/certviewer/components/info-item.css                (content/components/info-item.css)
-  content/global/certviewer/components/handshake-section.js         (content/components/handshake-section.js)
-  content/global/certviewer/components/handshake-section.css        (content/components/handshake-section.css)
\ No newline at end of file