Bug 1507805 [wpt PR 14092] - [css-grid] Some fixes on grid-container-scrollbar-* tests, a=testonly
☠☠ backed out by 46ad93280b06 ☠ ☠
authorManuel Rego Casasnovas <rego@igalia.com>
Mon, 19 Nov 2018 18:46:13 +0000
changeset 503743 f73f874848390bfe55e387771beda2ccec982460
parent 503742 ab97e60ed77733bc1c112b86ab29916173f7ae02
child 503744 bb03633ea79a37977e3c79530ffdb687afbf482b
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1507805, 14092, 191656
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507805 [wpt PR 14092] - [css-grid] Some fixes on grid-container-scrollbar-* tests, a=testonly Automatic update from web-platform-tests[css-grid] Some fixes on grid-container-scrollbar-* tests * Use Ahem font to avoid weird small pixel differences on iOS. * Fix some typos reported by @fred-wang at https://bugs.webkit.org/show_bug.cgi?id=191656#c14 -- Merge pull request #14092 from mrego/grid-container-scrollbars [css-grid] Some fixes on grid-container-scrollbar-* tests -- wpt-commits: ef7824a8ff88c95d36b31b377fe252f7c56d2da0, 1b543a1083f48c13b25f23a5f23d14f6ade958d4 wpt-pr: 14092
testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-001-ref.html
testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-ref.html
testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-ref.html
testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
--- a/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-001-ref.html
+++ b/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-001-ref.html
@@ -1,14 +1,15 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS container Layout Test Reference</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <style>
   .container {
+    font: 10px/1 Ahem;
     margin: 10px;
     background: grey;
   }
 
   .scrollX {
     overflow-x: scroll;
   }
 
@@ -27,17 +28,17 @@
     height: 100%;
   }
 
   .directionRTL {
     direction: rtl;
   }
 </style>
 
-<p>The test passes if it has the same output than the reference.</p>
+<p>The test passes if it has the same output as the reference.</p>
 
 <div style="float: left; width: 350px;">
 
   <h2>direction: ltr;</h2>
 
   <div class="container scrollX">
     <div>item</div>
   </div>
--- a/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
+++ b/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
@@ -1,18 +1,19 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS Grid Layout Test: Grid container with scrollbars</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
 <link rel="match" href="grid-container-scrollbar-001-ref.html">
-<meta name="assert" content="This test verifes that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
+<meta name="assert" content="This test verifies that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
 <link href="support/grid.css" rel="stylesheet">
 <style>
   .grid {
+    font: 10px/1 Ahem;
     margin: 10px;
   }
 
   .scrollX {
     overflow-x: scroll;
   }
 
   .scrollY {
@@ -24,17 +25,17 @@
     height: 50px;
   }
 
   .grid > div {
     background: cyan;
   }
 </style>
 
-<p>The test passes if it has the same output than the reference.</p>
+<p>The test passes if it has the same output as the reference.</p>
 
 <div style="float: left; width: 350px;">
 
   <h2>direction: ltr;</h2>
 
   <div class="grid scrollX">
     <div>item</div>
   </div>
--- a/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-ref.html
+++ b/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-ref.html
@@ -1,14 +1,15 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS container Layout Test Reference</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <style>
   .container {
+    font: 10px/1 Ahem;
     margin: 10px;
     background: grey;
     writing-mode: vertical-lr;
   }
 
   .scrollX {
     overflow-x: scroll;
   }
@@ -28,17 +29,17 @@
     height: 100%;
   }
 
   .directionRTL {
     direction: rtl;
   }
 </style>
 
-<p>The test passes if it has the same output than the reference.</p>
+<p>The test passes if it has the same output as the reference.</p>
 
 <div style="float: left; width: 350px;">
 
   <h2>direction: ltr;</h2>
 
   <div class="container scrollX">
     <div>item</div>
   </div>
--- a/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
+++ b/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
@@ -1,18 +1,19 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS Grid Layout Test: Grid container with scrollbars</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
 <link rel="match" href="grid-container-scrollbar-vertical-lr-001-ref.html">
-<meta name="assert" content="This test verifes that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
+<meta name="assert" content="This test verifies that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
 <link href="support/grid.css" rel="stylesheet">
 <style>
   .grid {
+    font: 10px/1 Ahem;
     margin: 10px;
     writing-mode: vertical-lr;
   }
 
   .scrollX {
     overflow-x: scroll;
   }
 
@@ -25,17 +26,17 @@
     height: 50px;
   }
 
   .grid > div {
     background: cyan;
   }
 </style>
 
-<p>The test passes if it has the same output than the reference.</p>
+<p>The test passes if it has the same output as the reference.</p>
 
 <div style="float: left; width: 350px;">
 
   <h2>direction: ltr;</h2>
 
   <div class="grid scrollX">
     <div>item</div>
   </div>
--- a/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-ref.html
+++ b/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-ref.html
@@ -1,14 +1,15 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS container Layout Test Reference</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <style>
   .container {
+    font: 10px/1 Ahem;
     margin: 10px;
     background: grey;
     writing-mode: vertical-rl;
   }
 
   .scrollX {
     overflow-x: scroll;
   }
@@ -28,17 +29,17 @@
     height: 100%;
   }
 
   .directionRTL {
     direction: rtl;
   }
 </style>
 
-<p>The test passes if it has the same output than the reference.</p>
+<p>The test passes if it has the same output as the reference.</p>
 
 <div style="float: left; width: 350px;">
 
   <h2>direction: ltr;</h2>
 
   <div class="container scrollX">
     <div>item</div>
   </div>
--- a/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
+++ b/testing/web-platform/tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
@@ -1,18 +1,19 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS Grid Layout Test: Grid container with scrollbars</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
 <link rel="match" href="grid-container-scrollbar-vertical-rl-001-ref.html">
-<meta name="assert" content="This test verifes that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
+<meta name="assert" content="This test verifies that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
 <link href="support/grid.css" rel="stylesheet">
 <style>
   .grid {
+    font: 10px/1 Ahem;
     margin: 10px;
     writing-mode: vertical-rl;
   }
 
   .scrollX {
     overflow-x: scroll;
   }
 
@@ -25,17 +26,17 @@
     height: 50px;
   }
 
   .grid > div {
     background: cyan;
   }
 </style>
 
-<p>The test passes if it has the same output than the reference.</p>
+<p>The test passes if it has the same output as the reference.</p>
 
 <div style="float: left; width: 350px;">
 
   <h2>direction: ltr;</h2>
 
   <div class="grid scrollX">
     <div>item</div>
   </div>