Bug 1195732 - Intermittent Talos AttributeError: 'ProcessHandler' object has no attribute 'returncode'
authorJulien Pagès <j.parkouss@gmail.com>
Thu, 10 Sep 2015 18:26:18 +0200
changeset 294837 f6b6f8fcb039fa15eed8bdff6b9adf7ecba7a13a
parent 294836 586eaa0104b4e85cd76481068a85a31bc5ce1b01
child 294838 b9783ad77d9dcdfe215f993130a00eef31c67d2e
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1195732
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1195732 - Intermittent Talos AttributeError: 'ProcessHandler' object has no attribute 'returncode'
testing/talos/talos/talos_process.py
--- a/testing/talos/talos/talos_process.py
+++ b/testing/talos/talos/talos_process.py
@@ -102,19 +102,20 @@ def run_browser(command, timeout=None, o
                 logging.info(
                     "Browser shutdown timed out after {0} seconds, terminating"
                     " process.".format(wait_for_quit_timeout)
                 )
     finally:
         # this also handle KeyboardInterrupt
         # ensure early the process is really terminated
         context.kill_process()
+        return_code = proc.wait(1)
 
     reader.output.append(
         "__startBeforeLaunchTimestamp%d__endBeforeLaunchTimestamp"
         % first_time)
     reader.output.append(
         "__startAfterTerminationTimestamp%d__endAfterTerminationTimestamp"
         % (int(time.time()) * 1000))
 
-    logging.info("Browser exited with error code: {0}".format(proc.returncode))
+    logging.info("Browser exited with error code: {0}".format(return_code))
     context.output = reader.output
     return context