Bug 1229212: Manually make the text frame inside of <input type="number"> satisfy the requirement that all flex items are block-level. r=mats
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 30 Nov 2015 21:22:44 -0800
changeset 309003 f647c855f10b4c8e9e4d5b43c5bb1a4a05d38e50
parent 309002 4ec205ad08157abb71b492a10e423de4e971770e
child 309004 8fee42e9c11b9cdd85bb6bf3e1ed0927eca83404
push id5513
push userraliiev@mozilla.com
push dateMon, 25 Jan 2016 13:55:34 +0000
treeherdermozilla-beta@5ee97dd05b5c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats
bugs1229212
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1229212: Manually make the text frame inside of <input type="number"> satisfy the requirement that all flex items are block-level. r=mats
layout/style/forms.css
--- a/layout/style/forms.css
+++ b/layout/style/forms.css
@@ -984,16 +984,19 @@ input[type=number]::-moz-number-wrapper 
   /* Prevent styling that would change the type of frame we construct. */
   display: flex;
   float: none !important;
   position: static !important;
   block-size: 100%;
 }
 
 input[type=number]::-moz-number-text {
+  display: block; /* Flex items must be block-level. Normally we do fixup in
+                     the style system to ensure this, but that fixup is disabled
+                     inside of form controls. So, we hardcode display here. */
   -moz-appearance: none;
   /* work around autofocus bug 939248 on initial load */
   -moz-user-modify: read-write;
   /* This pseudo-element is also an 'input' element (nested inside and
    * distinct from the <input type=number> element) so we need to prevent the
    * explicit setting of 'text-align' by the general CSS rule for 'input'
    * above. We want to inherit its value from its <input type=number>
    * ancestor, not have that general CSS rule reset it.