Bug 972844 - Add a Maybe Later link on about:feedback intro. r=mfinkle, a=sledru
authorMatt Brubeck <mbrubeck@mozilla.com>
Wed, 02 Apr 2014 12:34:58 -0400
changeset 183608 f4f9a56c8d0f358d2d933089386f49a0469d157f
parent 183607 3672b5508f0ea5b9d000a1b32f451ee0dd1d14ca
child 183609 94f17a84a8838d6b58ed24133bbffad8786568bb
push id3419
push userryanvm@gmail.com
push dateWed, 02 Apr 2014 16:42:40 +0000
treeherdermozilla-beta@37ab641216bd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle, sledru
bugs972844
milestone29.0
Bug 972844 - Add a Maybe Later link on about:feedback intro. r=mfinkle, a=sledru
mobile/android/chrome/content/aboutFeedback.js
mobile/android/chrome/content/aboutFeedback.xhtml
--- a/mobile/android/chrome/content/aboutFeedback.js
+++ b/mobile/android/chrome/content/aboutFeedback.js
@@ -30,19 +30,19 @@ function init() {
   document.getElementById("sad-link").addEventListener("click", function(evt) {
     switchSection("sad");
   }, false);
 
   window.addEventListener("unload", uninit, false);
 
   document.getElementById("open-play-store").addEventListener("click", openPlayStore, false);
   document.forms[0].addEventListener("submit", sendFeedback, false);
-  document.getElementById("no-thanks").addEventListener("click", function(evt) {
-    window.close();
-  }, false);
+  for (let anchor of document.querySelectorAll(".no-thanks")) {
+    anchor.addEventListener("click", evt => window.close(), false);
+  }
 
   let sumoLink = Services.urlFormatter.formatURLPref("app.support.baseURL");
   document.getElementById("sumo-link").href = sumoLink;
 
   window.addEventListener("popstate", function (aEvent) {
 	updateActiveSection(aEvent.state ? aEvent.state.section : "intro")
   }, false);
 
--- a/mobile/android/chrome/content/aboutFeedback.xhtml
+++ b/mobile/android/chrome/content/aboutFeedback.xhtml
@@ -30,32 +30,33 @@
     <div id="happy-link" class="link-box">
       <a>&intro.happyLink;</a>
     </div>
     <div id="sad-link" class="link-box-bottom">
       <a>&intro.sadLink;</a>
     </div>
     <div class="bottom-links">
       <a class="maybe-later">&intro.maybeLater;</a>
+      <a class="no-thanks">&happy.noThanks;</a>
     </div>
   </section>
 
   <section id="happy">
     <h1 class="header">&happy.header;</h1>
     <div class="message-box">
       <div class="message">&happy.message;</div>
       <div class="fine-print">&happy.finePrint;</div>
     </div>
     <div id="open-play-store" class="link-box-bottom">
       <div class="stars"/>
       <a>&happy.ratingLink;</a>
     </div>
     <div class="bottom-links">
       <a class="maybe-later">&happy.maybeLater2;</a>
-      <a id="no-thanks">&happy.noThanks;</a>
+      <a class="no-thanks">&happy.noThanks;</a>
     </div>
   </section>
 
   <section id="sad">
     <form>
       <div class="message">&sad.message;</div>
       <textarea class="description" placeholder="&sad.placeholder;" rows="8" required="true"/>
       <div class="message">&sad.lastSite;</div>