Bug 1515197 - Remove the "max" from "Max buffer size" label since it's not resizable anymore r=julienw
authorNazım Can Altınova <canaltinova@gmail.com>
Mon, 07 Jan 2019 21:37:30 +0000
changeset 509866 f46ff2feaf5f4deee1db87bf701f0ef1553044aa
parent 509865 27dc3484e7ef99a4f786fac1f9a5d29eb9de8498
child 509867 5429ea01ddec11832a4bf42b88c6355ad0c268b2
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjulienw
bugs1515197
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1515197 - Remove the "max" from "Max buffer size" label since it's not resizable anymore r=julienw We made the profiler buffer resizable before that patch but then we decided that it's not a good idea to do since we are spending so much time to allocate memory. Since buffer size is constant, we don't need to add "max" anymore. Differential Revision: https://phabricator.services.mozilla.com/D15656
devtools/client/performance-new/components/Settings.js
--- a/devtools/client/performance-new/components/Settings.js
+++ b/devtools/client/performance-new/components/Settings.js
@@ -387,17 +387,17 @@ class Settings extends PureComponent {
         label: "Sampling interval:",
         value: this.props.interval,
         id: "perf-range-interval",
         scale: this._intervalExponentialScale,
         display: _intervalTextDisplay,
         onChange: this.props.changeInterval,
       }),
       Range({
-        label: "Max buffer size:",
+        label: "Buffer size:",
         value: this.props.entries,
         id: "perf-range-entries",
         scale: this._entriesExponentialScale,
         display: _entriesTextDisplay,
         onChange: this.props.changeEntries,
       }),
       this._renderThreads(),
       this._renderFeatures()