Bug 1529182 - Inflate mRect of SVG text by 1.5 device pixels. r=longsonr
☠☠ backed out by 8a8f6c0ffb8a ☠ ☠
authorAlex Henrie <alexhenrie24@gmail.com>
Fri, 22 Feb 2019 23:20:24 -0700
changeset 518696 f39455c023332f4aebd8542a147f0c67228861cb
parent 518695 65fe397795e6fbb05313583dccf3cd8e2eeab63d
child 518697 d4dff8b8974ed60dca4645157ceaf251c8a3434b
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslongsonr
bugs1529182
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1529182 - Inflate mRect of SVG text by 1.5 device pixels. r=longsonr
layout/svg/SVGTextFrame.cpp
--- a/layout/svg/SVGTextFrame.cpp
+++ b/layout/svg/SVGTextFrame.cpp
@@ -3516,17 +3516,17 @@ void SVGTextFrame::ReflowSVG() {
     mRect.SetEmpty();
   } else {
     mRect = nsLayoutUtils::RoundGfxRectToAppRect(r.ToThebesRect(),
                                                  AppUnitsPerCSSPixel());
 
     // Due to rounding issues when we have a transform applied, we sometimes
     // don't include an additional row of pixels.  For now, just inflate our
     // covered region.
-    mRect.Inflate(ceil(presContext->AppUnitsPerDevPixel() / mLastContextScale));
+    mRect.Inflate(1.5 * presContext->AppUnitsPerDevPixel() / mLastContextScale);
   }
 
   if (mState & NS_FRAME_FIRST_REFLOW) {
     // Make sure we have our filter property (if any) before calling
     // FinishAndStoreOverflow (subsequent filter changes are handled off
     // nsChangeHint_UpdateEffects):
     SVGObserverUtils::UpdateEffects(this);
   }