Bug 1489496: Add diagnostics for strange failures. r=me,test-only
authorKris Maglione <maglione.k@gmail.com>
Wed, 13 Feb 2019 15:31:40 -0800
changeset 516872 f300070152e95b11e8d54b7ff18889ce32c79240
parent 516871 87ed9a7364355ecb9f1b75263578256ab89e5593
child 516873 f0ea53f47215d2449c7e759fa36aa76863ced3ff
child 516918 890618032e65075128c90fba0562f829190112e6
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme, test-only
bugs1489496
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1489496: Add diagnostics for strange failures. r=me,test-only
toolkit/mozapps/extensions/test/browser/browser_bug567127.js
--- a/toolkit/mozapps/extensions/test/browser/browser_bug567127.js
+++ b/toolkit/mozapps/extensions/test/browser/browser_bug567127.js
@@ -49,16 +49,20 @@ async function checkInstallConfirmation(
 
 add_task(async function test_install_from_file() {
   gManagerWindow = await open_manager("addons://list/extension");
 
   var filePaths = [
                    get_addon_file_url("browser_dragdrop1.xpi"),
                    get_addon_file_url("browser_dragdrop2.xpi"),
                   ];
+  for (let uri of filePaths) {
+    ok(uri.file != null, `Should have file for ${uri.spec}`);
+    ok(uri.file instanceof Ci.nsIFile, `Should have nsIFile for ${uri.spec}`);
+  }
   MockFilePicker.setFiles(filePaths.map(aPath => aPath.file));
 
   // Set handler that executes the core test after the window opens,
   // and resolves the promise when the window closes
   let pInstallURIClosed = checkInstallConfirmation("Drag Drop test 1", "Drag Drop test 2");
 
   gManagerWindow.gViewController.doCommand("cmd_installFromFile");