Bug 1179758 - Missing icon for 'Add to reading list' button under custom menu. r=mcomella, a=sledru
authorMartyn Haigh <mhaigh@mozilla.org>
Mon, 10 Aug 2015 14:36:27 +0100
changeset 288753 f20639a7ee401f16bc5806db8a500c23f19bfd2e
parent 288752 881a6fc93a030135780e7c62421afa25dcf08c78
child 288754 8359f2b2a385c725599b145a391fe8fda5ac76b6
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella, sledru
bugs1179758
milestone42.0a2
Bug 1179758 - Missing icon for 'Add to reading list' button under custom menu. r=mcomella, a=sledru
mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_add.png
mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_add.xml
mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_add_asset.png
mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_remove.png
mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_remove.xml
mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_remove_asset.png
mobile/android/base/resources/drawable-mdpi-v11/ic_menu_reader_add.xml
mobile/android/base/resources/drawable-mdpi-v11/ic_menu_reader_remove.xml
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_add.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
+<!-- Note: After removing all MDPI assets, the reader icons were being resolved
+           incorrectly for MDPI-V11 devices because of the way we use dummy
+           resources to cater for API 9 builds.  To fix we renamed the HDPI-V11
+           reader resources and point to them in the HDPI-V11 and MDPI-V11
+           drawable folders.  See Bug 1179758 for more info. -->
+
+<bitmap xmlns:android="http://schemas.android.com/apk/res/android"
+        android:src="@drawable/ic_menu_reader_add_asset" />
rename from mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_add.png
rename to mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_add_asset.png
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_remove.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
+<!-- Note: After removing all MDPI assets, the reader icons were being resolved
+           incorrectly for MDPI-V11 devices because of the way we use dummy
+           resources to cater for API 9 builds.  To fix we renamed the HDPI-V11
+           reader resources and point to them in the HDPI-V11 and MDPI-V11
+           drawable folders.  See Bug 1179758 for more info. -->
+
+<bitmap xmlns:android="http://schemas.android.com/apk/res/android"
+        android:src="@drawable/ic_menu_reader_remove_asset" />
rename from mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_remove.png
rename to mobile/android/base/resources/drawable-hdpi-v11/ic_menu_reader_remove_asset.png
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/resources/drawable-mdpi-v11/ic_menu_reader_add.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
+<!-- Note: After removing all MDPI assets, the reader icons were being resolved
+           incorrectly for MDPI-V11 devices because of the way we use dummy
+           resources to cater for API 9 builds.  To fix we renamed the HDPI-V11
+           reader resources and point to them in the HDPI-V11 and MDPI-V11
+           drawable folders.  See Bug 1179758 for more info. -->
+
+<bitmap xmlns:android="http://schemas.android.com/apk/res/android"
+        android:src="@drawable/ic_menu_reader_add_asset" />
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/resources/drawable-mdpi-v11/ic_menu_reader_remove.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
+<!-- Note: After removing all MDPI assets, the reader icons were being resolved
+           incorrectly for MDPI-V11 devices because of the way we use dummy
+           resources to cater for API 9 builds.  To fix we renamed the HDPI-V11
+           reader resources and point to them in the HDPI-V11 and MDPI-V11
+           drawable folders.  See Bug 1179758 for more info. -->
+
+<bitmap xmlns:android="http://schemas.android.com/apk/res/android"
+        android:src="@drawable/ic_menu_reader_remove_asset" />